Bug 159258 - A picture placeholder with a background, imported from PPTX, is not shown when presenting
Summary: A picture placeholder with a background, imported from PPTX, is not shown whe...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: All All
: medium normal
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:24.8.0
Keywords: bibisectRequest, regression
Depends on:
Blocks: Slide-Show PPTX
  Show dependency treegraph
 
Reported: 2024-01-18 10:24 UTC by Mike Kaganski
Modified: 2024-03-27 15:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
A colored placeholder (20.22 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2024-01-18 10:24 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2024-01-18 10:24:33 UTC
Created attachment 192031 [details]
A colored placeholder

Open the attached PPTX in Impress, and start presenting.

Actual result: the slide is completely white.
Expected: it should show the same as in PowerPoint, i.e., show the green rectangle (but not the placeholder icon in it, nor the prompt text).
Comment 1 Mike Kaganski 2024-01-18 10:31:46 UTC
A code pointer for debugging: to skip objects, SdrObject::IsEmptyPresObj is called. The solution should only skip text + icon, instead of the whole object.
Comment 2 Gerald Pfeifer 2024-01-18 12:37:56 UTC
Confirmed with today's snapshot,

  Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
  Build ID: 8b393bba91111bd4f8988457f3a78b0306462bf2
  CPU threads: 12; OS: Linux 6.6; UI render: default; VCL: gtk3
  Locale: en-US (en_US.UTF-8); UI: en-US
Comment 3 Gabor Kelemen (allotropia) 2024-01-22 08:36:00 UTC
This seems to be a duplicate of / minimized from bug 156400

*** This bug has been marked as a duplicate of bug 156400 ***
Comment 4 Mike Kaganski 2024-01-22 08:50:52 UTC
(In reply to Gabor Kelemen (allotropia) from comment #3)
> This seems to be a duplicate of / minimized from bug 156400

No. That one was about an image *appearing* in presentation (when it shouldn't). This one is about a rectangle of a placeholder *not appearing* (when it should).
Comment 5 Gabor Kelemen (allotropia) 2024-01-22 09:09:44 UTC
That's the same issue. The image in the other bug is hidden behind the green colored placeholder in PP, but visible in Impress because the green colored image placeholder is missing.
Comment 6 Mike Kaganski 2024-01-22 09:15:35 UTC
(In reply to Gabor Kelemen (allotropia) from comment #5)
> That's the same issue. The image in the other bug is hidden behind the green
> colored placeholder in PP, but visible in Impress because the green colored
> image placeholder is missing.

Then please keep this one. It has a carefully prepared minimal reproducer, a code pointer, etc. The dates have no meaning.
Comment 7 Stéphane Guillou (stragu) 2024-02-27 03:26:12 UTC
Repro in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d2fa44db6f8a1badece63856ee0f12db4cba9b28
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Checked with linux-64-releases bibisect repo:
- libreoffice-3.4.6rc2: picture placeholder is solid dark green, seen the same in edit mode and presentation
- since libreoffice-3.5.0rc3: picture placeholder has scaled up image icon on it, but seen the same in edit mode and presentation
- since libreoffice-3.6.0.4: icon is now a normal size, but slide is blank in presentation mode.
Comment 8 Commit Notification 2024-03-22 10:44:38 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e136900e7a971385be9367a3dcaedea54d1e7207

tdf#159258 sd: fix to show objects in slideshow if they have

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2024-03-22 14:26:12 UTC
Attila Szűcs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d323976fd6d560a9b91da3e7833dfbe9f6b78f39

tdf#159258 SD: SS: disable placeholdertext in image

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Stéphane Guillou (stragu) 2024-03-27 11:56:02 UTC
Verified in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1344e6261a1d856c71eca1e0cc29215a586bf335
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Thanks Balázs!