Created attachment 192100 [details] Edit menu on macOS Sonoma Starting sometime in LibreOffice 24.2, the shortcut for the Edit > Find and Replace menu item was changed from Command-Option-F to Command-F. Command-F has been assigned to the Edit > Find menu item so the Edit > Find and Replace menu item is no longer accessible by a keyboard shortcut.
Taking a look at git history, I noticed this commit e651d9e657f9b61fb45777d6e7edeb5cb95f8d27 (2023-09-27) German shortcut improvements for Calc with this particular block: + <prop oor:name="Command"> + <value xml:lang="x-no-translate">I10N SHORTCUTS - NO TRANSLATE</value> + <value xml:lang="en-US" install:module="macosx">.uno:SearchDialog</value> + <value xml:lang="de">.uno:Navigator</value> + </prop> I think: + <value xml:lang="en-US" install:module="macosx">.uno:SearchDialog</value> should be removed since the goal was just to change something for German language.
Patch on gerrit here: https://gerrit.libreoffice.org/c/core/+/162413 (blind fix since I don't have macOS machine)
(In reply to Julien Nabet from comment #2) > Patch on gerrit here: > https://gerrit.libreoffice.org/c/core/+/162413 > > (blind fix since I don't have macOS machine) No problem. I can test it and modify if necessary. I just couldn't remember what configuration file had these shortcuts. Thank you for pointing me to the right place.
I don't have macOS but, isn't [COMMAND]+[H] the shortcut for "Find & Replace"? Maybe the problem is not in the real shortcut but rather in what is being displayed in the menu.
(In reply to ady from comment #4) > I don't have macOS but, isn't [COMMAND]+[H] the shortcut for "Find & > Replace"? > > Maybe the problem is not in the real shortcut but rather in what is being > displayed in the menu. No. Command-H is reserved in for "hide appplication" in the standard application menu for each each application on macOS. Up until LibreOffice 7.6.x, Find and Replace had Command-Option-F for its menu shortcut on macOS.
FWIW, quote from: https://help.libreoffice.org/7.6/en-US/text/shared/04/01010000.html?&DbPAR=SHARED&System=MAC " Command+H Calls the Find & Replace dialog. " ...which is the equivalent of [CTRL]+[H] for WIN and Linux.
(In reply to ady from comment #6) > FWIW, quote from: > > https://help.libreoffice.org/7.6/en-US/text/shared/04/01010000. > html?&DbPAR=SHARED&System=MAC > > " > Command+H > > Calls the Find & Replace dialog. > " > > ...which is the equivalent of [CTRL]+[H] for WIN and Linux. Anybody know how the help files and their localizations are edited. I assume I can just command the shortcut in the helpcontent module in the LibreOffice code. But how does that edit get propagated to all of the localized help files?
(In reply to Patrick Luby from comment #7) > Anybody know how the help files and their localizations are edited. I assume > I can just command the shortcut in the helpcontent module in the LibreOffice > code. But how does that edit get propagated to all of the localized help > files? I guess the correct shortcuts for both "Find" and "Find & Replace" under macOS would need correction at <https://help.libreoffice.org/7.6/en-US/text/shared/04/01010000.html?&DbPAR=SHARED&System=MAC> ...and then its translations. CC'ing Olivier regarding the documentation part of the issue.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/20f122eb7b0d301d4e937c346f4c3c824690882d tdf#159326: Command-F assigned to both Find and Find and Replace in Calc It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thanks Julien&Patrick, appreciate the fix ups
Created attachment 192109 [details] Fix for en-US help
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/06726e12cad769a2b28c3598792f08f0c8cb4ea1 tdf#159326: Command-F assigned to both Find and Find and Replace in Calc It will be available in 24.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to ady from comment #8) > I guess the correct shortcuts for both "Find" and "Find & Replace" under > macOS would need correction at > > <https://help.libreoffice.org/7.6/en-US/text/shared/04/01010000. > html?&DbPAR=SHARED&System=MAC> I have submitted the following patch to fix the en-US help. AFAICT, only "Find & Replace" had the wrong macOS shortcut (Command-F on macOS properly displays the Find toolbar).
Slightly OT, but not that much... (In reply to Patrick Luby from comment #5) > Command-H is reserved in for "hide appplication" in the standard > application menu for each each application on macOS. (In reply to ady from comment #8) > I guess the correct shortcuts for both "Find" and "Find & Replace" under > macOS would need correction at > > <https://help.libreoffice.org/7.6/en-US/text/shared/04/01010000. > html?&DbPAR=SHARED&System=MAC> > > ...and then its translations. I assume that the "H" in [COMMAND]+[H] is related to the "h" in "hide application". Since I don't have access to macOS, I do not know whether the exact same shortcut is also valid in other languages of the OS, and the same doubt (from my part) goes for the real shortcut(s) assigned to "Find & Replace" (in languages other than English) within LibreOffice on macOS. I have no idea whether the same shortcut for "Find & Replace" in LO in English is also valid in other LO languages (UI) on macOS. So, when I mentioned "its translations", I want to make it clear that I don't mean that the correction to the official LO Help files for macOS should be automatically translated "as-is" to every other language; at least not before re-testing which shortcut actually works in each language, and whether the menu shows the correct shortcut for that language.
Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-24-2-0": https://git.libreoffice.org/core/commit/781e8620a2c48d541c80f82fdfc122881eee4bc5 tdf#159326: Command-F assigned to both Find and Find and Replace in Calc It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 192127 [details] 2024-01-23 fix
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 6d71c21890c908225945f0fc3566255ed150f660 CPU threads: 8; OS: macOS 13.6.4; UI render: Skia/Metal; VCL: osx Locale: en-US (en_DE.UTF-8); UI: en-US Calc: threaded verified, thanks for the fix.
*** Bug 159591 has been marked as a duplicate of this bug. ***
According to tdf#159591, this was not resolved for LO 24.2.0.3. I mention this because the Whiteboard field currently includes "target:24.2.0" and comment 15 in this tdf#159326 suggests it was supposed to be resolved for LO 24.2.0.3. According to the same tdf#159591, it is indeed solved in a current Dev version. YMMV.
Patrick Luby committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/help/commit/02a11cfe8fb608fdf77b4ce5a57a5dd23784f8ec tdf#159326 macOS uses Command+Option+F while other plafforms use Ctrl+H