Bug 159709 - Assignment of Shortcut "Ctrl+F " for Find messed up in the German version
Summary: Assignment of Shortcut "Ctrl+F " for Find messed up in the German version
Status: RESOLVED DUPLICATE of bug 159743
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: All All
: high major
Assignee: Xisco Faulí
URL:
Whiteboard: target:24.8.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2024-02-13 20:00 UTC by Adalbert Hanßen
Modified: 2024-02-16 13:27 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adalbert Hanßen 2024-02-13 20:00:13 UTC
This bug has been discussed in https://ask.libreoffice.org/t/lost-strg-f-nicht-mehr-die-funktion-find-aus/102031 and from that discussion follows, that it has been introduced in the German version of 

Version: 24.2.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 46169670ef4031888e143823b263577296d7867f
CPU threads: 4; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

According to erAck's comment the shortcut assignment for Search is unchanged in the en-US version.

In many programs, the key combination Ctrl-F is assigned to the search function ("find"). In most cases, if something is selected, the selected item is immediately fed in as a search pattern.

In the German localized version 24.2.2.0 the key combination Shift-Alt-F is provided for "Search" alias "Find". Shift-Alt-F is unfavorable because one easily hits the Super key instead of Alt. 

One can however manually assign "Search" to Ctl-F and re-establish the well known standard behavior of this key combination. 

Before doing so in the mentioned version, Ctrl-F has the following effect:

* if the dock for style sheets (and possibly Navigator) are minimized, it makes them visible,

* each further press switches between Styles alone and Styles+Navigator.

Ctl-F5 also does not work as advertised in the dropdown list of Ansicht>Seitenleiste. It really is Ctl-F, as mentioned before, not Ctl-F5.

In the mentioned discussion, erAck also mentions inconsistency across Writer Calc and so on. The last "slot assignment" changes there should be carefully investigated.

Cave: If one assignment is shifted, others might be affected too. The similarity of the printed strings Ctl-F and CTL-F5 also suggests that this might merely be a typing error, which then may have been corrected by simply using a new key combination, without considering that Ctl-F is used for "Search" alias "Find" everywhere else.
Comment 1 Harald Berger 2024-02-13 20:22:41 UTC
I can confirm that.

See also: https://ask.libreoffice.org/t/lost-strg-f-nicht-mehr-die-funktion-find-aus/102031

(Note: I fear that even more keyborad shortcuts are affected.)

-------
With me:
Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
Comment 2 Rainer Bielefeld Retired 2024-02-13 21:01:51 UTC
Also some small discussion on ircs://libera.chat/libreoffice-qa

[2024-02-13 17:44:35] <IZBot> core - Version 24.2.0.3, tag libreoffice-24.2.0.3 - https://git.libreoffice.org/core/commit/da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
[2024-02-13 17:59:43] <buovjaga> in https://wiki.documentfoundation.org/ReleaseNotes/24.2 I see Updated German language shortcuts for general compatibility. 
[2024-02-13 18:04:42] <Rainer_Bielefeld> buovjaga: I doubt that I ever used Software with German UI and <Alt+f> for "Find"
<buovjaga> Rainer_Bielefeld: https://git.libreoffice.org/core/commit/4b81692f8f3236082f9ac989e4e21c8119ff6e64
[2024-02-13 18:08:26] <Rainer_Bielefeld> Also see https://de.wikipedia.org/wiki/Tastenkombination
[2024-02-13 18:37:44] <IZBot> core - German shortcut improvements for Calc: - https://git.libreoffice.org/core/commit/e651d9e657f9b61fb45777d6e7edeb5cb95f8d27

Its not true that these changes will bring compatibility / unification.
I never used a German UI software with <Alt+Shift+f> for "find" – except Writer
And CALC has a different Shortcut 
And DRAW still <Ctrl+f>

Usability is completely messed with this shortcuts change, this is a major issue! Needs to be reverted with very next Version.
Comment 3 Julien Nabet 2024-02-13 22:27:36 UTC
There has been some changes with https://cgit.freedesktop.org/libreoffice/core/commit/?id=e651d9e657f9b61fb45777d6e7edeb5cb95f8d27

Then I noticed tdf#159326 and I've submitted:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=20f122eb7b0d301d4e937c346f4c3c824690882d

To be sure it's taken into account, I suppose you'll need to start from a brand new LO profile (see https://wiki.documentfoundation.org/QA/FirstSteps#Corrupted_user_profile)
Comment 4 Rainer Bielefeld Retired 2024-02-14 07:50:20 UTC
Well, it IS unreleated to user profile, I tested (only 
"find, find  replace" with Version from #2 and brand new user profile.
Comment 5 Julien Nabet 2024-02-14 08:07:52 UTC
(In reply to Rainer Bielefeld Retired from comment #4)
> Well, it IS unreleated to user profile, I tested (only 
> "find, find  replace" with Version from #2 and brand new user profile.

Ok any better with a daily build from master branch (future 24.8) ?
Indeed, the patch I had submitted has been cherry-picked on 24.2 but for a reason I ignore, it seems it doesn't work on 24.2 releases whereas on master branch it works.
Comment 6 Rainer Bielefeld Retired 2024-02-14 08:39:52 UTC
And – only for the sake of completeness:
I switched back to 7.6. because of this issue, and it seems that there are no remaining modifications in the User Profile concerning shortcuts.
Comment 7 Julien Nabet 2024-02-14 09:06:46 UTC
Gökay/Caolán: thought you might have some ideas here considering https://cgit.freedesktop.org/libreoffice/core/commit/?id=e651d9e657f9b61fb45777d6e7edeb5cb95f8d27
Comment 8 Xisco Faulí 2024-02-15 13:41:22 UTC
Regression introduced by:

author	Gökay Şatır <gokaysatir@collabora.com>	2023-09-27 13:01:46 +0300
committer	Caolán McNamara <caolan.mcnamara@collabora.com>	2023-11-19 22:28:43 +0100
commit 3bd3c41bc930406ec3d995a45a7f7060d572bbd0 (patch)
tree 1678975acb61029e330df31390321c8786041e7b
parent f53172a1141f7bb3c0950f1fe00800b633846ec4 (diff)
German keybindings:

Bisected with: bibisect-linux64-24.2
Comment 9 Caolán McNamara 2024-02-15 13:47:45 UTC
It can't be particularly hard to just revert whatever are the few lines that are problematic if someone can dig those out?
Comment 10 Xisco Faulí 2024-02-15 14:00:28 UTC
Patch in gerrit: https://gerrit.libreoffice.org/c/core/+/163441
Comment 11 Xisco Faulí 2024-02-15 14:04:46 UTC
(In reply to Xisco Faulí from comment #10)
> Patch in gerrit: https://gerrit.libreoffice.org/c/core/+/163441

Hi all,
my patch only changes the Shift-Alt-F to Ctrl+F for the search function. if there are other issues ( maybe F5 showing the Go To dialog instead of the navigator? ), please report them in different tickets. I'm not a German speaker so I can't tell what's correct and what's not
Comment 12 Commit Notification 2024-02-15 19:21:11 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b8d10e54946eefea769f9874470599244ed70a96

tdf#159709: Assign Ctrl+F to seach function in German

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Xisco Faulí 2024-02-15 19:27:47 UTC
It should be fixed in master. Feedback appreciated.
Comment 14 Rainer Bielefeld Retired 2024-02-15 19:59:48 UTC
(In reply to Xisco Faulí from comment #11)
Hi Devs, IMHO the most simple proceeding would be to revert all German UI Shortcut modifications since August 2023. It would be very very labor-intensitive to find and compare all codes in the UI, compare between versions ... At least for me.
Comment 15 Rainer Bielefeld Retired 2024-02-16 06:54:56 UTC
Adapted Summary to Fix
Comment 16 Xisco Faulí 2024-02-16 08:58:57 UTC
(In reply to Rainer Bielefeld Retired from comment #14)
> (In reply to Xisco Faulí from comment #11)
> Hi Devs, IMHO the most simple proceeding would be to revert all German UI
> Shortcut modifications since August 2023. It would be very very
> labor-intensitive to find and compare all codes in the UI, compare between
> versions ... At least for me.

Technically this is not a problem and I'm happy to do it if we decide to do so but I think the German speaking community should find an agreement on what to do first
Adding Heiko to the loop.
Comment 17 Heiko Tietze 2024-02-16 09:20:49 UTC
(In reply to Xisco Faulí from comment #16)
> I think the German speaking community should find an agreement on what to do
I don't understand the reason for the patch in first place: no ticket to BZ, no answer on https://gerrit.libreoffice.org/c/core/+/159687.

Picking just ctrl+F:

* F5 for GoToPage.
   * CTRL + F for navigator.

Guideline is to use function keys for global interactions, eg. F2 for edit mode. F5 is well known to start the Navigator but the patch considers GoTo more important. I disagree (and recommended on a current patch (https://gerrit.libreoffice.org/c/core/+/162913) to not assign a shortcut at all.
(My personal muscle memory from the time of Norton Commander is F5=Copy.)

Another problem with the patch is that some modifications are not mentioned in the summary. For example <node oor:name="V_MOD1_MOD2" oor:op="replace"> assigned to .uno:PasteSpecial. Why?

And there is also https://gerrit.libreoffice.org/c/core/+/159688/3, and maybe more.

(In reply to Rainer Bielefeld Retired from comment #14)
> revert all German UI Shortcut modifications
That's obviously what the local community requests.
Comment 19 Xisco Faulí 2024-02-16 10:29:11 UTC
I'm going to revert the patches in a commit pointing to tdf#159743. Closing this one as a duplicate of that one

*** This bug has been marked as a duplicate of bug 159743 ***