Bug 160075 - <Alt> key toggle of pointer focus to Main Menu has gone missing, <F10> toggle continues (Win)
Summary: <Alt> key toggle of pointer focus to Main Menu has gone missing, <F10> toggle...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
24.2.1.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Mike Kaganski
URL: https://listarchives.libreoffice.org/...
Whiteboard: target:24.8.0 target:24.2.3
Keywords: accessibility, bibisected, bisected, regression
: 160206 160426 160584 (view as bug list)
Depends on:
Blocks: Shortcuts-Accelerators
  Show dependency treegraph
 
Reported: 2024-03-06 20:55 UTC by V Stuart Foote
Modified: 2024-04-08 11:07 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2024-03-06 20:55:02 UTC
The <Alt> key toggle of pointer focus from canvas to Main Menu on Windows has gone missing.  The <F10> key toggle continues to function.

Work on bug 54169 [1] seems to have resolved issue for a 24.8.0 builds.

But, the missing <Alt> toggle to main menu is a regression from 7.6 builds and affects assistive technology support and heavy keyboard only usage.


=-ref-=
[1] https://gerrit.libreoffice.org/c/core/+/163215
Comment 1 Mike Kaganski 2024-03-07 02:43:09 UTC
(In reply to V Stuart Foote from comment #0)
> But, the missing <Alt> toggle to main menu

Could you please be a little bit more descriptive - what means "missing"? I keep using Alt to access the main menu.
Comment 2 V Stuart Foote 2024-03-07 03:25:59 UTC
Missing in the sense that through 7.6.5 <Alt> key entered from document canvas would shift focus to the Main Menu.

At 24.2.1.2 the <Alt> key from document has no effect, no toggle to the main menu.

Alternative of <F10> key continues to work.

And, at 24.8.0 seems already restored.
Comment 3 Stéphane Guillou (stragu) 2024-03-07 04:08:49 UTC
Reproduced:
- In 7.6.5.2 and 24.2.0.3, pressing Alt focuses the main menu, which can then be navigated with direction keys. Shortcut is documented in the help: https://help.libreoffice.org/latest/en-US/text/shared/guide/keyboard.html
- In 24.2.1, does not focus anymore.

Interesting, this shortcut doesn't apply to Linux (tried gtk3 and gen VCL), so not sure if it should be made to work across OSs, or if it should be documented to be Windows-only.

Bibisecting now.
Comment 4 Stéphane Guillou (stragu) 2024-03-07 04:39:29 UTC
Bibisected with win64-24.2 repo to first bad build [bb6094fbd3775ee06e119c52557cd6e10f409442] which points to 45023ae9619cdc4332afb8f743d1695a23e8d866, a cherrypick of:

commit 772da0f1aa6891a0b31d45d99a5978c65ed24e34
author	Mike Kaganski 	Wed Jan 10 19:48:16 2024 +0600
committer	Mike Kaganski 	Wed Jan 10 17:39:19 2024 +0100
tdf#156443, tdf#159079, tdf#158112: support Windows Alt codes >=256
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161891
Comment 5 Mike Kaganski 2024-03-07 04:40:36 UTC
(In reply to V Stuart Foote from comment #2)
> And, at 24.8.0 seems already restored.

... or rather, something wasn't backported? and it's *this* what needs (reverse-)bisecting.
Comment 6 cwendling 2024-03-07 09:22:37 UTC
(In reply to Stéphane Guillou (stragu) from comment #3)
> Interesting, this shortcut doesn't apply to Linux (tried gtk3 and gen VCL),
> so not sure if it should be made to work across OSs, or if it should be
> documented to be Windows-only.

AFAIK this is VCL-plugin dependent, and GTK doesn't do that, which IIRC Qt does (or did?), which I believe is consistent with each toolkit.

IMO it's not a good idea to diverge from the natural toolkit behavior in any direction: GTK/Linux users don't expect Alt to move focus by itself, while I guess based on this Windows users do.
Comment 7 Michael Weghorn 2024-03-14 07:42:31 UTC
(In reply to Mike Kaganski from comment #5)
> (In reply to V Stuart Foote from comment #2)
> > And, at 24.8.0 seems already restored.
> 
> ... or rather, something wasn't backported? and it's *this* what needs
> (reverse-)bisecting.

(Reverse-)bibisecting indicates activating the menu with just Alt on Windows works (again) from this master commit on:

commit a2dd71feb75d93adf0f0daac899e7476f961ec34
Author: Mike Kaganski <mike.kaganski@collabora.com>
Date:   Sat Feb 10 20:01:05 2024 +0600

    tdf#54169: implement auto-accelerator feature on Windows
    
    Change-Id: I219dfc0c8377628c10e5a19232d19260923bf614
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163215
    Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
    Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Comment 8 V Stuart Foote 2024-03-14 23:29:56 UTC
*** Bug 160206 has been marked as a duplicate of this bug. ***
Comment 9 Mike Kaganski 2024-03-15 04:09:56 UTC
Thank you - I never realized I missed the very initial comment 0, already explaining it all.

https://gerrit.libreoffice.org/c/core/+/164824
Comment 10 Mike Kaganski 2024-03-18 05:14:43 UTC
Since I forgot to put the bug number to the commit message, the proper notification didn't arrive. Sorry for that - the fix mentioned above was merged on 2024-03-15.
Comment 11 Mike Kaganski 2024-03-30 03:46:24 UTC
*** Bug 160426 has been marked as a duplicate of this bug. ***
Comment 12 Mike Kaganski 2024-04-08 11:07:30 UTC
*** Bug 160584 has been marked as a duplicate of this bug. ***