Bug 160174 - Impress/Draw internal link update sometimes erroneous depending on how slide/page order is changed
Summary: Impress/Draw internal link update sometimes erroneous depending on how slide/...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Hyperlink Slide-Sorter
  Show dependency treegraph
 
Reported: 2024-03-13 00:25 UTC by Stéphane Guillou (stragu)
Modified: 2024-03-19 23:41 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
test ODP (12.58 KB, application/vnd.oasis.opendocument.presentation)
2024-03-13 00:25 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2024-03-13 00:25:02 UTC Comment hidden (obsolete)
Comment 1 Stéphane Guillou (stragu) 2024-03-13 00:26:37 UTC
[fixed the original description]

Steps:
0. Make sure you use English or French UI (so you don't hit bug 139472)
1. Open attachment 193085 [details] (it has text on Slide 1 linked to Slide 3); test internal link
2. Drag-and-drop Slide 2 to third position in Slide Sorter

Result A: link now points to Slide 2, which is correct

3. Reload the document
4. Drag-and-drop Slide 3 to second position in Slide Sorter

Result B: link now points to a non-existent Slide 4
Expected: same as result A.

Steps 2-3 are optional, they only demonstrate that the end order of slide is the same in both cases, but the step 4 action does not update the link properly.

If testing with Draw, make sure you use a build that includes c1f097854f89f35cfc0f097a10384014042b95d6 (the fix for bug 160162)

Repro in recent trunk build as well as OOo 3.3 (when Draw Pages were still "Slides", pre-6.4). But back then, even step 2 updated the link wrong.
Repro on Ubuntu 22.04 and Windows 11.

Could be related to how the Slide Sorter sends updates, or how SdDrawDocument::UpdatePageRelativeURLs() in sd/source/core/drawdoc2.cxx works.
Comment 2 breadsathwik 2024-03-19 23:41:57 UTC
Thank you for reporting the bug. I can confirm that the bug is present in impress. Moreover, the link pointing to the target slide keeps increasing by 1 each time the process is repeated (goes to non-existent slides 5, 6, 7, etc.).

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e939685f9c6918830bd3097062790bfccbce937e
CPU threads: 8; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded