With Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 5ebdcc60701ca5f2d267f92fa69ac06202309c52 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded After tdf#152336 improvement. The issue is that now, locale setting is not preserved in the import window. As was the case until 24.2. Seems it is reset to the default locale in my case es-ES.
Created attachment 193564 [details] Sample file csv to test
Using 24.8 alpha built 2024-04-08, I can confirm that the regional setting in the import dialog is taken from menu Tools > Options > Languages and Locales > (Formats) Locale setting. I modified both the UI language and the Locale setting Options to different values. After restarting LO, the "Locale" setting in the import dialog changed according to the "Locale setting:" field used in Options. I have not tested the other field in the import dialog, "Character set". Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 748561425774fa40ab685fed80d113f7e8301158
I don't know if bibisectRequest is right here. We know that the issue was introduced with the tdf#152336 improvement. And Gabriel is working on it.
Locale is the option where the guess is most likely to be wrong. But the same problem (bad guess) can just as well apply to the other options. The user should have a way to choose whether they want to use their specific settings or have LibreOffice take a guess. Full-fledged templates (bug 62828) would be one possible solution. But I think it would be enough to have one of these options: a) automatically guess, but offer a button to restore last manually chosen options b) always use the last manually chosen option, but offer a "Guess" button My personal preference would be (b).
(In reply to Markus Keller from comment #4) > Locale is the option where the guess is most likely to be wrong. > But the same problem (bad guess) can just as well apply to the other options. > > The user should have a way to choose whether they want to use their specific > settings or have LibreOffice take a guess. > > Full-fledged templates (bug 62828) would be one possible solution. But I > think it would be enough to have one of these options: > > a) automatically guess, but offer a button to restore last manually chosen > options > b) always use the last manually chosen option, but offer a "Guess" button > > My personal preference would be (b). And we chose the second option. Take a look at this proposed patch: https://gerrit.libreoffice.org/c/core/+/165905 Best, Gabriel
Gabriel Masei committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/565b619d57a3b98b0826c4b49dee6606f9ae70e0 tdf#160582 Preserve settings saving in csv import dialog It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
In this bug I am not sure what is happening, it is a bibisect request still opened, the bug has a patch, but is still in New status.
(In reply to BogdanB from comment #7) > In this bug I am not sure what is happening, it is a bibisect request still > opened, the bug has a patch, but is still in New status. The bibisect is not needed. Changing that. The report should rather be assigned to Gabriel Masei, if he agrees. The problem was initially introduced in the 24.8 branch (and for 25.2 master) for tdf#152336. ATM, the patches for tdf#152336 are reverted by Xisco. If the patch in tdf#160582 comment 6 (for 25.2 master) is still relevant, then a back-port of it for LO 24.8 might still be needed. That is for developers (Gabriel Masei and Xisco) to evaluate. I guess that the problem reported in comment 0 should rather be re-tested with a newer dev version of the 24.2 branch. Additionally, if/when a new patch for tdf#152336 gets pushed, then this tdf#160582 should rather be re-tested again (perhaps with the introduction of some automatic unit test?).
(In reply to ady from comment #8) > If the patch in tdf#160582 comment 6 (for 25.2 master) is still relevant, > then a back-port of it for LO 24.8 might still be needed. That is for > developers (Gabriel Masei and Xisco) to evaluate. Hi Ady, The original patch was reverted in libreoffice-24-8 branch. See 68da28d3c68a6c5800bb2163b4514e7fce83c71b, thus it doesn't need any backporting
@Gabriel, should this issue be closed as RESOLVED FIXED after 565b619d57a3b98b0826c4b49dee6606f9ae70e0 ? OTOH, I think it should be mentioned in https://wiki.documentfoundation.org/ReleaseNotes/25.2
(In reply to Xisco Faulí from comment #10) > @Gabriel, should this issue be closed as RESOLVED FIXED after > 565b619d57a3b98b0826c4b49dee6606f9ae70e0 ? Yes, I think so. Just check that it doesn't reproduce anymore. It's been some time since I provided the fix... For me, locally, it seems to be fixed. > OTOH, I think it should be mentioned in > https://wiki.documentfoundation.org/ReleaseNotes/25.2 I don't know the procedure but to me it looks just normal to be mentioned since it adds a new option in CSV Import Dialog.
Verified in Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b0195d40f3abc343b88f767f4fe109a9c1d44347 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: hu-HU (hu_HU.UTF-8); UI: en-US Calc: threaded the Character Set field keeps its last value between restarts.