Bug 160971 - a11y: Editable comboboxes not properly announced by Orca
Summary: a11y: Editable comboboxes not properly announced by Orca
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+ Master
Hardware: All All
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:24.8.0
Keywords: accessibility
Depends on:
Blocks: a11y-Linux
  Show dependency treegraph
 
Reported: 2024-05-07 08:13 UTC by Michael Weghorn
Modified: 2024-05-10 19:50 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screencast of the issue (6.68 MB, video/x-matroska)
2024-05-07 08:13 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Weghorn 2024-05-07 08:13:55 UTC
Created attachment 194013 [details]
Screencast of the issue

When using the Orca screen reader on Linux, editable comboboxes are not properly announced.

Sample steps to reproduce:

1) start Orca
2) start LO Writer
3) press F6 until the formatting toolbar is focused
4) press Tab until the "Font Name" combobox is focused
5) switch between entries by using the up/down keys

Actual result:

The new value is not reliably announced. See attached screencast.

Expected result:

The new value should be announced by Orca

Tested with Orca 46.1-1 from Debian testing and current orca git main as of commit d19b34d5946cf86ef6294b4796582f42020c29b7.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b420a5cd2424d2fc5efa3fcc395d14366f4b2773
CPU threads: 32; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: en-GB (en_GB.UTF-8); UI: en-US
Calc: threaded
Comment 1 Michael Weghorn 2024-05-07 08:17:10 UTC
Related earlier discussion with Joanmarie Diggs, the Orca maintainer: see tdf#160806
Comment 2 Commit Notification 2024-05-07 14:18:16 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9f078ed7b625e86182d64d5ccfbb410cdd38081c

tdf#160971 gtk3 a11y: Set role for custom editable combobox

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Michael Weghorn 2024-05-08 09:45:39 UTC
One issue with current Orca main is that the first time that an editable combobox receives focus, it is not announced.

That turns out to happen since Orca dropped support for the deprecated "focus" event in commit [1]:

    commit 9e2902dd46c7e583a097e235dfd7e3c50b016383
    Author: Joanmarie Diggs
    Date:   Wed May 1 12:14:07 2024 +0200

        Remove the on_focus handler for the LibreOffice script
        
        The "focus:" event was deprecated many years ago. If the expected
        "object:state-changed:focused" event is absent, that bug should
        be fixed.

Pending MR for GTK 3 to emit the "object:state-changed:focused" event instead of the deprecated "focus" event:
https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7239

With that MR in place, that announcement works again.


[1] https://gitlab.gnome.org/GNOME/orca/-/commit/9e2902dd46c7e583a097e235dfd7e3c50b016383
Comment 4 Commit Notification 2024-05-10 14:25:08 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c24db71bc56c5d81a6e8fb744442b6d6358992d0

tdf#160971 a11y: Add null check in AccessibleListBox::getAccessibleRole

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-05-10 19:50:47 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ab7a94b8403e7fc89398a603a10e9002bd7e2077

tdf#160971 a11y: Send full text on changed combobox text

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.