Bug 161196 - Visibility of formatting marks related to non-printable chars and fields
Summary: Visibility of formatting marks related to non-printable chars and fields
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:24.8.0 inReleaseNotes:24.8
Keywords:
Depends on:
Blocks: Formatting-Mark
  Show dependency treegraph
 
Reported: 2024-05-21 09:43 UTC by Heiko Tietze
Modified: 2024-10-09 13:57 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
v 24.2 (left) vs. master (right) with Field highlighting only (173.32 KB, image/png)
2024-05-21 09:43 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2024-05-21 09:43:23 UTC
Created attachment 194241 [details]
v 24.2 (left) vs. master (right) with Field highlighting only

With the fix for bug 67669 the formatting marks now are treated separately from controls. That means it is possible to highlight fields (ctrl+f8) while the special formatting is hidden (ctrl+f10) and vice versa. The individual settings are controlled by tools > options > writer > formatting aids, eg. whether pilcrows are shown with ctrl+f10 or not.

However, there might be some pieces missing. In particular it happens that a) the indicator "," for zero width space is still bound to fields. Should it become rather hidden with ctrl+f10 too?

And b) the soft-hyphen has some hyphen indicator which is either on or off depending on the setting under formatting aids, but when off it wont be shown or highlighted with ctrl+f10. The solution should probably be similar to a).

Last observation is that narrow no-break spaces are no different than zero width now. Not sure this is correct. (Patch for bug 67669 or bug 135451 in preparation that makes NNBSP behave like ZWSP.)
Comment 1 LeroyG 2024-05-21 18:52:50 UTC
(In reply to Heiko Tietze from comment #0)
> In particular it happens that
> a) the indicator "," for zero width space is still bound to fields. Should
> it become rather hidden with ctrl+f10 too?
I think that it should hide (as all other non printable formatting marks). But I think that the symbol must be blue, like the other symbols.

> And b) the soft-hyphen has some hyphen indicator which is either on or off
> depending on the setting under formatting aids, but when off it wont be
> shown or highlighted with ctrl+f10. The solution should probably be similar
> to a).
I think so. Can it be blue also?

> Last observation is that narrow no-break spaces are no different than zero
> width now. Not sure this is correct.
If narrrow, then not zero.

Thanks.
Comment 2 Eyal Rozenberg 2024-05-21 22:40:22 UTC
First let's remind other readers of this bug that Ctrl+F10 means toggling "View | Formatting Marks" (I had to look it up to remember).

(In reply to Heiko Tietze from comment #0)
> However, there might be some pieces missing. In particular it happens that
> a) the indicator "," for zero width space is still bound to fields. Should
> it become rather hidden with ctrl+f10 too?

What is the argument for it being bound to field highlighting? It's not a field. And if View|Formatting Marks controls postive-width spaces, why not also zero-width spaces?

> And b) the soft-hyphen has some hyphen indicator which is either on or off
> depending on the setting under formatting aids, but when off it wont be
> shown or highlighted with ctrl+f10. The solution should probably be similar
> to a).

Why should soft-hyphens be controlled differently than ZWSP's? They're rather similar? Or if these are controlled sui generis, why not also ZWSP's?

Anyway, I like Leroy's suggestion of coloring all formatting marks.

> Last observation is that narrow no-break spaces are no different than zero
> width now. Not sure this is correct.

Wouldn't that be a separate bug?
Comment 3 Commit Notification 2024-05-24 14:31:05 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1e9a5ee8671f9a48894849d3cba4d65afa181554

Resolves tdf161196 - Visibility of formatting marks

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Heiko Tietze 2024-05-24 14:33:05 UTC
* All indicators such as "°" for no-break space but also "," for zero width space are hidden depending on non-printable characters.
* All indicator use the same color (NON_PRINTING_CHARACTER_COLOR); the hard hyphen becomes blueish with non-printable chars on and black otherwise.
* Hard blank as well as hard hyphen are controlled by Formatting Aids > Non-breaking spaces; highlighting and indicator are hidden with non-printable characters switched off.

Some fine-tuning needed for NNBSP but this patch is more tricky than expected.
Comment 5 V Stuart Foote 2024-10-09 13:57:25 UTC
*** Bug 163361 has been marked as a duplicate of this bug. ***