Created attachment 194637 [details] Screenshots comparing gtk3 and kf5 Recently we had a change in some dialogs, that now use "vertical tabs" instead of "horizontal tabs". TBH they look quite nice using gtk3, and in this case they feel like an improvement. However, in kf5 they do not look good or appealing. They do not feel like an improvement. Entries seem too squeezed or compressed... and there's no good contrast for text as in gtk3. Is there something we can do to improve the situation to render this in kf5? See attached ODG with some examples System info Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: dc243f0122ba656d2630e93bebfb84a2bfe4042a CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded
Reproduced in: Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 5a75414d1772d1fd998f405e3b9bd80b1f10c51f CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+xcb) e.g. in Page Style dialog, characters touch the surrounding frame.
The vertical tabs are not native in kf5/gen, so I had to change how they're drawn in SvxIconChoiceCtrl_Impl. Proposed patch here: https://gerrit.libreoffice.org/c/core/+/169108
Created attachment 194809 [details] Screenshot of the proposed patch (kf5) This is a screenshot taken using kf5 after applying the proposed patch.
Created attachment 194812 [details] Screenshot with https://gerrit.libreoffice.org/c/core/+/169108 v2 with a light theme (qt6)
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8708e8cf90d0ac0acbbce34b82f10ef7352d5062 tdf#161026 tdf#161355 tdf#161501 icon choice ctrl: Natively draw mouse-hover It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/92c30fd8320cd340a0daaac3a45475cbea4c3e99 tdf#161501 icon choice ctrl: Highlight full entry area It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 195345 [details] Screenshot for discussion on https://gerrit.libreoffice.org/c/core/+/170554 (PS 2) with kf5, Breeze
Created attachment 195354 [details] Screenshot with current patch (PS2) (In reply to Michael Weghorn from comment #7) > Created attachment 195345 [details] > Screenshot for discussion on https://gerrit.libreoffice.org/c/core/+/170554 > (PS 2) with kf5, Breeze Here's my screenshot of the Insert Hyperlink dialog (kf5 + Breeze Light). I am getting black text for selected items (which is the expected result), whereas you are getting white text. Any idea why we're getting different results?
(In reply to Rafael Lima from comment #8) > Here's my screenshot of the Insert Hyperlink dialog (kf5 + Breeze Light). > > I am getting black text for selected items (which is the expected result), > whereas you are getting white text. Any idea why we're getting different > results? Interesting... I've commented on that in Gerrit now: https://gerrit.libreoffice.org/c/core/+/170554/comments/f9d0f988_6a0f5eec
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/24103bdf3fa3d6962efcc6fb6ee5c95b62e29cc4 tdf#161501 icon choice ctrl: Use tab text colors It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/180f0c1ec8e195043b5f4298737a219026a8b944 tdf#161501 Improve visuals of selected entries in Vertical tabs It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/92454bca2045b9e9ca636d086cb8520ccf03be22 tdf#161501 vcl: Make TabitemValue position-aware It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a82e98f60e37d1b1d507df6645588e19a82dc72e tdf#161501 icon choice ctrl: Drop handling for WB_NOHIDESELECTION It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3720078422b2c44faf8c4cbb53f4aa09875ad0bc tdf#161501 icon choice ctrl: Drop extra drawing of entry bg It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9288e66770adc0cb5eda2dc3e242da1472172def tdf#161501 icon choice ctrl: Simplify and drop extra local variable It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/3f1c3a0faa6e0023e326f88d1bd9b84aef386a7e tdf#161501 Drop bSelected param for SvxIconChoiceCtrl_Impl::PaintEmphasis It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/72408ffd0673894da48ae344653af3b5c6c93775 tdf#161501 icon choice ctrl: Merge two methods It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c59730b46b4d7dd0af0c49ecbc852cda2871a5a0 tdf#161501 icon choice ctrl: Draw whole entry natively It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/766417d8d7de5fe3b082add4094781eadcaab072 tdf#161501 icon choice ctrl: OSL_FAIL -> assert It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/22a2ddcb77ea33fb5df0e62849a60d15cfe6e8fa tdf#161501 icon choice ctrl: Consistently use bound rect It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/42024245c72d44104ebd26bae3c601de7a876eea tdf#161501 icon choice ctrl: Draw selection within item bounds It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/efd060187aadb768f12a5b5e510db9e6e7687e23 tdf#161501 icon choice ctrl: Drop extra space between items It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c8234947b60d320565fe0ca843e095858eb9975a tdf#161501 icon choice ctrl: Drop debug-only mode switch feature It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/14e1f10793d1ec994ab70f928feeecdb384a307e tdf#161501 Drop unused SvxIconChoiceCtrl_Impl::InvalidateEntry It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7b645998e691c3a6279f5e5a7452981d77d29e20 tdf#161501 icon choice ctrl: Use a single member for entry rect It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aebf3d38201521905f6b6739b723f04bb4e93c22 tdf#161501 icon choice ctrl: Don't modify bound rect to center content It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Created attachment 195467 [details] Screencast demonstrating mouse-hover feedback being shown too long Related to this bug report: The attached screencast shows an issue with mouse-hover feedback being shown even after the mouse moved away from an entry. (This can be seen for the case where the tab entries take the full width, as in the "Format" -> "Page Style" dialog. It particularly seems to show when moving the mouse slowly out of the tab bar area. This can be observed with kf5 and gen at least. I have a local fix for this, will submit to Gerrit. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: aebf3d38201521905f6b6739b723f04bb4e93c22 CPU threads: 32; OS: Linux 6.9; UI render: default; VCL: kf5 (cairo+wayland) Locale: en-GB (en_GB.UTF-8); UI: en-US Calc: threaded
(In reply to Michael Weghorn from comment #27) > I have a local fix for this, will submit to Gerrit. -> https://gerrit.libreoffice.org/c/core/+/170923
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b3626b0142fc8b72d2249279c34badbb971addce tdf#161501 icon choice ctrl: Drop WB_HIGHLIGHTFRAME It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/87671a72505603a4cf9b3118c867654e788086da tdf#161501 icon choice ctrl: Stop hover-highlight when mouse leaves It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f3d7d24b99fec4a26afb7b53dded069649fa8fab tdf#161501 icon choice ctrl: Actually set text colors for non-selection It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.