Bug 161907 - UI: Notes Pane should be enabled by default on NormalView
Summary: UI: Notes Pane should be enabled by default on NormalView
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Notes-View
  Show dependency treegraph
 
Reported: 2024-07-05 10:37 UTC by Sarper Akdemir (allotropia)
Modified: 2024-07-22 14:38 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sarper Akdemir (allotropia) 2024-07-05 10:37:21 UTC
Notes Pane being enabled by default in the NormalView increases discoverability of the feature. See bug 33603 comment 71 for context.
Comment 1 Sarper Akdemir (allotropia) 2024-07-05 10:39:07 UTC
WIP patch at https://gerrit.libreoffice.org/c/core/+/169707
Comment 2 Óvári 2024-07-05 10:40:56 UTC
(In reply to Sarper Akdemir (allotropia) from comment #1)
> WIP patch at https://gerrit.libreoffice.org/c/core/+/169707
Should you add yourself to the Assignee field? Thank you
Comment 3 Sarper Akdemir (allotropia) 2024-07-05 10:44:29 UTC
(In reply to Óvári from comment #2)
> Should you add yourself to the Assignee field? Thank you

I'm not planning on working on resolving the test failures for enabling the feature by default right now. So the patch is up for grabs, if I start working on that I'll assign it to myself, thanks.
Comment 4 Rafael Lima 2024-07-05 20:44:08 UTC
(In reply to Sarper Akdemir (allotropia) from comment #3)
> I'm not planning on working on resolving the test failures for enabling the
> feature by default right now. So the patch is up for grabs, if I start
> working on that I'll assign it to myself, thanks.

It appears that the Cpp unit tests fail because they assume that a sequence of key presses will result in some selection state... however, when the notes pane is visible, the expected state is different.

I'm also getting crashes with a debug build when the Notes Pane is enabled.

Steps to reproduce:
1) On a clean profile, open Impress (local debug build)
2) Go to View - Notes Pane (to enable the notes pane)
3) Click the area to Notes Pane area
4) Close the file
5) Crash

System info

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 958cabd2e933ec85caf6eca4f0aacee77195fe7a
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 5 Sarper Akdemir (allotropia) 2024-07-08 09:05:39 UTC
(In reply to Rafael Lima from comment #4)
> I'm also getting crashes with a debug build when the Notes Pane is enabled.
> 
Hi Rafael, thanks for pointing out a crasher - following the steps couldn't reproduce it myself. Could you please file a seperate bug report preferably with backtrace? Thanks.
Comment 6 Óvári 2024-07-10 21:38:32 UTC
Cc'ing +1 from bug 33603 comment 72, bug 33603 comment 73, bug 33603 comment 74.