This ticket is to fix some minor UI issues for GPG and X.509, taken from the META bug 158839. Certificate Manager Terminology Make clear, that the the Certificate Manager is for GPG. It's NOT for X.509, which would need to start a Mozilla program. Certificate Chooser -> Start Certificate Manager Options -> LibreOffice -> Security -> Certificate Manager This Certificate Manager stuff didn't exist before GPG support. resulting misunderstanding messup: bug 133941: Start Certificate Manager in Windows should start certificates system store Clarify what's GPG and what's X.509 and name Mozilla profile: "NSS Password" + "Certificate Chooser" dialogues: Make clear which Mozilla profile is being used. It's NOT enough to show this in NSS Password dialog, because Mozilla profile might not have a password. Nice to have: Hint that the Mozilla profile can be selected int the LibreOffice options. Related: bug 115884: PDF signing should mention it only works with x509 certificates Broken window resize rules: IMPORTANT: Check behavior for different LO UI frontends. Linux vclplugin `gtk3`, `kde` and `gen`. (kde and gen are often broken while gtk works fine) Windows: ??? Nice-To-Have: macOS Multiple GPG related windows and UI widgets have bad resizing behavior. And often it would be helpful for the UI experience to maximize them to the full screen size. Task: Make GPG related windows and UI widgets properly resize. "View Certificate" dialog (in the "Certificate Chooser") - Lines in the details tab aren't fully visible. The content of the current line is readable via the lower text area. But resizing the window may be much more convenient to get an overview. - Broken with all SAL vcplugin gen, kde4 and gtk3 on Linux. Options -> LibreOffice -> Security -> Certificate Path / Certificate - Everything is accessible and for entries with long names a vertical scrollbar appears. But resizing the scrollable area may be much more convenient, especially if there are a lot of Mozilla profiles on the system. - Broken with SAL vclplugin `gen` and `kde4` on Linux. Works fine with SAL vclplugin `gtk3` Hints: https://git.libreoffice.org/core/+/2175d3a847d8644a059c3cb6f3b668ac73c7bdda/cui/uiconfig/ui/certdialog.ui https://git.libreoffice.org/core/+/2175d3a847d8644a059c3cb6f3b668ac73c7bdda/cui/source/options/certpath.cxx REGRESSION: worked in LibreOffice-5.3 with `gen` (-> do bibisect) Certificate Chooser: Make the window and the contained widgets resizeable to help with many keys and additional columns. See also: bug 161871: Certificate Chooser -> regression 9f327102c: columns broken, users may explicitly want X.509 or GPG, usage needed bug 113192: [Digital-Signatures][OpenPGP] There's too few indication of which key is which in the Certificate Chooser
Nice-To-Have for CertificateChooser: Give a hint, that the X.509 keys are from Mozilla (Firefox / Thunderbird / SeaMonkey), but the GPG keys are from GnuPG and NOT from Mozilla-Thunderbird >= 78. (Thunderbird introduced GPG store in 2020)
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6fd88230b543e98ff6981472cc075fd7bd2f6d9b tdf#161909: Repair certdialog columns with VCLPLUGIN != gtk3 It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/36a589989660338bfaec65736f6a6b5b129d5e37 tdf#161909: Fix resizing and behavior for "View Certificate" dialog. It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f2f1782d23abc48dadc21a82181417c557b2090d tdf#161909: Fix resize for cert listings (GtkBox instead of GtkGrid) It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a833f9dfc7e1f0bd865c01d9b777cd44b8a6f767 tdf#133941 tdf#161909: Label the "Certificate Manager" with "GPG". It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/fb56e1e284925937eff4386a7e3655c0f3182640 tdf#161909: Escape filepaths for password dialog. It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/156c3c1e5a32d5eee507c3d776574af272f52d21 tdf#161909: Show key type in CertificateViewer. It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b1fcc20db80e7b1ba86594b3eef199965057d499 tdf#161909: mention that keys/certs preselection is for ODF only It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4923331a2bc0c7d31cdb0af18b62f92e8433a071 tdf#113278 tdf#115884 tdf#161909: Add X.509 in static labels for PDF signing. It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Adolfo Jayme Barrientos committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/help/commit/b8f378c137df5311da024b67b61e230ad1d3d8f0 tdf#115884 tdf#133941 tdf#161909 Update help text to match UI
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/9383f83b05f3049c350bbc784618da3d6f1a5556 tdf#161909: request GPG keys exclusively for chooseCertificatesImpl It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/8f9f04297602a29726089227a0903ca177c98f43 tdf#161909: make showing GPG keys only an explicit functionality It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/684b7b5a8bc9a0632e0cb87c18133814acc20188 tdf#161909: show NSS cert DB path (MOZ profile) in password dialog It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Moritz Duge committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6c640ee2662318f32a22d8293ad7498109681933 tdf#161909: show where the certs in the CertificateChooser are from It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.