Anyway, after weeks or months trying to do it, I was told in the QA channel that it doesn't work with normal PGP keys. Could someone add a textbox at the bottom of the signing window: "You can only sign PDFs with x509 certificates." ? [14:23] <samuel_m> marcoagpinto: gpg signing only works for odf docs [14:24] <marcoagpinto> samuel_m: Buaaaaaaaaaaaaaa [14:24] <marcoagpinto> why is there the option then? [14:24] <marcoagpinto> for weeks/months that I have been at it trying [14:24] <marcoagpinto> :( [14:25] <samuel_m> marcoagpinto: you can use x509 certificates to sign pdfs [14:25] <marcoagpinto> samuel_m: can't there be placed a tip saying that? [14:25] <marcoagpinto> otherwise, other persons like me will think it is a bug [14:25] <marcoagpinto> :( [14:25] <samuel_m> marcoagpinto: feel free to do so [14:26] <marcoagpinto> me? [14:26] <marcoagpinto> I am just into linguistic stuff... spellers + autocorrect [14:27] <marcoagpinto> maybe Áron could do it? [14:27] <marcoagpinto> where is he? [14:27] <marcoagpinto> "You can only sign PDFs with x509 certificates." [14:27] <marcoagpinto> :) [14:28] <marcoagpinto> you just need to add a TextGadget in the bottom of the signing window with this text
Guess we should update https://help.libreoffice.org/6.1/en-US/text/shared/01/selectcertificate.html and just change "Select Certificate" window to "Select X.509 Certificate".
(In reply to Timur from comment #1) > Guess we should update > https://help.libreoffice.org/6.1/en-US/text/shared/01/selectcertificate.html > and just change "Select Certificate" window to "Select X.509 Certificate". Great idea! :-) Thank you!
If Bug 113278 is solved, than this could be a duplicate.
+1, this needs to be specified to save some time for other users who wonder why they can sign Libreoffice documents with PGP, but not PDFs.
Heiko, can you please get this done? Looks simple and it's last moment for 7.0.
Code pointer: https://opengrok.libreoffice.org/xref/core/xmlsecurity/uiconfig/ui/selectcertificatedialog.ui?r=eac30170#24 https://opengrok.libreoffice.org/xref/core/cui/uiconfig/ui/signsignatureline.ui?r=ba439096#150
Vishwas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a1146fd95022196636f8c41f7322a7257955cef4 tdf#115884 PDF signing should mention it only works with x509 certificates It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I just saw the commit ehm? It clearly said "certificate", not "key", so that it's only working on X.509 *certificates* and not with PGP *keys* should have been completely obvious...
Created attachment 169188 [details] Video of bug happening Hello! I have found out how it happens. It happens if it is the first file opened with LibreOffice. Because on the next opened files, it doesn't happen any more. But, if we reboot the computer and open it again as the first file, it happens. Very strange, isn't it? See attached video of it happening.
ops... wrong e-mail link... sorry... please delete my post.
(In reply to Rene Engelhard from comment #8) > ehm? It clearly said "certificate", not "key", so that it's only working on > X.509 *certificates* and not with PGP *keys* should have been completely > obvious... What do you suggest? (In reply to Commit Notification from comment #7) > Vishwas committed a patch related to this issue. Marco, can we resolve this issue as fixed?
(In reply to Heiko Tietze from comment #11) > > Marco, can we resolve this issue as fixed? No, because in several places people call "certificates" to everything. Not even I sometimes know if they are referring to keys or other. The best is to clarify it for the users that it requires a blah blah X something certificate.
I don't understand Comment 12, it needs precision or this bug be closed. Because it's clear now with added X. 509, simple "select X.509 certificate".
Help also needs to be improved, or can be done in this bug or another.
(In reply to Timur from comment #13) > I don't understand Comment 12, it needs precision or this bug be closed. > Because it's clear now with added X. 509, simple "select X.509 certificate". Timur, if it now shows "select X.509 certificate" the bug can be closed. :-) Thanks!
(In reply to Marco A.G.Pinto from comment #15) > (In reply to Timur from comment #13) > > I don't understand Comment 12, it needs precision or this bug be closed. > > Because it's clear now with added X. 509, simple "select X.509 certificate". > > Timur, if it now shows "select X.509 certificate" the bug can be closed. No need to guess, just look at the commit https://git.libreoffice.org/core/commit/a1146fd95022196636f8c41f7322a7257955cef4
Reverted the patch. This is more complicated as the same dialog is used for ODF files as well.
Ilmari Lauhakangas committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/453af38f46ad4c2eb3125b8d2967c91b950b3c50 tdf#155049 Revert "tdf#115884 PDF signing should mention It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.