Bug 161971 - Icon in custom menu not visible (Windows 11, kf5/kf6, gtk3) (steps in comment 3)
Summary: Icon in custom menu not visible (Windows 11, kf5/kf6, gtk3) (steps in comment 3)
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Toolbars
  Show dependency treegraph
 
Reported: 2024-07-09 13:30 UTC by AdiSto
Modified: 2024-12-14 19:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Capture with the bug and the “Tools/Customize/Menus” dialog box, the “Assigned Commands” window (100.16 KB, image/jpeg)
2024-07-09 13:33 UTC, AdiSto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description AdiSto 2024-07-09 13:30:47 UTC
Description:
Custom menu that points towards macros. The problem is that the icons do not appear, as on the toolbar. The problem only in Windows 11, in Windows 10 is OK.

Steps to Reproduce:
1.Custom toolbar. Attach icon to button. OK
2.Custom menu. Icon is attached in step 1
3.In the “Tools/Customize/Menus” dialog box, the icons is showing in the “Assigned Commands” window
4. In custom menu, icons is missing. Only the place for icon, but empty

Actual Results:
Icons in custom menu not showing

Expected Results:
Icons in custom menu  showing


Reproducible: Always


User Profile Reset: No

Additional Info:
All built-in menus OK. The bug only in Windows 11. In Windows 10 everything is OK.
Comment 1 AdiSto 2024-07-09 13:33:31 UTC
Created attachment 195186 [details]
Capture with the bug and the “Tools/Customize/Menus” dialog box, the “Assigned Commands” window
Comment 2 nutka 2024-07-29 07:33:29 UTC
Repro on Windows 11.

Version: 24.2.5.2 (X86_64) / LibreOffice Community
Build ID: bffef4ea93e59bebbeaf7f431bb02b1a39ee8a59
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (pl_PL); UI: en-US
Calc: threaded



See also:
Bug 123062 (Allow assigning an icon for a new menu or context menu entry in the Customize dialog)
Comment 3 Buovjaga 2024-09-02 19:02:40 UTC
1. Tools - Customize
2. Toolbars, add a command without an icon, such as "50%"
3. With the added command selected, click Modify - Change Icon and pick an icon
4. Switch to the Menus tab, click the hamburger icon next to the Target dropdown and select Add and add a new menu
5. Add the command from step 2 into the new menu
6. OK, now open the new menu from the menu bar

This was a very tedious one to investigate. From what I can see, this is not reproduced with the gen backend on Linux, but shows in both kf5/kf6 and gtk3 in addition to Windows.

As testing old versions on Linux without using the gen backend is hit and miss, I used Windows to dig into the history. It looked like the bibisect repo for 4.4 had the goods, but I got a strange result, apparently this range of commits:

https://git.libreoffice.org/core/+log/95cec52515a51a96e58fae9aa11ca2459365e66d..4554e71e46c2ba68d1559e5e90bd648916bd67a3

None of those make sense to me as a potential cause for this, unless it's that 8a75dafbe19b19fe8b39e4e85f5ffa47da23f41e "make FastAttributeList's unknown attribute value be passed as OString" for some weird reason.
Comment 4 Buovjaga 2024-09-03 03:15:06 UTC
(In reply to Buovjaga from comment #3)
> https://git.libreoffice.org/core/+log/
> 95cec52515a51a96e58fae9aa11ca2459365e66d..
> 4554e71e46c2ba68d1559e5e90bd648916bd67a3

To clarify, 95cec52515a51a96e58fae9aa11ca2459365e66d there is a good commit and is included in the URL just because of how gitiles displays the list of commits.