Bug 162223 - UI: displayed comments in trouble after duplicating the sheet
Summary: UI: displayed comments in trouble after duplicating the sheet
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Calc-Comments
  Show dependency treegraph
 
Reported: 2024-07-27 07:28 UTC by Manu
Modified: 2024-07-28 22:48 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
bug Duplicate Sheet and Comments in trouble (74.77 KB, image/jpeg)
2024-07-27 07:28 UTC, Manu
Details
bug Duplicate Sheet Comments (you have to duplicate to see the bug) (12.15 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-07-27 12:06 UTC, Manu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Manu 2024-07-27 07:28:55 UTC
Created attachment 195548 [details]
bug Duplicate Sheet and Comments in trouble

Version: 24.2.4.2 (X86_64) / LibreOffice Community
Build ID: 51a6219feb6075d9a4c46691dcfe0cd9c4fff3c2
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

Steps (see picture attached for results):
New file, A2 and B2 fusion, Insert and display comments in A1 and A2
Save file, close, reopen, duplicate sheet : beautiful arrows !!!
Extent size of column, magic : there are duplicated comments !!!
Try to manage these duplicated comments and you will finish the day crazy!!!
Good luck!
Comment 1 m_a_riosv 2024-07-27 08:11:12 UTC
Please attach a sample file(s), reduce the size as much as possible without private information.
Comment 2 Manu 2024-07-27 11:51:10 UTC
I understand your need.
But it's impossible.
The bug is only during the session.
When you close the file, the bug disappears.
Conclusion: the data are correctly stored in the file.
But is it expected that we have to save the file, close the file, and reopen in order to clean a bug that shouldn't occur?
Comment 3 Manu 2024-07-27 12:06:32 UTC
Created attachment 195550 [details]
bug Duplicate Sheet Comments (you have to duplicate to see the bug)

Here the initial sheet.
You have to duplicate the sheet in order to see the bug.
Then expand the column too.
Comment 4 m_a_riosv 2024-07-27 13:50:06 UTC
Reproducible
Version: 24.2.5.2 (X86_64) / LibreOffice Community
Build ID: bffef4ea93e59bebbeaf7f431bb02b1a39ee8a59
CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
and
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4be345abd678babcbb989db1e7a16021ad1da562
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

Seems they are fake duplicates, after save and reopen the file, those duplicates disappear.
Comment 5 Aron Budea 2024-07-28 22:43:51 UTC
This is a regression, and could be bibisected to the following commit using repo bibisect-linux-64-6.1. Adding CC: to Dennis Francis.

https://git.libreoffice.org/core/commit/b491bb4b1e2eb6745ced3e958550ea8526cd2f2a
Author:     Dennis Francis <dennis.francis@collabora.co.uk>
AuthorDate: Thu Jun 21 15:13:44 2018 +0530
Commit:     Dennis Francis <dennis.francis@collabora.co.uk>
CommitDate: Wed Jun 27 10:01:37 2018 +0200

    tdf#112452 : Refine the fix for tdf#94561
Comment 6 Aron Budea 2024-07-28 22:48:50 UTC
(In reply to Aron Budea from comment #5)
> https://git.libreoffice.org/core/commit/
> b491bb4b1e2eb6745ced3e958550ea8526cd2f2a
Actually, this is a cherry-pick to 6.1, original commit in master branch (6.2) is the following:
https://git.libreoffice.org/core/commit/eebd2c72ce2d6003975de6b5bfe14b204b382a6e
Author:     Dennis Francis <dennis.francis@collabora.co.uk>
AuthorDate: Thu Jun 21 15:13:44 2018 +0530
Commit:     Eike Rathke <erack@redhat.com>
CommitDate: Tue Jun 26 15:07:05 2018 +0200

    tdf#112452 : Refine the fix for tdf#94561