Bug 162475 - Allow adding condition for format in manage dialog
Summary: Allow adding condition for format in manage dialog
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Pranam Lashkari
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: Conditional-Formatting-Managing
  Show dependency treegraph
 
Reported: 2024-08-15 02:10 UTC by Pranam Lashkari
Modified: 2024-10-03 15:05 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pranam Lashkari 2024-08-15 02:10:04 UTC
Description:
Allow users to add conditions for formatting from the manage conditions dialog directly for user convenience.

This allows the user to focus just on new conditions without jumping to another dialog(conditional format) with all conditions and accidental edits.

Steps to Reproduce:
open dialog from Format -> Condition -> manage


Actual Results:
When trying to add a new condition new condition Format condition dialog is opened.

Expected Results:
Whenever possible adding conditions should be done in manage dialog itself


Reproducible: Always


User Profile Reset: No

Additional Info:
Comment 1 Roman Kuznetsov 2024-08-15 10:02:36 UTC
There are already patches with implementing this feature but anyway anyone from UX should look at it
Comment 2 Commit Notification 2024-08-15 10:29:02 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/20350c7f1085b0a73191e318e14f2dbd69553e0b

sc: tdf#162475 manage conditional format with simpler dialog

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2024-08-15 10:43:05 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/723e035e1fbafdedf7ed64b8de4c14ef0ef038ea

tdf#162475 sc: added date condition option in conditional format manage dialog

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2024-08-15 12:54:25 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/367c2319a8067e6929a4df5c199698db9b07cc56

tdf#162475 sc: preview style in easy format dialog

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-08-15 12:54:27 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8090d7a54f71ccf897d725bbae3f55eb346a240a

tdf#162475 sc: display all the conditions of same ranges in conditional format manager

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-08-15 16:41:01 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bdd06e255cf89cbc1ee100306d27739dbb5290a4

tdf#162475 sc: now conditions can be edited from easy conditional format dialog

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Heiko Tietze 2024-08-16 07:59:17 UTC
We should discuss enhancements before the implementation has started.

Besides the weird fact that adding a new condition makes the manage dialog disappear I think a dialog on top of another is not too bad. And with the patches we still have a dialog to pick the style.

I would rather go for inline editing. Add could insert a blank line with a dropdowns for 

Type         Evaluation    Value     Style
[Cell Value] [is equal to] [     1]  [Accent ]
[Formula]                  [   =A1]  [Good   ]

(this needs to be accompanied by at least an option to remove)