Bug 162692 - Editing conditional formatting from one sheet make them appear on another sheet
Summary: Editing conditional formatting from one sheet make them appear on another sheet
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.3 release
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 163406 (view as bug list)
Depends on:
Blocks: Conditional-Formatting-Managing
  Show dependency treegraph
 
Reported: 2024-08-29 13:26 UTC by Roman
Modified: 2024-10-14 08:54 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
ysl_format.ods (11.83 KB, application/vnd.oasis.opendocument.spreadsheet)
2024-08-29 13:27 UTC, Roman
Details
ysl.mp4 (1.69 MB, video/mp4)
2024-08-29 14:47 UTC, Roman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman 2024-08-29 13:26:45 UTC
Description:
EN:Conditional formatting, after making changes and clicking OK, opens again on all other sheets.
RU: Условное форматирование, после внесения изменений и нажатия ОК открывается вновь на всех других листах.


Steps to Reproduce:
EN: 1. Open the attached file
2. Format – Conditional – Management
3. Make any desired change and click OK
4. Go to the next sheet
5. Format – Conditional – Management
6. Error!
RU: 1. Открыть прикреплённый файл
2. Формат – Условное – Управление
3. Вносим любое желаемое изменение и нажимаем ОК
4. Переходим в соседний лист
5. Формат – Условное – Управление
6. Ошибка!


Actual Results:
EN: The Conditional Management window is displayed on each sheet after making changes.
RU: Окно “Условное управление” после внесения изменений отображается на каждом листе.


Expected Results:
EN: The Conditional Management window is displayed only on its own sheet after making changes.
RU: Окно “Условное управление” после внесения изменений отображается только на своем листе.



Reproducible: Always


User Profile Reset: Yes

Additional Info:
EN: I'm shocked!, It's not for nothing that MO has 3 sheets, they've done it all beautifully for a long time.
RU:  я в шоке!, Не зря в MO 3 листа, они давно это все сделали красиво.
Comment 1 Roman 2024-08-29 13:27:33 UTC
Created attachment 196097 [details]
ysl_format.ods
Comment 2 m_a_riosv 2024-08-29 14:13:18 UTC
I can't reproduce
Version: 24.8.1.1 (X86_64) / LibreOffice Community
Build ID: ef51c4a0cd35185debf25ad9d0db6a1c14bed5a0
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded

How do you change the sheet while CF window is open?
Comment 3 Roman 2024-08-29 14:45:06 UTC
(In reply to m_a_riosv from comment #2)
> I can't reproduce
> Version: 24.8.1.1 (X86_64) / LibreOffice Community
> Build ID: ef51c4a0cd35185debf25ad9d0db6a1c14bed5a0
> CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render:
> Skia/Raster; VCL: win
> Locale: es-ES (es_ES); UI: en-US
> Calc: CL threaded
> 
> How do you change the sheet while CF window is open?

Click OK, close the CF window and go to another tab
Нажимаешь ОК, Окно CF закрываешь и идёшь в другую вкладку
Comment 4 Roman 2024-08-29 14:47:24 UTC
Created attachment 196098 [details]
ysl.mp4
Comment 5 Roman 2024-08-29 14:48:24 UTC
unconfirmed
Comment 6 ady 2024-08-29 15:38:27 UTC
Reproduced.

In attachment 196097 [details], the first worksheet has a different set of CF than the second worksheet, but if you edit the CF of the first worksheet, then the second worksheet CF dialog shows the CF of the first worksheet, not the original one.

Whether the second set of CF was replaced, or just "hidden" somewhere, we don't really know, but the edition of the CF of the first worksheet is not automatically applied to the second worksheet; the initial CF of the second worksheet is still seen on the main area. So, some kind of refresh of the content of the CF dialog is needed when changing to a different worksheet after one CF has been "edited".

I am using quotation marks for "edited" because no actual change is needed. If you just press on "Edit" and cancel the edition, it is enough to trigger the problem on the second worksheet; no actual change is needed.
Comment 7 ady 2024-08-29 15:49:42 UTC
No repro in LO 24.2.5. Repro with LO 24.8.0.

Beware that LO 25.2 alpha is currently in some unclear status. The CF manager shows all ranges of all worksheets, but does not specify to which spreadsheet each cell range belongs. Additionally, there are no multi-level conditions (as in "Condition 1" and "Condition 2"). Wile correcting all that for 25.2, LO should also get rid of the _forced_ unification of ranges (and allow the unification by a manual selection of conditions and pressing some key). This is all a different bug report, of course.
Comment 8 Roman 2024-08-29 17:47:08 UTC
(In reply to ady from comment #7)
> No repro in LO 24.2.5. Repro with LO 24.8.0.
> 
> Beware that LO 25.2 alpha is currently in some unclear status. The CF
> manager shows all ranges of all worksheets, but does not specify to which
> spreadsheet each cell range belongs. Additionally, there are no multi-level
> conditions (as in "Condition 1" and "Condition 2"). Wile correcting all that
> for 25.2, LO should also get rid of the _forced_ unification of ranges (and
> allow the unification by a manual selection of conditions and pressing some
> key). This is all a different bug report, of course.

I have a whole table with 2 tabs and 3 tabs working just on certain ranges and in each separate tab, etc. Is there any way I can be added to the list to study what you want to do?
У меня там целая таблица с 2 вкладками  и 3 вкладками работающая как раз на определённых диапазонах и в каждой отдельной вкладке и тд . Можно меня как-то добавить в список на изучение того что вы хотите сделать?
Comment 9 ady 2024-08-29 18:29:02 UTC
(In reply to Roman from comment #8)
> (In reply to ady from comment #7)
> > No repro in LO 24.2.5. Repro with LO 24.8.0.
> > 
> > Beware that LO 25.2 alpha is currently in some unclear status. The CF
> > manager shows all ranges of all worksheets, but does not specify to which
> > spreadsheet each cell range belongs. Additionally, there are no multi-level
> > conditions (as in "Condition 1" and "Condition 2"). Wile correcting all that
> > for 25.2, LO should also get rid of the _forced_ unification of ranges (and
> > allow the unification by a manual selection of conditions and pressing some
> > key). This is all a different bug report, of course.
> 
> I have a whole table with 2 tabs and 3 tabs working just on certain ranges
> and in each separate tab, etc. Is there any way I can be added to the list
> to study what you want to do?

Regarding that paragraph from my comment 7, there is no need to do anything here in this report. What I described in that paragraph is a different problem with the conditional format manager dialog, that can be seen with the master development branch (LO 25.2 alpha+) but not in LO 24.8 nor in LO 24.2, simply because the CF manager dialog is (very) different in the new development version in comparison to older versions.

Regarding the current ticket, tdf#162692, the next step is to bisect it, in order to identify the source of the problem.
Comment 10 m_a_riosv 2024-08-29 23:11:34 UTC
I see now with
Version: 24.8.1.1 (X86_64) / LibreOffice Community
Build ID: ef51c4a0cd35185debf25ad9d0db6a1c14bed5a0
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 11 BogdanB 2024-10-12 16:00:36 UTC
Armin, it seems this little commit created some problems, can you take a look?


author	Armin Le Grand (allotropia) <armin.le.grand.extern@allotropia.de>	2024-03-29 16:28:04 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2024-04-03 15:49:06 +0200
commit 387a9c445793e8377f85e508d935dc070fd8ab74 (patch)
tree 65a5273548d18bb16e7db75dd60f6460e882cb15
parent f8e927e6cdbc99240d8967a5e920ce33d45838d2 (diff)
tdf#160252 ITEM remove unnecessary cleanups of shared_ptr
Change-Id: I5654d65097bf88b70cb85937de3ce111fa7e4345
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165552
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
Comment 12 m_a_riosv 2024-10-12 21:07:07 UTC
*** Bug 163406 has been marked as a duplicate of this bug. ***