Description: About the color, the borders of the triangle comment indicator is using the same color as the gridline, which limits customization. I for one dislike the border and wish for a solid indicator, adding a specific option for the indicator border will make everyone happy, imo. About the size (or placing), I notice the indicator takes the border space, a little to the right of the cell (I can't really tell if it also takes the upper border space). The problem is, when we are not using borders for the cells with comments, this results in horrible asthetics, looking like the comment overlaps the cell to the right. I wouldn't mind if the indicator simply takes the inner corner of the cell, but I actually prefer the older asthetics of the square indicator, in which there is some space between the indicator and the corner, so you can see the color of the cell completely envelops the indicator, but this is just an opinion. Steps to Reproduce: 1.Take a 3 by 3 cell area and change the color so you don't see the grid lines. 2.Create a comment 3.Notice the overlap to the right 4.Change the grid lines color on the tools to a good contrat color to the one you chose for the cells Actual Results: As in the description. Expected Results: Better customiation and aesthetics. Reproducible: Always User Profile Reset: No Additional Info: Version: 24.8.0.3 (X86_64) / LibreOffice Community Build ID: 0bdf1299c94fe897b119f97f3c613e9dca6be583 CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Btw, let me know if there are workarounds.
Please attach a sample file, reduce the size as much as possible without private information.
The border is needed to keep the indicator visible in case of cell background color close to the indicator color. That has been the same before. How about changing the grid line color to white? The patch also introduced the expert option NoteIndicator to avoid resize on zoom, see bug 158958 comment 23.
I agree the indicator needs a border, in most cases, but I'd also like to be able to customize it to a solid color, without changing the grid lines. Yes, I use the NoteIndicator too to make it bigger (for me, 8 is the sweetspot, btw), that was very thoughtful! The main issue here, which you didn't reply to, is that I think it is better aesthetics for the indicator to be placed in the inner corner, not the outter corner, as it seems to be now. This way, when the cell doesn't have borders, it wouldn't look like the indicator overlaps to the right (and to the top, I think, it is hard to see). On a sidenote, the names for the colors can be confusing: "Comment", for the indicator, and "Note Indicator" (not Excel!). If it would be refactored to add a "Comment Indicator Border", it would make sense to rename the others on the same refactor.
I meant "Notes background", not "Note Indicator."
Created attachment 196086 [details] Spreadsheet showing comment indicator on cells with no borders
We fought hard about space and the 1px off the border was not accepted. Besides, doesn't look odd to have two borders? About another option to tweak the indicator border: -1 from my side. Do you want more opinions? Renaming to "Note indicator" sounds reasonable (also since we can customize the actual comment colors now with the heading "Comments", see bug 61242).
You mean 1px off the border to the inside? The problem now is that it looks like it is off to the outside. I understand people are fighting for more space inside the cell.. how about two different options for the placing: outer border if there is border or grid (here is actually 2 cases, border on top and border on the right, can have one without the other) and inner border if there are no borders or grid? In this case, it would always stick to the visual edge of the cell. There could be some bad aesthetics if you have cells in the same collums with different border styles. Because the indicators would not align. But then again, this may already be bad aesthetics in the first place.
I myself, would be happy with an extra experimental(?) option to tweak the placing. I would use -2px in both dimensions always and live happily ever after.
[Automated Action] NeedInfo-To-Unconfirmed
(In reply to Ademas from comment #9) > I myself, would be happy with an extra experimental(?) option to tweak the > placing. I would use -2px in both dimensions always and live happily ever > after. I guess this is not something that should necessarily merit an additional option, especially considering that the comment should be something that is 'attached to' rather than 'part of' a single cell. Thus, it should also not be influenced by cell aesthetics.
(In reply to lorenz from comment #11) > (In reply to Ademas from comment #9) > > I myself, would be happy with an extra experimental(?) option to tweak the > > placing. I would use -2px in both dimensions always and live happily ever > > after. > > I guess this is not something that should necessarily merit an additional > option, especially considering that the comment should be something that is > 'attached to' rather than 'part of' a single cell. Thus, it should also not > be influenced by cell aesthetics. I don't follow the logic. You are right, the indicator is **literally** attached to the corner of a cell, in a visual way, that is even more reason to follow the aesthetics of that particular cell. But what would be the solution, then? Or you think there is no problem?
> But what would be the solution, then? Or you think there is no problem? I would argue that this is not a problem. While yes, I agree that the aesthetics are really not pretty, whether or not this is an actual problem in my opinion comes down to what a comment is and how it is used. A comment is usually a temporary, additional piece of information for a single cell. If it were permanent, it should be a visible part of the file (i.e. written in its own cell). But because it is still important information, the comment indicator has to be salient, thus the necessity for a border. And all that the horrible aesthetics do at the end of the day is make the indicator even more salient by breaking the grid-pattern. But that is just my opinion :)
I cannot follow the "horrible aesthetics" assessment. Please share a drawing of how you imagine the placement with and without gridlines being visible.
Created attachment 196175 [details] Drawing of comment indicator placement
So, I drew 4 options. I used different colors to show the problem of the indicator border having the same color of the grid, which is not a rule. I also use a solid background to accentuate it. This becomes move obvious as you turn the indicator bigger by tweaking the NoteIndicator experimental option. A is how it is today, with borders. The overlapping of colors in the border is not ideal, but I think it could be acceptable. B is how it is today, without borders. B is the enemy! B causes horrible aesthetics, by seemingly overlapping outside the cell. C is an option that can be displeasing to some by having double borders, when the cell has borders, but would be ideal if the cell has no borders. D is my preferred option, by moving the indicator -2px, borders don't overlap and there is no border problem. But it takes more space inside the cell, making the contents less visible
(In reply to Heiko Tietze from comment #3) > How about changing the grid line color to white? Have you considered this? Sorry if I missed a reply.
(In reply to Heiko Tietze from comment #17) > (In reply to Heiko Tietze from comment #3) > > How about changing the grid line color to white? > Have you considered this? Sorry if I missed a reply. I have, but I don't see how that can help when you use solid background?
Ignoring option D, which no one will probably accept, I think the best solution is: -When there are borders, it should look like A, except that maybe the indicator border should follow the cell border color, or be further customizable. -When there are no borders, it should look like C without the outer black borders. (sorry, should have drawn it) What I mean is no overlap with border or other cells, the indicator stays in the inner cell.
Created attachment 196190 [details] Screenshot Bit of a hijack (or additional). There is also the case where the cell with comment being selected.. The comment indicator is barely visible.
We discussed the topic in the design meeting. In a few rare situations the border line might be not perfect. We pondered over alternatives like make it depending on the background (leads to a busy design), introduce an option (bloats the registry and becomes quickly unmaintainable), go back with all changes (fly-speck dot had a white border in the past), use an icon instead to draw a rectangle (not a solution), etc. Since we have no idea how to make all users happy, and so far not too many complained, we decided to close the ticket as WF.