Bug 162686 - ODF 1.4: loext:extrusion-metal-type -> draw:extrusion-metal-type
Summary: ODF 1.4: loext:extrusion-metal-type -> draw:extrusion-metal-type
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: ODF-1.4-Support
  Show dependency tree / graph
 
Reported: 2024-08-29 12:22 UTC by Xisco Faulí
Modified: 2024-11-13 23:23 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2024-08-29 12:22:31 UTC 
Link: https://issues.oasis-open.org/browse/OFFICE-4123
Commit: https://git.libreoffice.org/core/+/157b027c4cfca2582b1c1bdb66992560084ac008%5E%21

Adapt code in https://opengrok.libreoffice.org/xref/core/xmloff/source/draw/shapeexport.cxx?r=b904816f#4614 and remove loext:extrusion-metal-type from schema.

Test: testExtrusionSpecularityExtended
Comment 1 Commit Notification 2024-09-24 12:51:21 UTC 
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/34c4a18d78b0b8a2eb2bc4376190d894b8c3d6f4

tdf#162686: Adapt to ODF 1.4

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Regina Henschel 2024-11-06 12:23:12 UTC 
The export logic is wrong. The attribute value always reflects the value of eMetalType. Only in ODF 1.4 the attribute itself has namespace 'draw', whereas in ODF extended in versions before ODF 1.4 it has namespace 'loext' and in ODF strict in versions before ODF 1.4 it must not be written at all.

The unit tests need to be extended to cover not only existence and namespace but also attribute value.