Bug 162840 - Hyphenation Sidebar deck only looks good in gtk3 UI
Summary: Hyphenation Sidebar deck only looks good in gtk3 UI
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: László Németh
URL:
Whiteboard: target:25.8.0 target:25.2.2
Keywords:
Depends on:
Blocks: Sidebar-Properties Sidebar-Properties-Paragraph
  Show dependency treegraph
 
Reported: 2024-09-07 16:27 UTC by Buovjaga
Modified: 2025-03-29 13:04 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot from Windows (2.80 KB, image/png)
2024-09-07 16:27 UTC, Buovjaga
Details
hyphenation_panel.png: screenshot of the proposed panel (69.63 KB, image/png)
2025-03-03 13:53 UTC, László Németh
Details
screen clips of sequence opening the new Hyphenation widgets on SB Properties deck (532.75 KB, image/png)
2025-03-07 12:20 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Buovjaga 2024-09-07 16:27:52 UTC
Created attachment 196301 [details]
Screenshot from Windows

Use Windows, gen or kf5/kf6.

1. Open Writer, Sidebar Properties
2. Click the button to activate Hyphenation controls

Cramped & glitched look, see screenshot.
Comment 1 raal 2024-09-08 12:04:39 UTC
Confirm with Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 10363c80eb3fd0637d91714fe977de77b43d3aa3
CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: x11
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 2 V Stuart Foote 2024-09-08 12:58:22 UTC
likewise on Win10
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1b61a0737e3600aadf42f28a15c70aface9ab61e
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 3 V Stuart Foote 2024-09-08 13:05:15 UTC
Note that if (on Windows at least) in the SB Properties deck you collapse the Paragraph content panel and reexpand it the spacing is recalculated, spacing then looking correct.

But collapse/expand has to be repeated with each launch of the SB
Comment 4 László Németh 2025-02-27 17:23:14 UTC
Proposed fix: https://gerrit.libreoffice.org/c/core/+/182321
Comment 5 László Németh 2025-03-03 13:53:45 UTC
Created attachment 199578 [details]
hyphenation_panel.png: screenshot of the proposed panel

See https://gerrit.libreoffice.org/c/core/+/182321
Comment 6 László Németh 2025-03-04 13:55:05 UTC
Proposed fix for 25.2: https://gerrit.libreoffice.org/c/core/+/182485
Comment 7 Commit Notification 2025-03-05 09:04:22 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fe502cd93b70c598fcf9196f7ec1d9169bfe522f

tdf#162840 sfx: fix layout of sidebar hyphenation options

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Buovjaga 2025-03-05 09:29:42 UTC
Still cramped, the commit doesn't fix it

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 38a4d3f0b095f70deaf1c25617b5f8b378f31626
CPU threads: 8; OS: Linux 6.13; UI render: default; VCL: x11
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 9 Commit Notification 2025-03-06 02:03:14 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/e0c89d0ba3edbe975ce62427cd217f346293b23e

tdf#162840 sfx: fix layout of sidebar hyphenation options

It will be available in 25.2.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Buovjaga 2025-03-06 06:09:56 UTC
(In reply to László Németh from comment #5)
> Created attachment 199578 [details]
> hyphenation_panel.png: screenshot of the proposed panel
> 
> See https://gerrit.libreoffice.org/c/core/+/182321

I see you are still only testing with gtk3. Please, as the topic implies, test also by running with SAL_USE_VCLPLUGIN=gen or SAL_USE_VCLPLUGIN=kf5 or kf6
Comment 11 Piotr Osada 2025-03-07 11:00:51 UTC
UI overlaying (same as in @Buovjaga's attachment 196301 [details]) is still present in:

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 894563ee0e4032019623a97c313af3d833863b1f
CPU threads: 16; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Vulkan; VCL: win
Locale: pl-PL (pl_PL); UI: en-US
Calc: CL threaded

/daily/master/Win-x86_64@tb77-TDF/2025-03-07_02.42.20/
Comment 12 V Stuart Foote 2025-03-07 12:20:33 UTC
Created attachment 199683 [details]
screen clips of sequence opening the new Hyphenation widgets on SB Properties deck

clips of the unresolved appearance issue when opening the new Hyphenation widget button on the Writer Sidebar -> Properties deck.

Issue seems to be that the height of the widgets are not being added to the Paragraph content panel when added, so the entire content panel appears compressed into its existing space.

Closing and reopening the SB deck with the Hyphenation widgets opened then recalculates the height of the Paragraph content panel.

=-testing-=
  
2025-03-07 TB77 nightly of master 
Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 894563ee0e4032019623a97c313af3d833863b1f
CPU threads: 28; OS: Windows 11 X86_64 (build 22631); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 13 V Stuart Foote 2025-03-07 12:30:56 UTC
(In reply to László Németh from comment #5)
> Created attachment 199578 [details]
> hyphenation_panel.png: screenshot of the proposed panel
> 

This clip shows the Hyphenation widgets are in their own panel. But the clips in attachment 199683 [details] from the 2025-03-07 nightly on Windows vcl seem to show the widgets *not in a new content panel, but instead being added* into the Paragraph content panel above.

Is that maybe more the issue? With the SB deck framework...
Comment 14 Petr Valach 2025-03-26 14:21:42 UTC

*** This bug has been marked as a duplicate of bug 164823 ***
Comment 15 Buovjaga 2025-03-26 14:36:32 UTC
(In reply to Petr Valach from comment #14)
> 
> *** This bug has been marked as a duplicate of bug 164823 ***

Duplicate is the wrong status, this already had commits. If you assume work towards bug 164823 will solve the remaining issues, then let's close this as fixed.
Comment 16 Petr Valach 2025-03-26 14:41:11 UTC
OK, thank you. I have reopened it and let it be for now.
Comment 17 V Stuart Foote 2025-03-26 15:35:58 UTC
Same issues with the Sidebar (SB) Content Panel as in OP, and on on WDM with Win11 as shown in attachment 199683 [details] from comment 12 and comment 13

The Hyphenation widgets are correctly appended in the SB 'Properties' deck to the titled 'Paragraph' "Content panel" (CP) [1], but the CP is NOT being fully recalculated to account for its expanded size.

And as noted in related bug 164823, once exposed (even if close open of SB) the Hyphenation widgets can not be collapsed as no control is provided to do so.

=-testing-=

Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a2741c9e6083016bba82fa9be06e157a18aaaf07
CPU threads: 28; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

[1] https://wiki.documentfoundation.org/File:LO-HIG_SideeBar-Terminology.png
Comment 18 V Stuart Foote 2025-03-26 15:48:32 UTC
Maybe the best way to correct this would be to move the new Hyphenation widgets out of the Properties -> Paragraph CP, and put them into a CP of their own?

Would not be that questionable to be its own content panel in the Properties deck. Already have Styles, and Character panels in addition to Paragraph.  

Putting Hyphenation into its own content panel would allow it to expose/collapse as needed without affecting the rest of the Paragraph panel.

@László, Jim--opinions?
Comment 19 V Stuart Foote 2025-03-26 16:06:46 UTC
(In reply to V Stuart Foote from comment #18)
> Maybe the best way to correct this would be to move the new Hyphenation
> widgets out of the Properties -> Paragraph CP, and put them into a CP of
> their own?
> 
> Would not be that questionable to be its own content panel in the Properties
> deck. Already have Styles, and Character panels in addition to Paragraph.  
> 
> Putting Hyphenation into its own content panel would allow it to
> expose/collapse as needed without affecting the rest of the Paragraph panel.
> 
> @László, Jim--opinions?

And seems exactly what https://gerrit.libreoffice.org/c/core/+/182321 would do, it needs to be rebased and pushed, likely with backport patch to 25.2 as the 25.2.2 release build remain affected.
Comment 20 V Stuart Foote 2025-03-29 13:04:05 UTC
(In reply to V Stuart Foote from comment #19)

Meanwhile, Jim R. has put up https://gerrit.libreoffice.org/c/core/+/183451 which cleans up the Properties deck in general and corrects the behavior of the Hyphenation widgets as appended to the Paragraph content panel.

Which is a better approach?

My two-cents would be for Hyphenation into a Content panel of its own (so it can be better suppressed), either way the current Paragraph content panel needs a cleanup.