Bug 162491 - add sidebar support for hyphenation
Summary: add sidebar support for hyphenation
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: Hyphenation
  Show dependency treegraph
 
Reported: 2024-08-16 10:29 UTC by László Németh
Modified: 2024-09-07 16:27 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
draft alternative fix with icon size support (61.12 KB, patch)
2024-08-16 10:39 UTC, László Németh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description László Németh 2024-08-16 10:29:26 UTC
Description:
Hyphenation is the basic tool of typesetting, and automatic hyphenation offers a lot of settings to fix the imperfections of the automatic hyphenation. These settings need sidebar support to adjust the text quickly, like DTP software do.

Note: there is no perfect automatic hyphenation, that is why soft-hyphen based semi-automatic hyphenation was (and is still) preferred by Writer (see Tools->Language->Hyphenation...). This is not the best approach for most of the languages, likely it was good only for German and similar languages, where there were no good hyphenation dictionaries. Now it's possible to hyphenate German text with automatic hyphenation, using the features, which are not available for the soft-hyphen based hyphenation (e.g. max. consecutive hyphenated lines, hyphenation across, setting bigger word break distance from compound constituent boundaries). 

Steps to Reproduce:
See paragraph (and for character) sidebar panels.

Actual Results:
No toggle button for automatic hyphenation. No icon for soft-hyphen based hyphenation dialog.

Expected Results:
Toggle buttons and other controls for automatic hyphenation, and its settings. Icon for soft-hyphen based hyphenation dialog. Add icon to disable automatic hyphenation for hyphenated words.


Reproducible: Always


User Profile Reset: No

Additional Info:
New hyphenation features of version 24.8:

https://wiki.documentfoundation.org/ReleaseNotes/24.8#Hyphenation
Comment 1 Commit Notification 2024-08-16 10:36:15 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/98f7f540463c533da17d4e8595c091d9e98a6c83

tdf#162491 tdf#125032 add hyphenation settings to sidebar

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 László Németh 2024-08-16 10:39:10 UTC
Created attachment 195868 [details]
draft alternative fix with icon size support

Note: in svx/sdi/svx.sdi, replace Toggle = FALSE to TRUE to get working toggle buttons.
Comment 3 László Németh 2024-08-21 10:20:05 UTC
Clean-up by Caolán McNamara:

invalid cast from 'GtkToggleToolButton' to 'GtkToggleButton'
https://gerrit.libreoffice.org/c/core/+/172047

GtkBox does not have a child property called left-attach
https://gerrit.libreoffice.org/c/core/+/172048

fix indent
https://gerrit.libreoffice.org/c/core/+/172049