Bug 162890 - A11Y sidebar: warning does not disappear when page header content is deleted
Summary: A11Y sidebar: warning does not disappear when page header content is deleted
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Balázs Varga (allotropia)
URL:
Whiteboard: target:25.2.0 target:24.8.2
Keywords:
: 162996 (view as bug list)
Depends on:
Blocks: Accessibility-Check
  Show dependency treegraph
 
Reported: 2024-09-09 17:20 UTC by Gabor Kelemen (allotropia)
Modified: 2024-12-03 17:15 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer (34.79 KB, application/vnd.oasis.opendocument.text)
2024-09-09 17:20 UTC, Gabor Kelemen (allotropia)
Details
Warnings when opening the file, these lead to nowhere (130.34 KB, image/png)
2024-09-09 17:21 UTC, Gabor Kelemen (allotropia)
Details
Formatting in the Left page styles header, causing the warning (103.00 KB, image/png)
2024-09-09 17:22 UTC, Gabor Kelemen (allotropia)
Details
Deleting the header for good (138.24 KB, image/png)
2024-09-09 17:22 UTC, Gabor Kelemen (allotropia)
Details
After deleting the header, the sidebar is not updated (132.33 KB, image/png)
2024-09-09 17:23 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-09-09 17:20:57 UTC
Created attachment 196334 [details]
Example file from Writer

This is similar - maybe the same - as bug 162889

When there is a bit of direct character formatting used in the header, a respective "The text formatting conveys additional meaning" warning is displayed in the Accessibility sidebar. 
This is displayed even if the respective page style is not used, which is confusing.
This warning is also kept displayed if the affect text is deleted, but if only the formatting is removed, then it is removed from the sidebar.

1. Open attached file
2. Open the Accessibility sidebar
-> There are two warnings "The text formatting conveys additional meaning" but clicking on them does not highlight the affected text part.

3. Open the Styles sidebar, go to the Page Styles category and change the page style from Default Page Style to Left Page.
4. Click inside the header and remove the bold formatting from "Hello World" with the Bold button of the toolbar (Remove all formatting works, don't use that for this bug!)
5. Go back to the Accessibility sidebar
-> only one warning is visible, this is good
6. Undo, then go back to the Styles sidebar
7. Delete "Hello World" from the header
8. Go back to the Accessibility sidebar
-> Still two warnings

Do the same with the Landscape page style, and remove the direct formatting from the "Hello page number: 1" in the header
-> Accessibility sidebar shows one less warning
- or undo and delete the whole header with the blue pop-up menu (similarly to the steps of bug 162889)
-> Accessibility sidebar will still show the warning.

So similarly to how bug 162889 should be handled, the Accessibility sidebar should not complain about issues in invisible page styles headers, since that is not very useful.
Also the sidebar should be updated when the content of the header is deleted - it is updated when new formatting is added.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 10363c80eb3fd0637d91714fe977de77b43d3aa3
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Gabor Kelemen (allotropia) 2024-09-09 17:21:37 UTC
Created attachment 196335 [details]
Warnings when opening the file, these lead to nowhere
Comment 2 Gabor Kelemen (allotropia) 2024-09-09 17:22:23 UTC
Created attachment 196336 [details]
Formatting in the Left page styles header, causing the warning
Comment 3 Gabor Kelemen (allotropia) 2024-09-09 17:22:58 UTC
Created attachment 196337 [details]
Deleting the header for good
Comment 4 Gabor Kelemen (allotropia) 2024-09-09 17:23:31 UTC
Created attachment 196338 [details]
After deleting the header, the sidebar is not updated
Comment 5 Commit Notification 2024-09-17 01:48:17 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7b8ae2bf7cf9d4d637b40030bb9f482f6fba5194

tdf#162890 - A11Y sidebar: fix unecceserry warning in case if we have

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-09-18 10:34:01 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/b967f9c92e33dc2b77cb4fee13a35052ad404732

tdf#162890 - A11Y sidebar: fix unecceserry warning in case if we have

It will be available in 24.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Buovjaga 2024-12-03 17:15:08 UTC
*** Bug 162996 has been marked as a duplicate of this bug. ***