Bug 162938 - Import of Excel spreadsheet with conditional formatting is not presenting the same in Calc
Summary: Import of Excel spreadsheet with conditional formatting is not presenting the...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.8.0.3 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Xisco Faulí
URL:
Whiteboard: target:25.2.0 target:24.8.2
Keywords: bibisected, bisected, filter:xlsx, regression
: 162942 162985 163162 (view as bug list)
Depends on:
Blocks: XLSX-Conditional-Formatting
  Show dependency treegraph
 
Reported: 2024-09-13 00:28 UTC by Michael
Modified: 2024-09-26 14:07 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments
Excel document revealing import issue (8.65 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2024-09-13 00:29 UTC, Michael
Details
Screenshots of Excel and LibreOffice (217.17 KB, image/png)
2024-09-13 00:31 UTC, Michael
Details
Before vs After the revert (45.19 KB, image/png)
2024-09-13 12:16 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael 2024-09-13 00:28:37 UTC
Description:
When we import a spreadsheet from Excel that contains conditional formatting with icon sets, it's not showing the arrows in Calc.

This only started happening with (release version) 24.8.0.3. Unfortunately, I didn't keep track of the exact previous version where it was working, but we update very regularly from the general release versions, and noticed it as soon as 24.8.0 came out.

We've found the issue on both Mac (Sonoma on intel) and Ubuntu (22.04 on x86_64).

I'll attach an example spreadsheet and screenshots.

Steps to Reproduce:
1. Create and Excel spreadsheet using conditional formatting with icon sets, where red is < 0, yellow is = 0 and green is > 0
2. Open the Excel spreadsheet in Calc
3. The arrows are not being displayed consistently with the rule set up in Excel

Actual Results:
Green up-arrow shown where value in cell = 0
Red down-arrow shown where value in cell is minimum in the set

Expected Results:
Green up-arrow when value in cell > 0
Yellow side-arrow when value in cell = 0
Red down-arrow when value in cell < 0


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Displayed the results consistent with the Excel presentation
Comment 1 Michael 2024-09-13 00:29:39 UTC
Created attachment 196417 [details]
Excel document revealing import issue
Comment 2 Michael 2024-09-13 00:31:32 UTC
Created attachment 196418 [details]
Screenshots of Excel and LibreOffice

On the left is the display in Excel and on the right is LibreOffice Calc
Comment 3 Buovjaga 2024-09-13 04:31:52 UTC
We never showed those yellow arrows (checked with several versions down to 5.2), but the current state began with fcc5770dd1e33dcb4f4f0c28683569af5d1d8368
tdf#61313 Replace the static ">=" with a dropdown of different operators
Comment 4 Xisco Faulí 2024-09-13 06:17:10 UTC
(In reply to Buovjaga from comment #3)
> We never showed those yellow arrows (checked with several versions down to
> 5.2), but the current state began with
> fcc5770dd1e33dcb4f4f0c28683569af5d1d8368
> tdf#61313 Replace the static ">=" with a dropdown of different operators

oh man, even the unittests touched in sc/qa/unit/subsequent_filters_test4.cxx has the same problem... Solution: Add a new method convertToOldCondFormat so the unittest pass.
Reverting it right now...
Comment 5 Xisco Faulí 2024-09-13 06:32:07 UTC
Patch in https://gerrit.libreoffice.org/c/core/+/173310
Comment 6 Xisco Faulí 2024-09-13 08:54:36 UTC
*** Bug 162942 has been marked as a duplicate of this bug. ***
Comment 7 Commit Notification 2024-09-13 09:23:56 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/27be65a7d5326608f75839e3964ac322e88224a1

tdf#162938: Revert "tdf#61313 Replace the static ">="...

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 ady 2024-09-13 10:56:44 UTC
(In reply to Buovjaga from comment #3)
> We never showed those yellow arrows (checked with several versions down to
> 5.2), but the current state began with
> fcc5770dd1e33dcb4f4f0c28683569af5d1d8368
> tdf#61313 Replace the static ">=" with a dropdown of different operators

If the problem would exist anyway, what's the point of reverting anything?

The arrows would not be shown after reverting anyway.

How will reverting tdf#61313 solve the real issue?
Comment 9 ady 2024-09-13 11:30:37 UTC
Reverting tdf#61313 _might_ solve tdf#162942 (to be tested), but it will not solve the problem for attachment 196417 [details] nor for attachment 196414 [details].
Comment 10 Buovjaga 2024-09-13 12:09:47 UTC
(In reply to ady from comment #8)
> (In reply to Buovjaga from comment #3)
> > We never showed those yellow arrows (checked with several versions down to
> > 5.2), but the current state began with
> > fcc5770dd1e33dcb4f4f0c28683569af5d1d8368
> > tdf#61313 Replace the static ">=" with a dropdown of different operators
> 
> If the problem would exist anyway, what's the point of reverting anything?
> 
> The arrows would not be shown after reverting anyway.
> 
> How will reverting tdf#61313 solve the real issue?

Well, it's true that this report is mixing two issues and the commit could have pointed to bug 162942 instead.
Comment 11 Xisco Faulí 2024-09-13 12:16:40 UTC
Created attachment 196425 [details]
Before vs After the revert
Comment 12 Xisco Faulí 2024-09-13 12:17:18 UTC
I'll create a follow-up ticket for the yellow arrow
Comment 13 Xisco Faulí 2024-09-13 12:32:28 UTC
(In reply to Xisco Faulí from comment #12)
> I'll create a follow-up ticket for the yellow arrow

-> tdf#162948
Comment 14 Commit Notification 2024-09-14 06:04:35 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/2e6d189821f5def411647b6f3e21d0617ab299b6

tdf#162938: Revert "tdf#61313 Replace the static ">="...

It will be available in 24.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 15 Xisco Faulí 2024-09-16 09:03:21 UTC
*** Bug 162985 has been marked as a duplicate of this bug. ***
Comment 16 trendafilka 2024-09-21 07:27:41 UTC
I tried out this build and this bug looks fixed to me: /daily/libreoffice-24-8/Linux-rpm_deb-x86_64@tb99-TDF/2024-09-21_05.29.03/

Thanks!
Comment 17 ady 2024-09-26 14:07:47 UTC
*** Bug 163162 has been marked as a duplicate of this bug. ***