Bug 162999 - New Comment Sidebar too wide; unable to resize the sidebar
Summary: New Comment Sidebar too wide; unable to resize the sidebar
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
: 163041 (view as bug list)
Depends on:
Blocks: Sidebar-Comment
  Show dependency treegraph
 
Reported: 2024-09-16 22:54 UTC by Rafael Lima
Modified: 2024-10-12 10:53 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Backtrace of crash in kf6 (11.27 KB, text/x-log)
2024-09-23 00:34 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2024-09-16 22:54:19 UTC
Recently the Comments Sidebar was merged. However, it has a few issues to be resolved.

First, when I open the sidebar, it gets too wide, using half of the width of my screen. And I am unable to resize it.

Steps to reproduce
1) On current 25.2 master, enable Experimental Features
2) Open attachment 196416 [details] (from bug 162937), which is a document with various comments
3) Open the Comments sidebar
4) The sidebar will use half of the screen

Expected results
The width should not change; and the sidebar should be resizable

System info

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 4617155ce4037ca2ba35c6688a7ee23a30197846
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 m_a_riosv 2024-09-17 01:53:20 UTC

*** This bug has been marked as a duplicate of bug 162937 ***
Comment 2 Rafael Lima 2024-09-17 02:26:33 UTC
Although both bugs mention the "comment sidebar", each refer to 2 different things. 

This bug is about the new comment sidebar added by the recently merged GSoC project, whereas bug 162937 is about resizing the existing area with comments.

Changing this back to Unconfirmed.
Comment 3 m_a_riosv 2024-09-17 06:59:15 UTC
Sorry @Rafael, there are no new masters since 2024-09-16, to test.
Comment 4 m_a_riosv 2024-09-17 07:19:52 UTC
Reproducible
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 636f853bda69a889146968116b276d88f105b47f
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 5 m_a_riosv 2024-09-17 07:42:56 UTC
Seems in sidebar the text is not wrapped to the desired width, as in the comment box. So the width is adjusted to the text width.
Comment 6 Rafael Lima 2024-09-17 13:16:09 UTC
@Mohit, can you please take a look at this?

I applied all subsequent patches that are waiting to be merged. With this, when I open the file only the first comment appears in the sidebar (in kf5) but in gtk3 all comments appear.

And the sidebar still cannot be resized to a smaller width.
Comment 7 Mohit Marathe 2024-09-17 13:38:16 UTC
(In reply to Rafael Lima from comment #6)
> @Mohit, can you please take a look at this?
> 
> I applied all subsequent patches that are waiting to be merged. With this,
> when I open the file only the first comment appears in the sidebar (in kf5)
> but in gtk3 all comments appear.
> 
> And the sidebar still cannot be resized to a smaller width.

So I tried this on Windows as well and I can reproduce both the issues:
I) Resizing sidebar
II) Only one comment/thread appears (in windows, its the last comment by position)

Seems like it only works properly for gtk3.

I will look into this.
Comment 8 Rafael Lima 2024-09-19 11:47:48 UTC
*** Bug 163041 has been marked as a duplicate of this bug. ***
Comment 9 Rafael Lima 2024-09-23 00:34:22 UTC
Created attachment 196622 [details]
Backtrace of crash in kf6

On kf6 I'm getting a crash. See attached backlog.

I'm on Fedora 40 KDE with Plasma 6.1.5.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f324b7745f87d56ee367131aa52756530ec436bc
CPU threads: 12; OS: Linux 6.10; UI render: default; VCL: kf6 (cairo+wayland)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL threaded
Comment 10 Commit Notification 2024-09-23 08:08:22 UTC
Mohit Marathe committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fc5983f470e5b0e54a75da3285a2c2ec64f7af79

tdf#162999 Fix comments sidebar resizing issue

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Buovjaga 2024-10-12 10:53:17 UTC
(In reply to Mohit Marathe from comment #7)
> Seems like it only works properly for gtk3.

In addition, with kf6 UI the comment is not visible at all. It is somehow squished.