Bug 162937 - Issues with resizing the Comment Sidebar in Writer
Summary: Issues with resizing the Comment Sidebar in Writer
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0 target:24.8.2
Keywords:
: 162792 (view as bug list)
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2024-09-13 00:25 UTC by Rafael Lima
Modified: 2024-11-15 15:40 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
DOCX file where the problem happens (199.57 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-09-13 00:25 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Lima 2024-09-13 00:25:32 UTC
Created attachment 196416 [details]
DOCX file where the problem happens

When I open the attached DOCX file, I am unable to resize the comment sidebar from the sidebar's right edge.

And if I user the ruler to resize the sidebar, it does not respond correctly.

Steps to reproduce
1) Open the attached DOCX file in LO 24.8; this file has lots of comments
2) Move the mouse to the right edge of the comment sidebar; note that the mouse pointer won't change and resizing won't be possible
3) Move the mouse to the right edge of the Comment ruler (beside the document ruler); the mouse pointer will change as expected, but resizing won't work correctly
4) Move the mouse to the left edge of the document; note that the "hit area" of the resize handle is there; for some reason it is going to the wrong position

If I create a blank file in Writer, resizing works fine... and if I open a file without comments and then try to add comments, all work as expected. The problem happens when I open files that already have comments.

System info

Version: 24.8.2.0.0+ (X86_64) / LibreOffice Community
Build ID: b3b330e544df8fb802403fe133e8f8095966ac12
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb)
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 V Stuart Foote 2024-09-13 01:18:04 UTC
Confirmed.

Interestingly if I have a second Writer document with comments open, a change to comment width there bleeds over to the writer session with the OOXML open, resetting comment width there. It holds during editing, but any attempt to further adjust its width pops it open to maximum width.

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 976567aee323afd09629b6adf13537908f43d2a8
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 2 Jim Raykowski 2024-09-14 22:41:33 UTC
(In reply to Rafael Lima from comment #0)
> 2) Move the mouse to the right edge of the comment sidebar; note that the
> mouse pointer won't change and resizing won't be possible
For me the pointer changes to the resizing pointer only when the page has at least one comment.

> 3) Move the mouse to the right edge of the Comment ruler (beside the
> document ruler); the mouse pointer will change as expected, but resizing
> won't work correctly
I repro.

> 4) Move the mouse to the left edge of the document; note that the "hit area"
> of the resize handle is there; for some reason it is going to the wrong
> position
Please see comment made at https://gerrit.libreoffice.org/c/core/+/173017/4/sw/source/uibase/docvw/edtwin.cxx
Comment 3 Rafael Lima 2024-09-15 19:24:48 UTC
I think I figured out what's happening.

The problem occurs whenever the first comment is not on the first page. In that case, the pages before the first comment do not have the cursor change. The cursor changes after the first page with comments, but then resizing is broken.
Comment 4 Commit Notification 2024-09-16 22:15:49 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/636f853bda69a889146968116b276d88f105b47f

tdf#162937 Set default comment position to the right

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 bunkem 2024-09-17 00:24:31 UTC
Thank you Rafael Lima!
Comment 6 m_a_riosv 2024-09-17 01:53:20 UTC
*** Bug 162999 has been marked as a duplicate of this bug. ***
Comment 7 Commit Notification 2024-09-17 14:16:44 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/64171fa351e7ec2b5d4beeeb3aa4ac649c623f19

tdf#162937 Set default comment position to the right

It will be available in 24.8.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 bunkem 2024-09-18 19:39:35 UTC
Have been testing the following version that is supposed to be fixed.
Version: 24.8.2.0.0+ (X86_64) / LibreOffice Community
Build ID: 10f5e3d255c094bb34155f6354b93e93289e43a0
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: en-CA (en_CA); UI: en-US
Calc: CL threaded

Unfortunately it isn't fixed for docx Office 365 files.  The resizing of the comment box doesn't work in that version.

Following is repeatable.
1) Open Writer document
2) Highlight some text and add comment
3) Select comment to try to shrink or increase size
4) Comment will spread out to maximum size
5) Despite there being a cursor "|" to drag and resize, the resize box doesn't work.
Comment 9 BogdanB 2024-09-19 05:05:19 UTC
> 
> Unfortunately it isn't fixed for docx Office 365 files.  The resizing of the
> comment box doesn't work in that version.

If I understand correctly it's not about resizing comment box area, but comments sidebar, a new feature from Experimental mode. (Tools - Settings - Advanced). Be sure to check that.
Comment 10 Jim Raykowski 2024-09-19 07:20:45 UTC
@bunkem - Rafael is working on a patch filed under bug 162855 that appears from my testing will fix the bug you have described in comment 8 and reported in bug 162792.

@BogdanB - This is about the comment sidebar in the document view and not the new experimental sidebar comment deck.

I'm setting this ticket to verified fixed, tested with:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d500848976b6244048684a9972322b582559910a
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22631); UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 11 Buovjaga 2024-11-15 15:40:39 UTC
*** Bug 162792 has been marked as a duplicate of this bug. ***