Bug 163010 - FILESAVE XLSX A certain spreadsheet is slow to save
Summary: FILESAVE XLSX A certain spreadsheet is slow to save
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
24.2.0.0 alpha0+
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords: bibisected, bisected, filter:xlsx, regression
Depends on:
Blocks:
 
Reported: 2024-09-17 13:47 UTC by vjmartins
Modified: 2024-12-04 15:32 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
File example (205.83 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2024-09-17 13:47 UTC, vjmartins
Details
File unprotected (204.77 KB, application/vnd.ms-excel)
2024-12-04 10:19 UTC, vjmartins
Details

Note You need to log in before you can comment on or make changes to this bug.
Description vjmartins 2024-09-17 13:47:43 UTC
Created attachment 196507 [details]
File example

Hi,
When i try to save the file in attach, LO blocks.

Only works in version 7.6.3.2.
Comment 1 Buovjaga 2024-12-03 17:35:26 UTC
Bibisected with linux-64-24.2 to 8b2369236dea7d6863c2df3d4ce5e356c9c8010c
sc: fix back color filter entries

Same one as bug 163667, but that one is fixed and at least for me the saving of the test file there is quite fast.

Noel: maybe you are interested in this one.

I guess it's conditional formatting, but the sheet is protected by a password, so I could not check.
Comment 2 vjmartins 2024-12-04 10:19:13 UTC
Created attachment 197930 [details]
File unprotected
Comment 3 Buovjaga 2024-12-04 10:29:42 UTC
(In reply to vjmartins from comment #2)
> Created attachment 197930 [details]
> File unprotected

Thanks. I'm not seeing anything in Format - Conditional - Manage.
Comment 4 Commit Notification 2024-12-04 11:16:34 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f70663c322209626bec08e3b63be6f0de663911

tdf#163010 include GetPattern here

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-12-04 11:16:37 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3fa6edf0b8625185fc19a76fc1e6268d99275cb0

tdf#163010 walk pattern by range

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-12-04 11:16:39 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2c613da01d02d45a140b94b391a142aede46e8b8

tdf#163010 inline and cache rDoc.GetCondFormat call

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Buovjaga 2024-12-04 15:32:40 UTC
I verify that it now takes only 30 secs. vjmartins: note that commit 8b2369236dea7d6863c2df3d4ce5e356c9c8010c that caused this was actually fixing a real problem. So now LibreOffice works correctly and it takes more time because of this.

Arch Linux 64-bit
Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d775d637b9ff7619aba195559deed6e9a341e372
CPU threads: 8; OS: Linux 6.12; UI render: default; VCL: kf6 (cairo+wayland)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: CL threaded
Built on 4 December 2024