Bug 163114 - Comments ignore spacing above first paragraph and below last paragraph
Summary: Comments ignore spacing above first paragraph and below last paragraph
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Comments
  Show dependency treegraph
 
Reported: 2024-09-24 05:16 UTC by Heiko Tietze
Modified: 2025-01-24 06:47 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (33.08 KB, image/png)
2024-09-24 05:16 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2024-09-24 05:16:20 UTC
Created attachment 196641 [details]
Screenshot

Whether using the Comment style or direct formatting, the spacing above/below is ignored.
Comment 1 Dieter 2024-10-09 06:38:41 UTC
I confirm behaviour you can see in the screenshot, but to be correct problem is only related to first (spacing above) and last paragraph (spacing below) of a comment. And if you have a lot of comments, free space above first paragrph and below last paragraph might be annoying. So I won't support a change of current behaviour, alsthoug it might be see as an inconsistent behaviour.
So I would say WONTFIX
Comment 2 Buovjaga 2025-01-07 14:15:59 UTC
See Also has Calc bugs, but is the code really shared with Writer comments?
Comment 3 Eyal Rozenberg 2025-01-22 21:15:18 UTC
I would say this is a plain and simple bug. Probably due to how we didn't use to have paragraph styles for comments. I'd mark this as NEW.


A question, though: Won't this all go away when comments start to be rendered in the sidebar, or something-like-the-sidebar? I seem to remember that being the plan.

-----------

(In reply to Dieter from comment #1)
> if you have a lot of comments, free space above first
> paragrph and below last paragraph might be annoying.

If this annoying to a user, then they would change the style so as not to have this spacing above or below; and if they do want this spacing, they should be able to have it. So, I disagree with a WONTFIX. Unless you have an argument in principle against this spacing?

I will say, though, that given your preference, you might be interested in bug 164199; if that were resolved, it would be easy to control intra-paragraph spacing while keeping the spacing before the first and after the last to 0 (or to an arbitrary different amount).
Comment 4 Heiko Tietze 2025-01-24 06:47:30 UTC
We discussed the topic in the design meeting. Some expect spacing to work on the first/last paragraph others not. The issue is a consequence of using styles for comments, implemented for bug 103064, which is a bit uncommon. Maxim, what is your take?