Bug 163289 - Broken accelerators for Width and Height in "Position & Size" dialog (gtk3)
Summary: Broken accelerators for Width and Height in "Position & Size" dialog (gtk3)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:24.8.4
Keywords: bibisected, bisected, regression
: 164010 (view as bug list)
Depends on:
Blocks: GTK3
  Show dependency treegraph
 
Reported: 2024-10-04 09:00 UTC by libue
Modified: 2024-11-25 11:32 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description libue 2024-10-04 09:00:20 UTC
Description:
The "Position & Size" dialog (opened by pressing F4) has lost quick keyboard nav by access keys (terminology?)

Steps to Reproduce:
1. Select drawing object
2. Press F4
3. Press and hold Alt
4. Draw reveals available access keys (showing underline)
5. Attempt to use any access key

Actual Results:
Nothing happens

Expected Results:
Cursor should move to entry field or button corresponding to the used access key


Reproducible: Always


User Profile Reset: No

Additional Info:
Flatpak
Comment 1 libue 2024-10-04 09:02:55 UTC
Using Alt-O to set focus on OK button does work, though.
Comment 2 V Stuart Foote 2024-10-04 18:18:13 UTC
Can't confirm.

The <Alt> toggle to show the accelerators, and the UI responds as selected in Windows builds.

Also these would be os/DE dependent. Please add details from the Help -> About LibreOffice dialog (button is there to copy them for pasting).

Version: 24.8.2.1 (X86_64) / LibreOffice Community
Build ID: 0f794b6e29741098670a3b95d60478a65d05ef13
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 3 libue 2024-10-08 13:12:08 UTC
Version and build info from About dialog:
Version: 24.8.2.1 (X86_64) / LibreOffice Community
Build ID: 0f794b6e29741098670a3b95d60478a65d05ef13
CPU threads: 8; OS: Linux 6.11; UI render: default; VCL: gtk3
Locale: sv-SE (en_GB.UTF-8); UI: en-GB
Flatpak
Calc: threaded
Comment 4 libue 2024-10-08 13:14:05 UTC
Added info from About dialog (above)
Comment 5 Eric Rodriguez 2024-11-23 16:55:34 UTC
*** Bug 164010 has been marked as a duplicate of this bug. ***
Comment 6 Buovjaga 2024-11-23 18:01:57 UTC
Assumed to be related to the same code areas as bug 162538.
Comment 7 Buovjaga 2024-11-24 11:24:50 UTC
I shouldn't assume anything. Bibisected with linux-64-24.8 to fe4e750d32cb88a9ce7a7539af6c6883d4194220
Resolves tdf#158531 - Connector lines for Keep Ratio setting

When we try to focus into Width and Height fields, this is shown in the console:
(soffice:5239): Gtk-WARNING **: 13:04:06.046: widget 'GtkGrid' isn't suitable for mnemonic activation

Looks like this is the change to cui/uiconfig/ui/possizetabpage.ui where the W/H fields are now children of a GtkGrid object.
Comment 8 Heiko Tietze 2024-11-25 08:41:11 UTC
The patch removed the label from the checkbox "[ ] Keep ratio" to make this interaction appealing. You can simply tab to the control. Why is a mnemonic needed?
Comment 9 Caolán McNamara 2024-11-25 08:49:47 UTC
https://gerrit.libreoffice.org/c/core/+/177238 is maybe sufficient here?
Comment 10 libue 2024-11-25 09:58:13 UTC
(In reply to Heiko Tietze from comment #8)
> The patch removed the label from the checkbox "[ ] Keep ratio" to make this
> interaction appealing.

Sorry, I don't understand.

 - Why did you bring up that specific control in this bug report?
 - Which interaction was made "appealing" and in which way?

> You can simply tab to the control. Why is a mnemonic needed?

I'll answer in the context of this bug report, not in the context of a specific control:
Mnemonics are needed to speed up interaction by a lot, especially in dialogs with more than a dozen controls. Removing them breaks efficient workflows that people have established since decades
Comment 11 Heiko Tietze 2024-11-25 10:01:24 UTC
(In reply to libue from comment #10)
> Sorry, I don't understand.
Caolan provided a patch and obviously the issue is that width/height mnemonics dont work anymore rather than you are missing one for the aspect ratio.
Comment 12 Caolán McNamara 2024-11-25 10:03:16 UTC
https://gerrit.libreoffice.org/c/core/+/177238 is merged, but I forgot to reference this issue to get it referenced here automatically. However a backport to 24-8 is in gerrit and that backport will get mentioned here when merged.
Comment 13 libue 2024-11-25 10:15:52 UTC
Great, I'll wait for a build to arrive on my computer.
Comment 14 Commit Notification 2024-11-25 11:32:20 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/ea06acb6489c65f382e35f8ea68862596cc09639

tdf#163289 Labels can just use mnemonic-widget to indicate what they label

It will be available in 24.8.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.