Bug 163447 - One-step text highlight using keyboard shortcut, new UNO
Summary: One-step text highlight using keyboard shortcut, new UNO
Status: RESOLVED DUPLICATE of bug 34804
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.2.1 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Highlight-Color
  Show dependency treegraph
 
Reported: 2024-10-15 16:54 UTC by Uncombed5936
Modified: 2024-11-04 13:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Uncombed5936 2024-10-15 16:54:54 UTC
Description:
It would be useful to be able to use a keyboard shortcut and possibly a context menu option to apply the default highlight to selected text with a single click/keypress. That would work like Ctrl+B for Bold, Ctrl+I for italics etc. 

At the moment, selecting 'highlight' on the toolbars or associating a key to 'highlight' brings up the menu for the user to select a color. In most cases you want a quick way (eg single click with minimal movement of the mouse pointer or a key press) to apply the highlight color already selected. Microsoft Word with its floating context toolbar is much more efficient in doing this, and it makes an enormous difference if you highlight a lot. 

Steps to Reproduce:
1. Select text
2. Press key combination or click on context menu.  
3. Get selected text highlighted with the pre-selected color

Actual Results:
Currently, there is no way to highlight text in one move. 

Expected Results:
As above. 


Reproducible: Always


User Profile Reset: No

Additional Info:
NA
Comment 1 V Stuart Foote 2024-10-15 20:41:55 UTC
But you can already do this by creating a Character style with the desired background/highlighting and then assigning it a keyboard shortcut from the Tools -> Customize -> Styles panel.

Then make it repeatable/portable by saving to template ODF.

But yes, providing a keyboard centric means (likely new UNO) to apply DF character background/highlighting color from the Character Highlighting color picker to a (multi)selection would probably be a useful DF enhancement for our "Benjamin" users.

Note: that MSO has both 'Shading' (unlimited) and 'Highlighting' (fixed pallet of 15) so be sure to keep that in mind, as since LO 5.0 release (see also bug 64490) we save to OOXML as 'Shading'--but if you need to exchange with users working with MSO--who may be using Words Highlighting tool--you might need to set the 'Highlighting' radio button in Tools -> Options -> Load Save -> Microsoft Office 'Character Highlighting'
Comment 2 Uncombed5936 2024-10-15 22:46:07 UTC
Great tip, thanks! But it's a bit of a hack that is beyond the vast majority of ordinary users' abilities. Also, you would need to create one highlighter style for each colour. With the conventional way I was recommending a keypress would apply whichever highlighter colour happens to be selected at the time. It's equivalent to using the mouse pointer to click on the highlighter button (not the down arrow) on the toolbar. 

Thanks also for the MSO compatibility tip. I was wondering about the correspondence between LO's RGB and MSO's 15 colours.  

As a sidenote, while setting the highlighter style in dark mode the style name in the Navigator was displayed as white fonts on yellow background, which is unreadable. I am sure this must be a known issue in various areas in dark themed LO.
Comment 3 Heiko Tietze 2024-10-16 12:02:31 UTC
The command Character Highlight Color / uno:CharBackColor on the toolbar is available for customization and I would expect it to apply the currently active color. And while I can assign a shortcut it does not apply to the selection. Simply a bug?
Comment 4 V Stuart Foote 2024-10-16 13:31:18 UTC
(In reply to Heiko Tietze from comment #3)
> The command Character Highlight Color / uno:CharBackColor on the toolbar is
> available for customization and I would expect it to apply the currently
> active color. And while I can assign a shortcut it does not apply to the
> selection. Simply a bug?

No, I checked that command. It toggles the text cursor into the background fill--using the active color in the picker, but it requires a mouse pointer swipe through the words character at a time. It does not affect a premade (multi)selection of words--which is the ask here.
Comment 5 Heiko Tietze 2024-10-16 13:35:02 UTC
(In reply to V Stuart Foote from comment #4)
> t toggles the text cursor into the background fill
Not for me (Linux vs Window?)

> It does not affect a premade (multi)selection of words
Agreed
Comment 6 V Stuart Foote 2024-10-16 14:14:55 UTC
(In reply to Heiko Tietze from comment #5)
> (In reply to V Stuart Foote from comment #4)
> > t toggles the text cursor into the background fill
> Not for me (Linux vs Window?)
> 
> > It does not affect a premade (multi)selection of words
> Agreed

Maybe, but then the fill cursor doesn't actually apply the background color with mouse pointer drag.

And when Customize assigned as Keyboard shortcuts, neither UNO works with cursor selection, or if (multi)selection is pre made.
.uno:BackColor
.uno:CharBackColor

Currently just the click on the TB splitbutton on the 'Character Highlighting', with a pre-selection or mouse drag fully activates the DF. So guess that would be a bug.

Have no means in UI to perform the background color DF with keyboard only.

Of course defining and applying a Character style works fine.
Comment 7 Eyal Rozenberg 2024-10-22 13:27:23 UTC
I support users being able to apply the current/last-used highlighting using a keyboard shortcut.

(In reply to V Stuart Foote from comment #1)
> But you can already do this by creating a Character style with the desired
> background/highlighting and then assigning it a keyboard shortcut from the
> Tools -> Customize -> Styles panel.

But character styles aren't composable yet (bug 149271), so we would have to duplicate each style which may potentially be highlighted.

> But yes, providing a keyboard centric means (likely new UNO) to apply DF
> character background/highlighting color from the Character Highlighting
> color picker to a (multi)selection would probably be a useful DF enhancement
> for our "Benjamin" users.

Not just them. DF for highlighting is reasonable use IMHO for experienced users also: A temporary formatting which is inteded to go away. Of course, provided highlighting is distinguished from background color shading ... which apparently we don't do. But we describe what we offer right now as "Highlighting", not "Shading", in the UI.
Comment 8 Justin L 2024-10-23 21:17:48 UTC
Isn't this a duplicate of tdf 34804?
Comment 9 Heiko Tietze 2024-10-24 08:40:34 UTC
We discussed the topic in the design meeting.

The command uno:CharBackColor executed via shortcut starts the water can method but applies no color to the selection. We should 

a) fix the water can procedure, and 
b) if there is a selection apply the current highlight color directly.
Comment 10 Heiko Tietze 2024-10-24 08:53:17 UTC
(In reply to Justin L from comment #8)
> Isn't this a duplicate of tdf 34804?
This bug is supposed to be fixed but isn't. And the apply-immediately-for-selection aspect is an enhancement anyway.
Comment 11 Justin L 2024-11-02 16:43:51 UTC
(In reply to Uncombed5936 from comment #0)
> It would be useful to be able to use a keyboard shortcut
> to apply the default highlight to selected text with a single keypress.
That's duplicate bug 34804. It is fixed in 25.2 (on October 17 - so after comment 6 in terms of the timeline for this bug report).

> At the moment, selecting 'highlight' on the toolbars 
> brings up the menu for the user to select a color.
No it doesn't - it applies the displayed color as direct formatting on the selected text. Only if you click on the drop-down arrow is the color picker seen.

> Steps to Reproduce:
> 1. Select text
> 2a. Press key combination
> 2b click on context menu.  
> 3. Get selected text highlighted with the pre-selected color
2a: is bug 34804.
2b: I would disagree with adding highlighting to the right-click context menu.

(In reply to V Stuart Foote from comment #1)
> But yes, providing a keyboard centric means (likely new UNO) to apply DF
> character background/highlighting color from the Character Highlighting
> color picker to a (multi)selection would probably be a useful DF enhancement
Done - bug 34804 with existing uno:CharBackColor. Confirmed that it works for multiselection.

(In reply to Heiko Tietze from comment #10)
> > Isn't this a duplicate of tdf 34804?
> This bug is supposed to be fixed but isn't.
There is no indication in either that bug report or this one that it wasn't fixed.

> And the apply-immediately-for-selection aspect is an enhancement anyway.
Huh? apply-immediately-for-selection is exactly the enhancement that bug 34804 requested and got.
Comment 12 Heiko Tietze 2024-11-04 13:29:40 UTC
I can confirm that assigning a shortcut to .uno:CharBackColor does now exactly what is expected and applies the currently active color to the selection. Without selection it switches into the water-can mode.

*** This bug has been marked as a duplicate of bug 34804 ***