Bug 163679 - EDITING Calc crashes by insert a field (e.g. Date) when UI is Tabs or Tabs compact
Summary: EDITING Calc crashes by insert a field (e.g. Date) when UI is Tabs or Tabs co...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium critical
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks: Crash
  Show dependency treegraph
 
Reported: 2024-10-30 06:42 UTC by Stefan_Lange_KA@T-Online.de
Modified: 2024-11-01 06:55 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan_Lange_KA@T-Online.de 2024-10-30 06:42:30 UTC
When Calc is executed with UI Tabs or Tabs compcact Insert - Field works only once. At the second time Calc crashes.
Reproducing the behavior:
- create a new spreadsheet document
- set UI to Tabs or Tabs compact
- click in any cell
- click on Tab Insert - Field - Date, result: Date is inserted
- click in an other cell
- click on Tab Insert - Field, result: Calc crashes

With UI Symbol bar the bug not occurs (Menu Insert - Date can executed repeatedly).

reproduced with Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7ee9cc0f6fdf7d459817f87018bd2bde31c7aa1f
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
Comment 1 Julien Nabet 2024-10-30 09:41:57 UTC
Just for the record, I don't reproduce this on pc Debian x86-64 with master sources updated today + gen rendering + German UI
Perhaps Windows only bug.
Comment 2 m_a_riosv 2024-10-30 10:12:00 UTC
Reproducible (with/without Skia)
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 54a836fa5af3428d893cffe5d7a0963b092e9f70
CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 26100); UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US
Calc: CL threaded
Comment 3 ady 2024-10-31 02:24:41 UTC
The tooltip for the Insert Field icon is also incorrect; it says:
 "Show the Styles Sidebar (F11)"

So this might hint that there is some mix-up in the UNO command (too).

Please note that when trying to customize the NotebookBar UI, the "Insert Field" icon is not really listed. Instead, part of the sub-items in the split icon are listed, while those same items are grayed out in the NotebookBar itself.

Moreover, you don't really need to actually insert any Field in order to replicate.

STR:
1. Using the NotebookBar UI, click on the Insert (tab).
2. On the icon to insert a Field, click once on the right-side arrow; the possible fields drop down from the main icon.
3. Click again on the same arrow, so the drop-down possible fields are retracted.
4. Click once more on the same arrow (exactly as in step 2) > crash.

The crash is not seen in LO 24.2.4, nor in 24.8.3. Dev > Regression.
Comment 4 Stefan_Lange_KA@T-Online.de 2024-10-31 13:50:42 UTC
I have tried to bisect the bug but I couldn't reproduce the error althoug there were builds I would expect the bug occurs (6 days ago, 7 days ago, 12 days ago).

I have also "bisected" the bug by installing the builds from 2024-09-30 on step by step, and the bug first occured in the build
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 341f3618866c622fa511f153a1b48621e04ddd17
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
(installed from /daily/master/Win-x86_64@tb77-TDF/2024-10-20_04.30.50/)

Because of this fact and because the bug could not be reproduced with the builds for git bisect test I have deinsalled LO 25.2.0.0 completely and installed newly with data from
/daily/master/Win-x86_64@tb77-TDF/2024-10-31_02.28.21/

Result:
The problem disappeared with
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ce4ae4f082d8fe80da242836c57d55a456eac5e0
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded

To be sure I have yet tested with

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7ee9cc0f6fdf7d459817f87018bd2bde31c7aa1f
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
(from .../2024-10-27_02.27.52) -> bug occured

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 54a836fa5af3428d893cffe5d7a0963b092e9f70
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
(from .../2024-10-29_12.00.13) -> bug occured

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc2e8daa4bdcac9ce79400269baee8e3d59f9e3d
CPU threads: 4; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL threaded
(from .../ 2024-10-30_02.27.19) -> bug occured

Seems the problem was fixed with the build with
Build ID: ce4ae4f082d8fe80da242836c57d55a456eac5e0
and the bug could be closed. But I want to watch if it reappears.
Comment 5 Julien Nabet 2024-10-31 13:53:37 UTC
(In reply to ady from comment #3)
> The tooltip for the Insert Field icon is also incorrect; it says:
>  "Show the Styles Sidebar (F11)"
> ...
For this one, I've submitted https://gerrit.libreoffice.org/c/core/+/175874

> Please note that when trying to customize the NotebookBar UI, the "Insert
> Field" icon is not really listed. Instead, part of the sub-items in the
> split icon are listed, while those same items are grayed out in the
> NotebookBar itself.
Could you attach a screenshot because when going into customize, "notebookbar" tab, select "Insert Tab | Insert | Menu Field" in target, I get 5 commands:
- Insert Current Date
- Insert Current Time
- Date
- Sheet Name
- Document Title
so it seems ok to me.

> 
> Moreover, you don't really need to actually insert any Field in order to
> replicate.
> 
> STR:
> 1. Using the NotebookBar UI, click on the Insert (tab).
> 2. On the icon to insert a Field, click once on the right-side arrow; the
> possible fields drop down from the main icon.
> 3. Click again on the same arrow, so the drop-down possible fields are
> retracted.
> 4. Click once more on the same arrow (exactly as in step 2) > crash.
> 
> The crash is not seen in LO 24.2.4, nor in 24.8.3. Dev > Regression.
Argh, even on Windows 10 with master sources updated today, I don't reproduce this.
Comment 6 Commit Notification 2024-10-31 15:11:49 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9c1f25609a8c93243d8a8f34e31596bf92c591db

Related tdf#163679: fix tip for Insert Field menu in notebookbar ui

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Julien Nabet 2024-10-31 15:34:54 UTC
There's no fix for the moment, the patch just dealt with this part from Ady's comment 3:
The tooltip for the Insert Field icon is also incorrect; it says:
 "Show the Styles Sidebar (F11)"