Bug 163734 - can't dock a Navigator window to its place on left side of main LO window by d&d
Summary: can't dock a Navigator window to its place on left side of main LO window by d&d
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
24.2.0.3 release
Hardware: All All
: medium normal
Assignee: Patrick (volunteer)
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2024-11-02 08:21 UTC by Roman Kuznetsov
Modified: 2024-11-12 19:34 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2024-11-02 08:21:15 UTC
Description:
can't dock a Navigator window to its place on left side of main LO window by d&d

Steps to Reproduce:
1. Open Writer
2. Undock the Navigator from left side of the main window
3. Try to dock it back by drag & drop to left side of the main window => it happens nothing

Actual Results:
can't dock a Navigator window to its place on left side of main LO window by d&d

Expected Results:
you can dock a Navigator to its place by drag & drop


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: fc2e8daa4bdcac9ce79400269baee8e3d59f9e3d
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: threaded

I'm sure it's a regression, becasue in 7.x versions it worked as should
Comment 1 V Stuart Foote 2024-11-02 18:07:40 UTC
<Ctrl>+<Shift>+<F10> does dock the <F5> instance of the Navigator to left. Repeat will undock.

Can't confirm issue as I can drag-n-drop to dock.

Drop will occur if I drag with mouse cursor pointed into the Deck's title bar, but I have to get the pointer positioned roughly over the left margin of the app frame and release it.


Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 54a836fa5af3428d893cffe5d7a0963b092e9f70
CPU threads: 8; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 2 Roman Kuznetsov 2024-11-08 18:46:32 UTC
it works for me in

Version: 7.6.0.3 (X86_64) / LibreOffice Community
Build ID: 69edd8b8ebc41d00b4de3915dc82f8f0fc3b6265
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL threaded

but not in

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL threaded
Comment 3 V Stuart Foote 2024-11-09 15:54:43 UTC
Works the same in builds of master against 25.2.0, and 24.8.2.1 as MAR updated, and 24.2.7.2.

Again, I must hold the drag click and position the mouse pointer while dragging the dialog's frame roughly over the main app frame when LO is windowed. Or, at the left or right edge of display when LO maximized to full display.

There has been some apparent UI change in the drag drop target/dashed "tear off" outline (now solid when over document canvas or a toolbar but through 7.x builds used to go solid when at a valid dock point), but the DnD still works without issue.

=-testing-=
MAR
Version: 24.8.2.1 (X86_64) / LibreOffice Community
Build ID: 0f794b6e29741098670a3b95d60478a65d05ef13
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

/a admin
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 42533c94ec1a52c49b2587e53ab55e67fc4a449a
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

/a admin
Version: 24.2.7.2 (X86_64) / LibreOffice Community
Build ID: ee3885777aa7032db5a9b65deec9457448a91162
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 4 Roman Kuznetsov 2024-11-09 19:30:01 UTC
I bisected this one using win64-24.2 bisect repo and got a next result

https://git.libreoffice.org/core/commit/f4c2c7c79cfe4464ac596afda37b8904d06969db

Patrick, could you please take a look?
Comment 5 Patrick (volunteer) 2024-11-09 23:41:24 UTC
I can reproduce the bug in my local master build:

Version: 25.2.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: c55fa72bdf58c762d08446bd768306cc4adc4682
CPU threads: 8; OS: macOS 15.1; UI render: Skia/Metal; VCL: osx
Locale: en-CA (en_CA.UTF-8); UI: en-US
Calc: threaded

After reverting commit f4c2c7c79cfe4464ac596afda37b8904d06969db, I can no longer reproduce the bug so I have submitted the following patch:

https://gerrit.libreoffice.org/c/core/+/176341
Comment 6 Patrick (volunteer) 2024-11-10 14:13:10 UTC
I have committed the fix for this bug. The fix should be in tomorrow's (11 November 2024) nightly master builds:

https://dev-builds.libreoffice.org/daily/master/current.html

Note for macOS testers: the nightly master build installer does not overwrite any LibreOffice official versions. Instead, it will be installed as a separate application called "LibreOfficeDev" in the /Applications folder.

Because this is a "test" build, you will need to do the following steps before you launch the LibreOfficeDev application:

1. Go to the Finder and navigate to the /Applications/Utilities folder
2. Launch the "Terminal" application
3. Paste the following command in the Terminal application window and press the Return key to execute the command:

   xattr -d com.apple.quarantine /Applications/LibreOfficeDev.app
Comment 7 Roman Kuznetsov 2024-11-12 19:34:54 UTC
Verified in

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 8dd533aa2c71e80f50a292b07660fb5021716f38
CPU threads: 16; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

Patrick, thank you