Bug 163805 - Cant color table cells in Impress using fill tool from menubar
Summary: Cant color table cells in Impress using fill tool from menubar
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.5.9.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks: ImpressDraw-Tables
  Show dependency treegraph
 
Reported: 2024-11-07 17:25 UTC by Pranam Lashkari
Modified: 2024-11-14 17:34 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Bug demonstration (918.63 KB, video/x-matroska)
2024-11-08 02:57 UTC, Pranam Lashkari
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pranam Lashkari 2024-11-07 17:25:15 UTC
Description:
The issue here is that the table does not have a fill style set, but using the fill tool from the menubar does not give any error or warning, either, which confuses the user.

Steps to Reproduce:
1. Insert a table
2. Get into edit mode into a cell
3. From the menubar use fill tool to change background color


Actual Results:
Nothing happens

Expected Results:
Change of cell background color


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.2.6.2 (X86_64) / LibreOffice Community
Build ID: 420(Build:2)
CPU threads: 16; OS: Linux 6.8; UI render: default; VCL: gtk3
Locale: en-IN (en_IN); UI: en-US
Ubuntu package version: 4:24.2.6-0ubuntu0.24.04.1
Calc: threaded
Comment 1 m_a_riosv 2024-11-07 21:56:15 UTC
I can't find the fill button enable when selecting cells in a table.

Select a cell, right-click table properties, select the background.
Comment 2 Pranam Lashkari 2024-11-08 02:57:34 UTC
Created attachment 197488 [details]
Bug demonstration

This video may help understanding bug better
Comment 3 m_a_riosv 2024-11-09 00:47:07 UTC
I think there is a mistake, the button that you are using, it's for shapes, not for table/cells. It is a button on the Drawing toolbar.
Comment 4 Pranam Lashkari 2024-11-11 08:53:00 UTC
That button is not only for shapes, the button works after you set the fill style explicitly.
Comment 5 Aron Budea 2024-11-14 00:34:12 UTC
m_a_riosv is right that the control isn't for tables. In the Table toolbar, there is a two-step control for setting the background, first one selects the Area Type/Filling, then when it's set to Color, one can set Fill Color (essentially the latter is the same setting as the one in the Properties dialog mentioned by m_a_riosv).

Is this setting cumbersome and unintuitive? Yes.
Are tables inconvenient to use in Impress in general? Yes.
(eg. the toolbar control is only updated to show the current cell's setting if the cell is selected, not when the cursor is in the cell)
Should the setting be improved? Yes.

I think the mentioned setting not working is just a smaller symptom of the UX problems with setting background color (indeed, Drawing toolbar isn't where one should look for cell background color setting), and this could use input from the UX team.
Would also be good to have a comprehensive approach that includes Writer and Calc (eg. Writer has a control for setting table background color in a somewhat unintuitive place in the sidebar), plus consider how other office products solve this.
Comment 6 Aron Budea 2024-11-14 01:23:33 UTC
A small note, due to the behavior mentioned in my previous comment, up to the following commit tables in Impress had background color by default, and setting color via the fill tool worked because of that. Since the commit, the tables have no background color by default, which means Area Style/Filling is set to None, and needs to be set to Color first.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=daab698b346e5e40b67f1e15c796c4e399ccaf8a
author		Maxim Monastirsky <momonasmon@gmail.com>	2022-11-22 14:07:12 +0200
committer	Maxim Monastirsky <momonasmon@gmail.com>	2022-11-29 09:39:22 +0100

sd: replace hardcoded table styles with xml file
Comment 7 Commit Notification 2024-11-14 06:17:18 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/df8941ee5bb375de504f106370f28d7f3c12ab70

tdf#163805: set fill style to solid on fill color selection

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Heiko Tietze 2024-11-14 08:27:00 UTC
Not much to add. If we want to modify tables per drawing functions the issue is valid and the patch the solution. The next user might wonder why border color is not applied...

The actual issue is that you have to manually activate the drawing toolbar in table edit context. If we block this... My take would have been NAB.

And about the clumsy two-step interaction: if we want to present each and every option in toolbars or the sidebar it has an effect on usability. The solution is to only change the color- and have everything else in the dialog (probably including switching back to none). I think this wont be accepted.