Bug 163870 - Selecting same style should revert manually added bullets&numbering
Summary: Selecting same style should revert manually added bullets&numbering
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-12 20:49 UTC by Gabor Kelemen (allotropia)
Modified: 2025-01-15 18:46 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file with two para styles used (11.60 KB, application/vnd.oasis.opendocument.text)
2024-11-12 20:49 UTC, Gabor Kelemen (allotropia)
Details
The document before changing styles (42.50 KB, image/png)
2024-11-12 20:50 UTC, Gabor Kelemen (allotropia)
Details
The document after applying a different style on the first paragraph and the same style on the second (30.20 KB, image/png)
2024-11-12 20:50 UTC, Gabor Kelemen (allotropia)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Kelemen (allotropia) 2024-11-12 20:49:44 UTC
Created attachment 197576 [details]
Example file with two para styles used

This is a followup to bug 162326 and its second patch https://gerrit.libreoffice.org/c/core/+/174977

Before that patch, applying bullets & numbering manually, then applying a different paragraph style did not revert the added bullets & numbering. The patch changes this, except for the below case:

1. Open attached file
2. Move the cursor to the first paragraph, it has Standard style and bullet
3. In the Style sidebar apply the Standard style again -> nothing happens with the bullet.
4. Apply another style such as Block Quote -> Bullet disappears (this was done by the mentioned patch in gerrit, not yet merged to master yet!)
5. Do the same with the second paragraph, which has Block Quote style. Applying the same style does not remove its numbering, but applying another style such as Standard, does (will do).
Comment 1 Gabor Kelemen (allotropia) 2024-11-12 20:50:02 UTC
Created attachment 197577 [details]
The document before changing styles
Comment 2 Gabor Kelemen (allotropia) 2024-11-12 20:50:46 UTC
Created attachment 197578 [details]
The document after applying a different style on the first paragraph and the same style on the second
Comment 3 Eric Rodriguez 2024-11-17 17:34:36 UTC
I used your document and followed steps in both versions below, the bullet never disappeared for me.

Thank you for reporting the bug. I can not reproduce the bug in
Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Thank you for reporting the bug. I can not reproduce the bug in
Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 83910246044c1e05a3b50e25d21ac6a31566cc38
CPU threads: 8; OS: Windows 11 X86_64 (10.0 build 22631); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 4 Commit Notification 2024-11-25 22:17:11 UTC
Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/29a95e4b9051ee35b063b88ac4d80d81f78eca85

tdf#163870 remove list attribute on style apply

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Buovjaga 2024-12-06 18:31:21 UTC
Can this be closed as fixed?
Comment 6 Gabor Kelemen (allotropia) 2024-12-18 07:53:05 UTC
Verified in

Version: 25.2.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: a49bea44b7989afd850e9a4a56c2c8a0d1a1ff37
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

This works as expected now.