Bug 164106 - Devanagari font rendering issues
Summary: Devanagari font rendering issues
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
24.8.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Jonathan Clark
URL:
Whiteboard: target:25.8.0 target:24.8.5 target:25...
Keywords:
Depends on:
Blocks: CTL
  Show dependency treegraph
 
Reported: 2024-11-30 12:21 UTC by madhavkiran.sodum
Modified: 2024-12-14 12:39 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
file (8.74 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2024-11-30 12:21 UTC, madhavkiran.sodum
Details
How it appears on LO (117.29 KB, image/png)
2024-11-30 12:21 UTC, madhavkiran.sodum
Details
How it appears in MS Office (56.12 KB, image/png)
2024-11-30 12:22 UTC, madhavkiran.sodum
Details

Note You need to log in before you can comment on or make changes to this bug.
Description madhavkiran.sodum 2024-11-30 12:21:03 UTC
Created attachment 197875 [details]
file

Please see the file attached.
The devanagari font is getting overlapped in LO while it is displayed properly in MS Office.
Comment 1 madhavkiran.sodum 2024-11-30 12:21:42 UTC
Created attachment 197876 [details]
How it appears on LO
Comment 2 madhavkiran.sodum 2024-11-30 12:22:06 UTC
Created attachment 197877 [details]
How it appears in MS Office
Comment 3 Marina Latini (SUSE) 2024-12-01 22:25:41 UTC
repro on:

Version: 25.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: afc441e65107ed808c399b65f4737d25541cdf77
CPU threads: 20; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 4 Marina Latini (SUSE) 2024-12-01 22:41:14 UTC
Can repro on:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 798b43c4ef433d9f2cbfa431ebdf9ec35c3b8a39
CPU threads: 20; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


Can't repro on:
Version: 24.2.8.0.0+ (X86_64) / LibreOffice Community
Build ID: 2a06848352e0ba2e35bc84f8491d06cece32e707
CPU threads: 20; OS: Linux 5.14; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 Aryeh 2024-12-05 01:03:23 UTC
I can reproduce this bug with your attached file.

Version: 24.8.3.2 (AARCH64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 8; OS: macOS 14.5; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 6 Commit Notification 2024-12-06 08:26:42 UTC
Jonathan Clark committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9b2eaa37ba08b4d2c2f1c54a5fbbdaae19fbeedd

tdf#164106 Fix reordered glyph positioning with split grapheme clusters

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2024-12-07 19:39:02 UTC
Jonathan Clark committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/80e07ed70c11a5c3ab7c355bb1e75278d8e6bdf3

tdf#164106 Fix reordered glyph positioning with split grapheme clusters

It will be available in 24.8.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2024-12-07 19:39:05 UTC
Jonathan Clark committed a patch related to this issue.
It has been pushed to "libreoffice-25-2":

https://git.libreoffice.org/core/commit/e9f16c0bf79f464bf58b52025d8ab57f4b8dc30a

tdf#164106 Fix reordered glyph positioning with split grapheme clusters

It will be available in 25.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Eyal Rozenberg 2024-12-13 09:50:17 UTC
So, I understand there's a fix, but how come the fonts in LO and in MSO are not the same? One is sans serif, the other one is serif. Reporter, when you file bugs, please double-check your choice of fonts, make sure it's available on both systems, plus attach a font file here if necessary (and if it's allowed).
Comment 10 Eyal Rozenberg 2024-12-13 22:20:40 UTC
And another question... Jonathan, in the patch description, you write:

> Due to formatting, grapheme clusters can possibly be split across
> multiple layouts.
>
> ...
>
> This change introduces code to disable grapheme cluster splitting 
> in these cases that cannot be handled correctly.

aren't the splits necessary sometimes because of formatting? Or perhaps I should phrase that to ask: Is it now the case that we cannot change formatting in the middle of a grapheme cluster? 

If the answer is "Yes",

* Can you describe the restriction on splitting in lay-person's terms?
* Is it a "legitimate" restriction, to your view? For example, with Arabic or Hebrew text, you may want to use different color for the diacritics / tanween than that used for the actual letters; are those the kind of restrictions we're talking about (but for Devangari)?
Comment 11 madhavkiran.sodum 2024-12-14 12:39:24 UTC
(In reply to Eyal Rozenberg from comment #9)
> So, I understand there's a fix, but how come the fonts in LO and in MSO are
> not the same? One is sans serif, the other one is serif. Reporter, when you
> file bugs, please double-check your choice of fonts, make sure it's
> available on both systems, plus attach a font file here if necessary (and if
> it's allowed).

I'm sorry. Will do it the next time. But my font on MSO was Times New Roman which seems to have picked up a another serif devanagari font (Kokila), where LO picked up a sans serif devanagari font (Mangala).

I'm not sure if this is a bug. But what I do notice is that MSO displays the some characters as bold and some as regular where as LO does not seem to.