Bug 164372 - A Fontwork inserted under an Image Anchored as Character causes crash
Summary: A Fontwork inserted under an Image Anchored as Character causes crash
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.4.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, haveBacktrace, regression
Depends on:
Blocks: FontWork-WordArt Crash
  Show dependency tree / graph
 
Reported: 2024-12-19 02:10 UTC by Jack
Modified: 2025-01-25 19:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature: GetFrameOfModify(SwRootFrame const *,sw::BroadcastingModify const &,SwFrameType,SwPosition const *,std::pair<Point,bool> const *)

Attachments
Backtrace (8.30 KB, text/plain)
2025-01-25 19:28 UTC, Aron Budea 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2024-12-19 02:10:58 UTC 
Description:
If you anchor an image or picture with the Anchor Menu as Character and try to insert a Fontwork afterwards you will get the LibreOffice Document Recovery.

Steps to Reproduce:
1.Insert an Image
2.Anchor it as Character
3.Insert a Fontwork

Actual Results:
The Libre Office Document Recovery opened, and the file will be recovered to the point where you anchored your image as character.

Expected Results:
A Fontwork under my image


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.3.2 (X86_64) / LibreOffice Community
Build ID: 48a6bac9e7e268aeb4c3483fcf825c94556d9f92
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded
Comment 1 BogdanB 2024-12-19 08:23:35 UTC 
Confirm with
Version: 24.8.4.1 (X86_64) / LibreOffice Community
Build ID: 1be9007f5d86a3741c366527d13e2970cbeef057
CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win
Locale: ro-RO (en_US); UI: en-US
Calc: threaded
Comment 2 Telesto 2024-12-19 23:31:14 UTC 
Also in
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: cea165a3ebdb5f2a2b172004ff1b3848f303d78a
CPU threads: 8; OS: Mac OS X 14.7.1; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

and in
Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: da3dd48eaf9086f8ab28d6a6655f9a638e51433a
CPU threads: 8; OS: Mac OS X 14.7.1; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

fine with
Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Mac OS X 10.16; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 3 Saburo 2025-01-21 03:18:41 UTC 
bibisected
https://git.libreoffice.org/core/+/a24dd76ca6c1d0f2876e1eca698c73fcccc815fe%5E%21

This does not occur if the image is smaller than the Fontwork's default size (e.g. 4cm*4cm).
Comment 4 BogdanB 2025-01-21 05:30:37 UTC 
Miklos, can you please take a look here?


commit a24dd76ca6c1d0f2876e1eca698c73fcccc815fe	[log]
author	Miklos Vajna <vmiklos@collabora.com>	Tue Apr 26 15:40:44 2022 +0200
committer	Xisco Fauli <xiscofauli@libreoffice.org>	Wed Apr 27 09:05:53 2022 +0200
tree 1dfa1e909f8041bdf8c9302707f6fef8abafc06f
parent 02c59c79f30705450224fdb6eb3b001da457f81e [diff]
sw: fix double-click opening frame dialog, not graphic dialog on images

The user-visible problem was that once a user clicks on an image a lot
(e.g. 5 times), then the slot ID dispatched on double-click in
SwEditWin::MouseButtonDown() is no longer FN_FORMAT_GRAFIC_DLG, but it's
FN_FORMAT_FRAME_DLG.

This is already inconsistent, but it's especially problematic in case an
UNO client intercepts only the first UNO command, but not the second
one.

The other inconsistency is that in practice this only happens for
as-char images, at-char anchored images work fine.
Comment 5 Aron Budea 2025-01-25 19:28:41 UTC 
Created attachment 198765 [details]
Backtrace
Comment 6 Aron Budea 2025-01-25 19:31:09 UTC 
(In reply to BogdanB from comment #4)
> commit a24dd76ca6c1d0f2876e1eca698c73fcccc815fe	[log]
Let's add commit from master branch as well.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=651527b4efe9700c8c8dff58ce5aa86ad5681f16
author		Miklos Vajna <vmiklos@collabora.com>	2022-04-26 15:40:44 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	2022-04-26 17:02:15 +0200

sw: fix double-click opening frame dialog, not graphic dialog on images