Bug 164399 - Appearance Change for "Automatic" theme in Appearance page of Options dialog should require to restart LibreOffice
Summary: Appearance Change for "Automatic" theme in Appearance page of Options dialog ...
Status: ASSIGNED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All Windows (All)
: medium normal
Assignee: Sahil Gautam (allotropia)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: UI-Theming
  Show dependency treegraph
 
Reported: 2024-12-20 18:07 UTC by Roman Kuznetsov
Modified: 2025-01-30 13:37 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2024-12-20 18:07:35 UTC
Description:
Theme selecting in Appearance page of Options dialog should require to restart LibreOffice

Steps to Reproduce:
1. Start Writer
2. Open Tools->Options->Appearance
3. Select Dark if you have selected Light or System or select Light if you have selected Dark
4. Press Apply => there is no change in Appearance from Dark to Light or vice versa
5. Restart LibreOffice => Appearance change from Light to Dark or vice versa

So after theme changing LO should offer user to restart LO as it is for language changing for example

Actual Results:
LibreOffice doesn't offer user to restart office after theme changing

Expected Results:
LibreOffice offers user to restart office after theme changing


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 0480e84e4c0b43d3829d83746636ad7a7037e76e
CPU threads: 16; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded
Comment 1 Heiko Tietze 2024-12-21 09:38:10 UTC
I'd request to apply any change without restarting.
Comment 2 V Stuart Foote 2024-12-21 11:31:35 UTC
It would be nice to not have to restart--but believe restart is necessary to have the UI element changes propagate to all corners.  Much better experience to restart than to have elements *not* pick up a change.

As long as there is a consistent prompt (with doc save if needed) the restart is not overly intrusive when doing something as major as a theme change or toggle between System|Dark|Light.
Comment 3 Sahil Gautam (allotropia) 2024-12-21 15:24:33 UTC
In case of Automatic theme, changing the appearance only changes the document colors on other platforms. On windows it also changed the application appearance which wasn't the desired behaviour.

Fixed that in https://gerrit.libreoffice.org/c/core/+/179041
Comment 4 Michael Weghorn 2024-12-21 18:55:56 UTC
(In reply to Sahil Gautam from comment #3)
> In case of Automatic theme, changing the appearance only changes the
> document colors on other platforms. On windows it also changed the
> application appearance which wasn't the desired behaviour.

To mention it here as well (see https://gerrit.libreoffice.org/c/core/+/179041/comment/8a7bdc0b_719c484d/ ):

> Up to UX team to decide, but to mention it:
> From what I remember, back then, when Caolán introduced support for dark mode on Windows, there was an explicit request to make it configurable (possible to disable it). git blame on relevant lines points to this commit + reference to ticket:
> 
> commit f7c03364e24da285ea95cea0cc688a7a120fc163
> Author: Caolán McNamara
> Date:   Mon Feb 6 20:53:55 2023 +0000
> 
>     tdf#153229 add a switch to override honoring system dark mode