Bug 164427 - New Theme selector should have four default variants instead current three
Summary: New Theme selector should have four default variants instead current three
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
25.2.0.0 alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks: UI-Theming
  Show dependency tree / graph
 
Reported: 2024-12-22 14:12 UTC by Roman Kuznetsov
Modified: 2024-12-22 15:57 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2024-12-22 14:12:27 UTC 
Description:
New Theme selector should have four default variants instead current three:

System
Light (light UI + light document area)
Dark (dark UI + dark document area)
Dark with Light document (dark UI + light document area) and I don't know how it should be named

And if OS's theme is dark the n LO should use as System theme - Dark with Light document (dark UI + light document area) instead current full Dark theme

Steps to Reproduce:
-

Actual Results:
Theme selector doesn't allow to select Dark with Light document (dark UI + light document area)

Expected Results:
Theme selector allows to select Dark with Light document (dark UI + light document area)


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 141f3fd15633803afa720837405a0bacbc2726cb
CPU threads: 16; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded
Comment 1 V Stuart Foote 2024-12-22 15:43:49 UTC 
Not sure this is additional RB choice is going to be needed. Users either select an installed theme or roll their own. 

And if they want to revert out of the themes, expect a 'Reset' being worked up as for bug 164393 will restore the System|Light|Dark os/DE colors with prior adjustments for Light|Dark font foreground canvas background.

So an additional "Dark with Light document" would come in with reset?
Comment 2 V Stuart Foote 2024-12-22 15:46:02 UTC 
(In reply to V Stuart Foote from comment #1)
> Not sure this is additional RB choice is going to be needed. Users either
> select an installed theme or roll their own. 
> 
> And if they want to revert out of the themes, expect a 'Reset' being worked
> up as for bug 164393 will restore the System|Light|Dark os/DE colors with
> prior adjustments for Light|Dark font foreground canvas background.
> 
> So an additional "Dark with Light document" would come in with reset?

without needing an additional RB to get back to pre <= 24.8 default UI.
Comment 3 V Stuart Foote 2024-12-22 15:57:06 UTC 
(In reply to V Stuart Foote from comment #2)
> (In reply to V Stuart Foote from comment #1)
> > Not sure this is additional RB choice is going to be needed. Users either
> > select an installed theme or roll their own. 
> > 
> > And if they want to revert out of the themes, expect a 'Reset' being worked
> > up as for bug 164393 will restore the System|Light|Dark os/DE colors with
> > prior adjustments for Light|Dark font foreground canvas background.
> > 
> > So an additional "Dark with Light document" would come in with reset?
> 
> without needing an additional RB to get back to pre <= 24.8 default UI.

Also, it is not clear but IIANM: with the provided 'Light Application Colors' theme--when RB on 'System' and system UI is a Dark color theme, the theme provides values from the Dark theme. Same as if the RB was on 'Dark'.

And what is not clear is that each color theme now has element slots for both a 'Light' theme and a 'Dark' theme. When an element is not assigned a color, it takes 'Automatic'