Description: UI: Labels for Radio-button in crop regarding scale confusing Steps to Reproduce: 1. Open Writer 2. Insert some JPG image 3. F4 4. Crop Tab Actual Results: There are two options: * "Keep Scale" * "Keep Image Size" The phrasing appears to include a contradiction. "Keep Image Size" is actually scaling the image to make it fit into the 'original image dimensions' at the costs of image ratio (likely distorting it) "Keep Scale' has nothing to do with scaling. So cropping the image by 2 cm for left shrinks the total width of the image by by 2 cm Expected Results: Something more sensible Reproducible: Always User Profile Reset: No Additional Info: Version: 25.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 94afced0195ef824e575176e33c79ca57484cd5c CPU threads: 4; OS: Windows 8.1 X86_64 (6.3 build 9600); UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL threaded
@Eyal, Before I start brainstorming about a better wording, the current phrasing is odd, right? Or I'm I missing something
I would say a lot of the UI regarding crop is confusing. First, you can't keep the image size when you crop an image. The whole idea is to remove some of that image. So that makes absolutely no sense. As for "Keep Scale", I much better like the "chain"-type graphc/button that gimp uses (albeit in the image scale dialog). Will attach a screenshot soon. But beyond that - typically, the way these things work is that you have UI for selecting part of an image, and then you can adjust your selection or finalize the crop. Here, even though we have a preview, we can't manipulate it using the mouse, only using the up-down-button boxes. Also, there is both a "Reset Crop" button, and an "Original Size" button, which does something that's not at all part of a crop and doesn't belong in this tab, which is cancel any scaling the image has applied to it already. You can't undo this change, either. The image size boxes don't say whether that's current size or original size. Or - the cropped image size. The scale boxes don't say whether that's the scaling before cropping or after cropping. Finally, there is a separate UI for cropping accessible through the context menu, and the two don't interact. Not sure what I feel about that.
I cannot wrap my mind around crop and this option. And either way the result is the same.
Created attachment 198592 [details] For reference: GIMP's Scale Image dialog Promised screenshot regarding the "chain" or "chain link" button. (But be reminded that Crop and Scale are different things.)
(In reply to Eyal Rozenberg from comment #2) > As for "Keep Scale" Also - how about "keep proportions"? It doesn't reuse the word "scale" and it's clear (I think) that it regards the relation between sizes.
The topic was on the agenda of the design meeting. The proposal "Keep Proportions" sounds good. An alternative could be the common "Lock aspect ratio". The string can be changed at cui/uiconfig/ui/croppage.ui
What about Preserve Aspect Ratio Preserve Image Size
(In reply to Telesto from comment #7) > Preserve Aspect Ratio Very good as well. > Preserve Image Size I don't like this, as I have explained in my comment. We definitely don't preserve the size when we resize.
(In reply to Eyal Rozenberg from comment #8) > > Preserve Image Size > > I don't like this, as I have explained in my comment. We definitely don't > preserve the size when we resize. Is it not what it actually does and maybe eventually even supposed (designed) to do? Or I'm I mistaken? No idea when someone would actually want to use it, though. There would be no need to discuss/ change the label if the distinction between Keep Aspect Ratio and Keep Image Size if the whole distinction being unnecessary. In the sense of dropping the "Keep Image Size". This would also 'fix' my annoyance with the radio button choice. I find it a particular (somewhat unconventional) way of presenting a choice. Aside not being to have such an option in a crop dialog. But I do suggest relabeling "Keep Image Size" to "Preserve Image Size" if needs to remain there for one reason or another as next best alternative. It improves the label to what it does. Not implying that feature making sense in any way or being useful at all.
(In reply to Telesto from comment #9) > Is it not what it actually does and maybe eventually even supposed > (designed) to do? Or I'm I mistaken? The fact that it "actuall does" this is, I would say, a bug. Since we're in the Crop dialog. Crop does not include stretching. Moreover, how can there be an "Origianl Size" button when, supposedly, you're already "keeping" the size? > No idea when someone would actually want to use it, though. > > There would be no need to discuss/ change the label if the distinction > between Keep Aspect Ratio and Keep Image Size if the whole distinction being > unnecessary. In the sense of dropping the "Keep Image Size". Well, perhaps if you set the desired size of an image which has some bars on the side and top and you want to remove them. But this is too niche IMHO. Perhaps we _should_ just remove it? Bug 165165. Anf there's another thing. How can I _not_ keep the proportions and _not_ keep the size? Why do I need to choose at least one of them? What if I just want to crop, period?