Created attachment 198811 [details] Backtrace Opening a file with a macro using XDispatchProviderInterceptor will crash LibreOffice if the Tabbed UI is being used and the menubar is not visible. Steps to reproduce: 0) Make sure LO is using the Tabbed UI and the menubar is not visible (if not, set the Tabbed UI and hide the menubar, then close and reopen LibreOffice) 1) Open attachment 198795 [details] from bug 164885 2) Crash If the menubar is visible before opening the file, the crash does not happen, even on the Tabbed UI. The bug only happens if you start LO with the Tabbed UI and the menubar is already not visible; then opening the file will crash LO. Find attached the backtrace of the crash. Repro with Version: 24.8.4.2 (X86_64) / LibreOffice Community Build ID: 480(Build:2) CPU threads: 16; OS: Linux 6.11; UI render: default; VCL: kf6 (cairo+wayland) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 4:24.8.4-0ubuntu0.24.10.2 Calc: threaded Also repro with master Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a812a683f702fadb295ac84e275082699edc8b8f CPU threads: 16; OS: Linux 6.11; UI render: default; VCL: kf6 (cairo+wayland) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Calc: CL threaded
No repro with Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 85c8901dc2710e91bccb64cd7d8068441f42f65b CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded bur repro with Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 85c8901dc2710e91bccb64cd7d8068441f42f65b CPU threads: 4; OS: Linux 6.8; UI render: default; VCL: kf5 (cairo+xcb) Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded
No repro using Version: 25.2.0.3 (X86_64) / LibreOffice Community Build ID: e1cf4a87eb02d755bce1a01209907ea5ddc8f069 CPU threads: 24; OS: Windows 11 X86_64 (10.0 build 26100); UI render: default; VCL: win Locale: en-US (en_US); UI: en-GB Calc: CL threaded
Thanks @raal and @Mike for checking... this seems to be Qt-only. Also tested with gtk3 and the crash does not occur.
(In reply to Rafael Lima from comment #3) > Thanks @raal and @Mike for checking... this seems to be Qt-only. I'm not very familiar with the involved code, but this doesn't look like a problem in the qt VCL plugins to me from a first analysis, rather like some issue elsewhere that somehow gets triggered by them. https://gerrit.libreoffice.org/c/core/+/180951 is a potential pending fix. (Better solutions than that approach might be possible, but as I said, I'm not familiar with the involved code. If anybody has ideas, those are welcome.)
(In reply to Michael Weghorn from comment #4) > https://gerrit.libreoffice.org/c/core/+/180951 is a potential pending fix. > (Better solutions than that approach might be possible, but as I said, I'm > not familiar with the involved code. If anybody has ideas, those are > welcome.) Thanks @Michael for the fix. I've just tested it and I can confirm that the crash does not happen with this patch.
Michael Weghorn committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5797e5448ed990047771ff65e033ac521b3b2a7d tdf#164899 Don't call SystemWindow::SetNotebookBar recursively It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Rafael Lima from comment #5) > (In reply to Michael Weghorn from comment #4) > > https://gerrit.libreoffice.org/c/core/+/180951 is a potential pending fix. > > (Better solutions than that approach might be possible, but as I said, I'm > > not familiar with the involved code. If anybody has ideas, those are > > welcome.) > > Thanks @Michael for the fix. I've just tested it and I can confirm that the > crash does not happen with this patch. Thanks for checking, I've merged the change now.