Created attachment 199003 [details] tdf97090-1.docx_mso.pdf: how it looks in MS Word 2019 Hardly any of the image is painted any more. This started with 25.2 commit 3800ab58355385dcb482d3089accc7ce141f5ee9 Author: Oliver Specht on Tue Sep 24 16:10:15 2024 +0200 tdf#161233 paint pictures completely also with contour wrap Steps to reproduce: 1.) open WORD_EXAMPLE (1).docx (attachment 121892 [details] from bug 97090) Notice that only the top slice of the image is visible. Found by Collabora's mso-test
Hello Justin L, Thank you for reporting the bug. I can confirm that the bug is present in master. Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: a8ec21adf255b70bb6eeb0a1717190df303d8b26 CPU threads: 12; OS: Windows 10 X86_64 (build 19045); UI render: Skia/Vulkan; VCL: win Locale: en-US (en_FI); UI: en-US Writer: threaded
Created attachment 199469 [details] 165064 wrap contour no clip.docx: emphasis example The problem comes because comment 0's identified patch is forcing the image into the background - where paragraph area fill colour is hiding the image. But the image kind-of has to be in the background so that any text that overlaps it won't be cut off (which is probably why historically we have cropped the image - although the crop should take into regards the Surround LR/UL spacing values I guess).
Created attachment 199470 [details] 165064 wrap contour no clip.Word2010.pdf: how it looks in MS Office 2010
In my opinion, this patch should probably just be reverted. It trades one workaround for another one - and both have limitations. IMHO, this one has worse limitations than before.
Created attachment 199690 [details] The second image after the regression fix https://gerrit.libreoffice.org/c/core/+/182487 seems to solve the situation for the first example file (and keeps the original bugs example fixed), but for the second, there is still room for improvement.
Created attachment 199691 [details] The attachment 199469 [details] in 24.8 and Word 16 It was not exactly perfectly "like in Word" before, either.
Oliver Specht committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bf557f6c181578e1e89f63e502aae3eed1880af1 tdf#165064 fix regression from tdf#161233 It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Oliver Specht committed a patch related to this issue. It has been pushed to "libreoffice-25-2": https://git.libreoffice.org/core/commit/ee83fe311481765d43724fbaab5a47b8ce66ec3f tdf#165064 fix regression from tdf#161233 It will be available in 25.2.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
The image is now painted, but now too much of it is painted compared to Word, or the previous state. Still there was enough improvement in bug 161233, so let's keep these changes. Filed a new bug specifically to mimic the behavior seen in Word -> bug 165789