Bug 165229 - [UI] Data provider dialog needs better wording/labels
Summary: [UI] Data provider dialog needs better wording/labels
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
25.8.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Olivier Hallot
URL:
Whiteboard: target:25.8.0
Keywords: difficultyBeginner, easyHack, skillDesign
Depends on:
Blocks: Data-Provider
  Show dependency treegraph
 
Reported: 2025-02-13 11:40 UTC by Olivier Hallot
Modified: 2025-04-11 07:36 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Data provider dialog (48.77 KB, image/png)
2025-02-13 11:40 UTC, Olivier Hallot
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2025-02-13 11:40:21 UTC
Created attachment 199185 [details]
Data provider dialog

The Data provider dialog needs another look at the labels and the dropdown list 

Go to "Data Provider" in Data tab of the tabbed UI.

Label "Data Provider":
---------------------
This is actually the source data type, so the label should be "Data provider data type" or "Data Provider Type". The current accepted values are CSV, XML, HTML, SQL.

Data Provider dropdown list contents: 
-------------------------------------
The current contents list internal namespaces (?) such as 
org.libreoffice.calc.csv
org.libreoffice.calc.xml
org.libreoffice.calc.sql
org.libreoffice.calc.html

While people can guess the type, it is better to display the right name as "CSV, XML, HTML, SQL", or better "CSV (Comma Separated Values)", "XML (Extensive Markup Language)" and so on.

Label "Id/Xpath":
-----------------
Confusing for newcomers. Id means "table identifyer" in the provider file/URL and Xpath should be "XPath" to follow W3C. I suggest "Table Identifyer or XPath".
Comment 1 Olivier Hallot 2025-02-17 18:55:26 UTC
Furthermore, the transformations names should be rewritten. All operations below are transformations, so no need to repeat the word "Transformation"

Delete Column
Delete Row
Swap Rows
Split Column
Merge Columns
Text Transformation -> Texts
Sort Columns
Aggregate Functions
Number Transformations - Numbers
Replace Null Transformations -> Replace Null Data
Date & Time Transformations -> Date & Time
Find Replace Transformation -> Find & Replace
Comment 2 Heiko Tietze 2025-02-27 07:47:29 UTC
We discussed the topic in the design meeting.

* "Data Provider" -> "Data Format"
* change the org.libreoffice* items to user-friendly names
* "Id/XPath" -> "Identifier or XPath" might be too long considering l10n so just "Identifier" with more details in a tooltip like "Table identifier in the HTML source; Xpath in XML source"
* "Text Transformation" -> (keep)
* "Number Transformation" -> "Numeric"
* "Replace Null Transformation" -> "Replace Null"
* "Date & Time Transformation" -> "Date and Time"
* "Find Replace Transformation" -> "Find and Replace"

(Ampersands are not written on the UI but probably converted into [not effective] mnemonics for the space.)

This is an easyhack. Code pointer: sc/uiconfig/scalc/ui/dataproviderdlg.ui
Comment 3 Gabor Kelemen (allotropia) 2025-03-03 14:35:19 UTC
Possibly this commit was intended to arrive here:

 Commit Notification 2025-03-03 12:52:59 CET

Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5c838df65338dbb38fea1e3b68e55c92200c7468

tdf#165339 - Data Provider - tweak wording and more
Comment 4 Commit Notification 2025-03-07 19:53:28 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ded5a925e3aec66a890787bd96e9cc5477541a39

tdf#165229 Extended tips for Data Provider Transformations

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Buovjaga 2025-04-11 07:36:54 UTC
Is there something left to be done or can this be closed as fixed?