Steps to reproduce : 1 Add an extra folder for templates Go to Options --> Paths --> template Add a folder, it can be empty 2 Open a Presentation 3 Select a slide 4 Go to Master Slides (ALT + 8) 5 Change the master Slide 6 --> Crash https://crashreport.libreoffice.org/stats/crash_details/047a02cd-9646-43dd-9d63-c824b9a6c53b https://crashreport.libreoffice.org/stats/crash_details/0a107e04-d6f7-43f9-8d5a-5d04df2ec036 Tested with Windows 10 and Windows 11 LO 24.8.0.3 ; LO 24.8.1.2
Sorry tested with LO 25.2.0.3 and LO 25.2.1.2
How to reproduce it: 1. Open Impress 2. Alt + 8 3. Select any master slide -> it hangs for me
Regression introduced by: commit 235c230cd348600ce7385cc580c45a7be3572704 [log] author Caolán McNamara <caolan.mcnamara@collabora.com> Mon Oct 21 17:39:31 2024 +0100 committer Caolán McNamara <caolan.mcnamara@collabora.com> Tue Oct 22 09:17:02 2024 +0200 tree afeb18eeb3ac9db699cd09a274b1a38fa716efc5 parent 030cca8864262b65557f99df791900d52fee2f0e [diff] We don't need a virtual here Bisected with: linux64-25.2
I'm not able to reproduce. Version: 25.2.1.2 (X86_64) / LibreOffice Community Build ID: d3abf4aee5fd705e4a92bba33a32f40bc4e56f49 CPU threads: 16; OS: Windows 11 X86_64 (10.0 build 26100); UI render: Skia/Raster; VCL: win Locale: es-ES (es_ES); UI: en-US Calc: CL threaded
No problem with 24.8.5.2
I can revert that with https://gerrit.libreoffice.org/c/core/+/182445 though it still seems a bit odd for me in trunk, I'm not sure if there are two bugs there.
(In reply to Caolán McNamara from comment #6) > I can revert that with https://gerrit.libreoffice.org/c/core/+/182445 though > it still seems a bit odd for me in trunk, I'm not sure if there are two bugs > there. Hi Caolán, What do you see with the revert patch applied? In my case, I don't reproduce the hang/crash anymore, and if I double-click on any master slide then it's applied to the current slide so it looks fine here
I can't see any difference before/after revert under gen or gtk. Lets just revert anyway, it seems to make a difference for others.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/5137fcc47f8e40dcba991db1f57dc1b395bbf970 tdf#165504 restore SdrPage::GetLayoutName virtual It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-25-2": https://git.libreoffice.org/core/commit/3988dc348020c94679238d7f8f0afd930f02b8a5 tdf#165504 restore SdrPage::GetLayoutName virtual It will be available in 25.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I comment I wrote in https://gerrit.libreoffice.org/c/core/+/182547/comments/4b9ba5ff_48b921fd: Hi Caolán, while trying to verify tdf#165504, I realized the issue I bisected in https://bugs.documentfoundation.org/show_bug.cgi?id=165504#c3 was actually tdf#164463 and it got fixed in https://git.libreoffice.org/core/+/960db01dbfe2f916b91782da03532fae1f836445%5E! so in reality this patch is not needed and 5137fcc47f8e40dcba991db1f57dc1b395bbf970 can be reverted. I'm really sorry for all the inconveniences caused.
(In reply to Caolán McNamara from comment #6) > I can revert that with https://gerrit.libreoffice.org/c/core/+/182445 though > it still seems a bit odd for me in trunk, I'm not sure if there are two bugs > there. I guess the odd behaviour you mentioned is what I reported in bug 165606
No crash with latest Dev Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e79e12484f5a7ec20e48233a2b5b60d7bd8b54ab CPU threads: 8; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: threaded Thanks for the patch
Hi Pierre, Could you please check with a daily build from previous days as well that do not include the revert ?
I did it a few days aga, when filing this bug, and it crashed
(In reply to Pierre C from comment #15) > I did it a few days aga, when filing this bug, and it crashed Hi Pierre, I'm really trying to reproduce the crash your originally reported but it's not possible for me, same for the others that tried to reproduce it as well. The issue I bisected is clearly bug 164463, which is a hang, and it got fix in 440f12e49a66b6c5e3eb7d7520b6f4b307f203e6. It would be of great help if you could try with https://dev-builds.libreoffice.org/daily/master/Win-x86_64@tb77-TDF/2025-03-05_02.28.37/LibreOfficeDev_25.8.0.0.alpha0_Win_x86-64.msi to see whether it's reproducible there or not, to make sure 5137fcc47f8e40dcba991db1f57dc1b395bbf970 fixes it... Thanks in advance
With Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 36a6bf8bd65e2ece92a4354e9f6d8e47e0f03d84 CPU threads: 8; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: threaded No crash, no hang
(In reply to Pierre C from comment #17) > With > Version: 25.8.0.0.alpha0+ (X86_64) / LibreOffice Community > Build ID: 36a6bf8bd65e2ece92a4354e9f6d8e47e0f03d84 > CPU threads: 8; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Raster; > VCL: win > Locale: fr-FR (fr_FR); UI: fr-FR > Calc: threaded > > No crash, no hang Thanks, this means the issue was not fixed by the revert, because it's not reproduced even before it landed in master
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/efaceac76b91cb114c9f87d56872f085143cabab Revert "tdf#165504 restore SdrPage::GetLayoutName virtual" It will be available in 25.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.