VT use a accessible relation between label/image and set the mnemonic to the actual tab (a GtkBox now). However, neither the hotkey becomes visible nor is it accessible. Toggling the use-underline flag to true does not solve the problem. The issue is also relevant for horizontal tabs, yet nobody would expect mnemonics there. VT can be reached and used via tab/cursor similarly to HT. So the question is whether this justifies coding effort considering the potentially large number of controls in the dialog ending up in duplicate hotkeys.
(In reply to Heiko Tietze from comment #0) > Toggling the use-underline flag to true does not solve the problem. Test case in https://gerrit.libreoffice.org/c/core/+/186737 for the Bullets and Numbering dialog in Writer.
Feels like event fire per tab should be implemented, basic a11y. But we've left the MUFFIN NB under supported (bug 107316 [1]) guess the move to Vertical Tab dialogs would be no worse. Just be *sure* basic keyboard navigation functions, i.e. F6 will move into/out of the dialog(s), Tab moves between regions/buttons, and Cursor U,D,L,R have some action--ideally each with TT response. =-ref-= [1] https://bugs.documentfoundation.org/showdependencytree.cgi?id=107316&hide_resolved=0
(In reply to V Stuart Foote from comment #2) > Feels like event fire per tab should be implemented, basic a11y. But we've > left the MUFFIN NB under supported (bug 107316 [1]) guess the move to > Vertical Tab dialogs would be no worse. > > Just be *sure* basic keyboard navigation functions, i.e. F6 will move > into/out of the dialog(s), Tab moves between regions/buttons, and Cursor > U,D,L,R have some action--ideally each with TT response. IIUC, this ticket is about the fact that VT doesn't provide mnemonics/accelerators. I've changed the title accordingly. If there are other a11y issues, let's please handle them in separate tickets, to keep things actionable. (In a quick test with Orca on Linux, tab items etc. are announced, though as "list items".) (In reply to Heiko Tietze from comment #0) > The issue is also relevant for horizontal tabs, yet nobody would expect > mnemonics there. Why do you expect different behavior for vertical and horizontal tabs?
(In reply to Michael Weghorn from comment #3) > (In reply to Heiko Tietze from comment #0) > > The issue is also relevant for horizontal tabs, yet nobody would expect > > mnemonics there. > > Why do you expect different behavior for vertical and horizontal tabs? FWIW, with master as of 7cafd6648d991d9f25466766042416e0c686074b + your https://gerrit.libreoffice.org/c/core/+/186737 , mnemonics seem to work just fine with gtk3 and also work when switching to horizontal tab by dropping property name="tab-pos">left</property> from the .ui file. Is this ticket only about the VCL/non-GTK version?
(In reply to Michael Weghorn from comment #3) > IIUC, this ticket is about the fact that VT doesn't provide > mnemonics/accelerators. I've changed the title accordingly. Correct (despite the question came up whether VT are accessible) > Why do you expect different behavior for vertical and horizontal tabs? Well, first of all it is a question. I guess the look and feel like a list triggered my expectation. I'm happy to not modify all ui again. ;-) (In reply to Michael Weghorn from comment #4) > ...mnemonics seem to work just fine with gtk3... True, but not with kf6 and gen.
(In reply to Heiko Tietze from comment #5) > Correct (despite the question came up whether VT are accessible) I've taken a look at that a while ago (when VT was enabled earlier) and improved a11y a little, but then didn't look too closely when the decision was to not switch to VT further back then. I can take another look before the 26.2 release, but IIRC, things seemed quite OK in general. > > Why do you expect different behavior for vertical and horizontal tabs? > Well, first of all it is a question. I guess the look and feel like a list > triggered my expectation. I'm happy to not modify all ui again. ;-) I currently don't see a reason to distinguish between horizontal and vertical tabs when it comes to accelerators. (Both, GTK and Qt allow setting accelerators for horizontal tabs. And FWIW, Qt doesn't support vertical tabs with horizontal labels at the moment, s. https://bugreports.qt.io/browse/QTBUG-22488, but would use the same QTabWidget for vertical tabs with vertical labels, just like GTK uses the same widget for horizontal and vertical tabs.) In my opinion, having accelerators would be a "nice to have" for both, but not a blocker to not have them. For switching between tabs, I'd personally rather rely on having Ctrl+Tab work to cycle between the existing tabs (which seems to work in a quick test with horizontal tabs, but not vertical ones - tested using the "Format" -> "Character" dialog with qt6 in current master and a version before it was switched to VT). > (In reply to Michael Weghorn from comment #4) > > ...mnemonics seem to work just fine with gtk3... > True, but not with kf6 and gen. Thanks, that answers my "Is this ticket only about the VCL/non-GTK version?" question. (It wasn't so clear to me from the initial description that this was about non-GTK only.)
(In reply to Michael Weghorn from comment #6) > I currently don't see a reason to distinguish between horizontal and > vertical tabs when it comes to accelerators. So why not resolve NAB?
(In reply to Heiko Tietze from comment #7) > (In reply to Michael Weghorn from comment #6) > > I currently don't see a reason to distinguish between horizontal and > > vertical tabs when it comes to accelerators. > So why not resolve NAB? Quoting from comment 6: > In my opinion, having accelerators would be a "nice to have" for both, but not a blocker to not have them. In general, the request to have an easy way to switch between tabs using the keyboard only without having to move focus to the tabbar first sounds plausible to me (either using accelerators or Ctrl+Tab, as mentioned as a potential alternative in comment 6). My idea was to leave it to you as the reporter and UX expert to decide what's the best way to move forward here (e.g. keep initial request, switch request to "support Ctrl+Tab" instead,...).