Bug 168951 - Draw crashes when dragging an unnamed object from Navigator and dropping it in the Pages pane
Summary: Draw crashes when dragging an unnamed object from Navigator and dropping it i...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:26.2.0 target:25.8.4
Keywords:
Depends on:
Blocks: Crash
  Show dependency treegraph
 
Reported: 2025-10-19 05:22 UTC by Jim Raykowski
Modified: 2025-10-23 18:21 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
WinDbg stack at DnD release of unnamed sd shape, from 24.8.2.2 (d401f21) (10.82 KB, text/plain)
2025-10-19 11:38 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2025-10-19 05:22:06 UTC
Step to reproduce:
1) Open Draw and insert a shape
2) Open the Page pane and Navigator
3) Drag and drop the unnamed shape entry in Navigator to the Pages pane

Results: Crash

Additional:
For named shape drops the crash does not happen. A drop not allowed icon is shown for the mouse pointer when over the Pages pane.

I repro this back to:
Version: 6.3.0.0.beta1+
Build ID: 4abdaf4afb2245d404f6709124b3c627b07b8a3c
CPU threads: 2; OS: Linux 6.14; UI render: default; VCL: x11; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 V Stuart Foote 2025-10-19 11:38:48 UTC
Created attachment 203435 [details]
WinDbg stack at DnD release of unnamed sd shape, from 24.8.2.2 (d401f21)

Don't seem to get a crash on Win builds. But notable difference between Drag-n-drop of an unnamed vs. a named sd shape object from Navigator (floating or the SB deck). Named shows the invalid target (red slashed circle), while DnD of unnamed seems to allow drop onto the Pages pane but then does not and icon disappears. Assume that apparent action is the point that it crashes x11.

I get this stack trace at point of releasing the DnD of an unnamed sd object over the Pages pane. This taken from DnD from the SB deck Navigator

=-Testing-=

Version: 25.2.6.2 (X86_64) / LibreOffice Community
Build ID: 729c5bfe710f5eb71ed3bbde9e06a6065e9c6c5d
CPU threads: 28; OS: Windows 11 X86_64 (10.0 build 26100); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Version: 25.8.2.2 (X86_64)
Build ID: d401f2107ccab8f924a8e2df40f573aab7605b6f
CPU threads: 28; OS: Windows 11 X86_64 (build 26100); UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 2 BogdanB 2025-10-19 12:47:34 UTC
Confirm with
Version: 25.8.2.2 (X86_64)
Build ID: d401f2107ccab8f924a8e2df40f573aab7605b6f
CPU threads: 16; OS: Linux 6.14; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Jim Raykowski 2025-10-19 22:38:12 UTC
Confirm no crash with Windows, but after drop, adding a new page or duplicating a page doesn't show the page in the Page pane.

Version: 24.8.0.0.alpha0+ (x86) / LibreOffice Community
Build ID: fdc87dd56548622e13353b4cf9864232ee0110fb
CPU threads: 4; OS: Windows 10.0 Build 26200; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Here is a patch that, for me, makes x11, gtk3, and qt5 plugins not crash. I haven't tested it with windows. Been having windows build issues :(. Seems it should work for it as well:
https://gerrit.libreoffice.org/c/core/+/192675
Comment 4 Jim Raykowski 2025-10-23 03:43:39 UTC
Finally got Windows build going again. The patch seems to work as advertised for it as well.
Comment 5 Commit Notification 2025-10-23 03:44:09 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c78a692927ad85700e9121edecd32a263ba80a24

tdf#168951 sd: fix crash when dragging an unnamed object from

It will be available in 26.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2025-10-23 18:21:10 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "libreoffice-25-8":

https://git.libreoffice.org/core/commit/6ec012e2eecb7c6359b2e16730ea90da32845f3c

tdf#168951 sd: fix crash when dragging an unnamed object from

It will be available in 25.8.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.