Bug 34962 - Strings in "Speichern unter..." dialog are too short
Summary: Strings in "Speichern unter..." dialog are too short
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
3.3.1 release
Hardware: All Windows (All)
: medium major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-03 01:19 UTC by lserramari
Modified: 2019-05-25 05:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing the "broken" strings (7.52 KB, image/png)
2011-03-03 01:19 UTC, lserramari
Details
patched resource file (5.62 KB, application/octet-stream)
2011-03-03 01:37 UTC, Andras Timar
Details

Note You need to log in before you can comment on or make changes to this bug.
Description lserramari 2011-03-03 01:19:07 UTC
Created attachment 44059 [details]
Screenshot showing the "broken" strings

The strings in the "Speichern unter..." screen are too short to show the capitons in one line, especially the string "Automatische Dateinamenserweiterung". I think there's not enough space left to show the complete caption in one line.

I attached a Screenshot to clarify this bug.
Comment 1 Andras Timar 2011-03-03 01:36:13 UTC
I could not reproduce this bug on Windows XP. Can you please backup c:\Program Files\LibreOffice 3\Basis\program\resource\fps_officede.res and use the one I attach here? Please report, if the problem was solved.
Comment 2 Andras Timar 2011-03-03 01:37:09 UTC
Created attachment 44063 [details]
patched resource file

Try this.
Comment 3 lserramari 2011-03-03 01:47:06 UTC
Seems that the problem only occurs on Windows Vista and Windows 7. I forget to test in Windows XP I must confess.

The patched resource file you attached has not fixed the problem.
Comment 4 lserramari 2011-03-03 01:50:33 UTC Comment hidden (obsolete)
Comment 5 Andras Timar 2011-03-03 02:01:37 UTC
OK, just for the record, I patched the coordinates at
http://opengrok.libreoffice.org/xref/libs-core/fpicker/source/office/iodlg.src#165
Now I realized that probably I patched the LibreOffice file picker dialog instead of the extension to the native Windows file picker dialog. At the moment I don't know how to fix this bug.
Comment 6 lserramari 2011-03-03 02:08:47 UTC
To use the patched resource file, have I to do something else than just replacing the file in the directory? Maybe I applied the patch the wrong way, I'm not a developer.
Comment 7 Andras Timar 2011-03-03 02:14:28 UTC
Quit the application (including quickstarter), then replace the file, then start it again.
Comment 8 lserramari 2011-03-03 02:25:45 UTC
Okay, I did that, but without success. I'll restart the machine and try again.
Comment 9 Andras Timar 2011-03-03 02:31:55 UTC
Don't bother, probably I patched the wrong place indeed. Your bug must be somewhere in http://opengrok.libreoffice.org/xref/libs-core/fpicker/source/win32/filepicker/VistaFilePickerImpl.cxx
Comment 10 Andras Timar 2011-06-08 08:08:35 UTC
@Tor: I tried to debug this issue and I found that checkboxes were set via IFileDialogCustomize::AddCheckButton Method. This method does not take coordinates so I think this bug is not fixable by us. Checkbox control is multiline but not wide enough for the extra long word "Dateinamenserweiterung". I tried to add a soft hyphen "Dateinamens<SHY>erweiterung" but it was ignored by Windows, it displayed a real hyphen and broke the word at a wrong position again. Do you think it is NOTOURBUG or can we try something else?
Comment 11 Andras Timar 2011-12-02 01:44:28 UTC
Would it be possible to rephrase the German text, so the error would not occur? E.g. instead of "Dateinamenserweiterung" could it be "Erweiterung der Dateinamen"?
Comment 12 lserramari 2011-12-02 05:07:18 UTC
Another possible string might be "Dateierweiterung" or "Dateiendung". Short and simple to understand I guess.
Comment 13 2011-12-05 12:52:18 UTC
Today I fixed this bug with "automatische Dateiendung" as ist was discussed at the german discuss mailinglist.

Will be fixed within LibreOffice 3.4.5 and 3.5.0.