Created attachment 44846 [details] queryCollection() called on document frame raises NotImplementedError. A writer document does not implement the Collection interface of AT-SPI. If implemented, assistive tools like Orca screen reader can make a writer document more accessible. For example, Orca can provide structural navigation in Libre Office writer, as it does in a webpage. Steps to reproduce: 1. Start Libre Office. Create a word processor document. Enter some content or leave blank. Save the document. 2. Start Accerciser accessibility explorer. Go to the accessible tree view at top left and navigate to the Document view object with role document frame. 3. Go to python console at left bottom. The command acc.queryCollection() gives "NotImplentedError".
Marking as blocked for now. Work is being done to implement AtkCollection and/or improvements in AtkDocument. Once that work is completed, this work can begin.
[This is an automated message.] This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it started right out as NEW without ever being explicitly confirmed. The bug is changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases. Details on how to test the 3.5.0 beta1 can be found at: http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1 more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Today I rechecked my observation with Libre Office dev 3.5.0 beta2 and found that the bug persists. I suggest that the bug be moved back to NEW status.
Dear bug submitter! Due to the fact, that there are a lot of NEEDINFO bugs with no answer within the last six months, we close all of these bugs. To keep this message short, more infos are available @ https://wiki.documentfoundation.org/QA/NeedinfoClosure#Statement Thanks for understanding and hopefully updating your bug, so that everything is prepared for developers to fix your problem. Yours! Florian
The bug is real. I noticed it in version 3.3.0 and submitted it with a supporting screenshot. I reconfirmed that the bug exists with version 3.5.0 beta2. It falls in the same category as bugs 35105, 35107, 35110, 35111, 35129 which you have reopened and changed to NEW.
Set status to NEW
(In reply to comment #8) > The bug is real. I noticed it in version 3.3.0 and submitted it with a > supporting screenshot. I reconfirmed that the bug exists with version 3.5.0 > beta2. It falls in the same category as bugs 35105, 35107, 35110, 35111, > 35129 > which you have reopened and changed to NEW. No it doesn't. While we need to have an AtkCollection (see my comment 1) which would be implemented in LibreOffice; LibreOffice is not the one to implement AtspiCollection. I made a change in AT-SPI2 to implement the AtspiCollection interface for all containers and not just those which implement the document interface. http://git.gnome.org/browse/at-spi2-atk/commit/?id=4a95bdda0d2113767c7d4665727edef2ca45ef68
The corresponding Apache OpenOffice bug is currently marked as "unconfirmed": https://issues.apache.org/ooo/show_bug.cgi?id=117547
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: *Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.1 or later) https://www.libreoffice.org/download/ *If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior *If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT *Update the version field *Reply via email (please reply directly on the bug tracker) *Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-04-01
(In reply to Joanmarie Diggs from comment #10) > > While we need to have an AtkCollection (see my comment 1) which would be > implemented in LibreOffice; LibreOffice is not the one to implement > AtspiCollection. > > I made a change in AT-SPI2 to implement the AtspiCollection interface for > all containers and not just those which implement the document interface. > > http://git.gnome.org/browse/at-spi2-atk/commit/ > ?id=4a95bdda0d2113767c7d4665727edef2ca45ef68 If you have done the work for implementing AtSpiCollection in ATK, could we change the subject to remove "blocked" ?
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
(In reply to Alex ARNAUD from comment #13) > (In reply to Joanmarie Diggs from comment #10) > > > > While we need to have an AtkCollection (see my comment 1) which would be > > implemented in LibreOffice; LibreOffice is not the one to implement > > AtspiCollection. > > > > I made a change in AT-SPI2 to implement the AtspiCollection interface for > > all containers and not just those which implement the document interface. > > > > http://git.gnome.org/browse/at-spi2-atk/commit/ > > ?id=4a95bdda0d2113767c7d4665727edef2ca45ef68 > > If you have done the work for implementing AtSpiCollection in ATK, could we > change the subject to remove "blocked" ? I've never received reply from Joanie for that. I'm considering as no longer blocked. It still happened in latest LibreOffice as no one has spent time on it. Best regards, Alex.
(In reply to Joanmarie Diggs from comment #10) > While we need to have an AtkCollection (see my comment 1) which would be > implemented in LibreOffice; LibreOffice is not the one to implement > AtspiCollection. > > I made a change in AT-SPI2 to implement the AtspiCollection interface for > all containers and not just those which implement the document interface. > > http://git.gnome.org/browse/at-spi2-atk/commit/ > ?id=4a95bdda0d2113767c7d4665727edef2ca45ef68 Without looking deeper into libatspi/ATK code, I'm wondering what would have to be done on LO side if it's not about implementing the AtspiCollection/AtkCollection interface?
Created attachment 188846 [details] Get all the tables in a document via collection
Created attachment 188847 [details] Sample document to use with the previous testing tool Steps to reproduce: 1. Open the attached Writer document and make sure both pages are visible on screen. 2. Launch the previously-attached tool to find all tables via collection. 3. Click back in the Writer document. 4. Click back in the terminal if the tool didn't already exit, to exit the tool. 5. Resize the Writer window so that only the first page is visible on screen. 6. Go back to the terminal, relaunch the tool, reclick in the resized window. Here are my results: Step 3: Searching in collection-test.odt - LibreOffice Writer frame Found Table1-1 table Found Table2-1 table Found Table3-2 table Step 6: Searching in collection-test.odt - LibreOffice Writer frame Found Table1-1 table Found Table2-1 table Notice that the second time, AtspiCollection is unable to find the third table. That's because AtspiCollection can only find things if they're in the accessibility tree.
(In reply to Michael Weghorn from comment #16) > (In reply to Joanmarie Diggs from comment #10) > > While we need to have an AtkCollection (see my comment 1) which would be > > implemented in LibreOffice; LibreOffice is not the one to implement > > AtspiCollection. > > > > I made a change in AT-SPI2 to implement the AtspiCollection interface for > > all containers and not just those which implement the document interface. > > > > http://git.gnome.org/browse/at-spi2-atk/commit/ > > ?id=4a95bdda0d2113767c7d4665727edef2ca45ef68 > > Without looking deeper into libatspi/ATK code, I'm wondering what would have > to be done on LO side if it's not about implementing the > AtspiCollection/AtkCollection interface? There is not an AtkCollection interface yet. But, at least now, all traditional ATK implementations get their AtspiCollection implementation for free. As my previous comment + tool + document show, I can use AtspiCollection to get stuff (I used it to get all the tables). The problem that remains is that off-screen stuff isn't in the accessibility tree. So if the Orca user wants to navigate to the next table, but the next table is on page 10 and the user is on page 1, Orca will say "no more tables."
(In reply to Joanmarie Diggs from comment #19) > The problem that remains is that off-screen stuff isn't in the accessibility > tree. So if the Orca user wants to navigate to the next table, but the next > table is on page 10 and the user is on page 1, Orca will say "no more > tables." Thanks for the update. Probably makes sense to address that together with tdf#96492 at some point.
(In reply to Michael Weghorn from comment #20) > Thanks for the update. Probably makes sense to address that together with > tdf#96492 at some point. Let's keep track of that problem in tdf#96492. I'm closing this bug report here as WORKSFORME now, as it was originally about implementing the AT-SPI Collection interface, which was done on ATK level, so doesn't need action on LO side (at least for gtk3/ATK), see comment 19. @Joanmarie: Please reopen if I'm missing something or you disagree.