Bug 36540 - XProofreader gets both deleted and inserted tracked changes, causing spurious errors marked by LanguageTool
Summary: XProofreader gets both deleted and inserted tracked changes, causing spurious...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: high major
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 35748 (view as bug list)
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2011-04-24 04:20 UTC by Tomasz Kucza
Modified: 2018-04-21 02:33 UTC (History)
9 users (show)

See Also:
Crash report or crash signature:


Attachments
Snapshot showing bug (3.80 KB, image/gif)
2013-09-23 08:04 UTC, Kumāra
Details
The dog is is running (9.70 KB, application/vnd.oasis.opendocument.text)
2013-09-23 08:06 UTC, Kumāra
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Kucza 2011-04-24 04:20:28 UTC
LanguageTool for correcting grammar is ignoring strikethrough and because of that doesn't work properly when recording and showing changes is turned on.
Comment 1 Florent Angly 2011-04-24 20:47:28 UTC
I'll illustrate what I think Tomasz means.

To reproduce this bug:
1/ Start a new text document
2/ Type: The dog are running
3/ Activate track change (Edit > Changes > Record)
4/ In the text, replace "are" by "is"
5/ Now notice that there are 2 problems:
  i) a grammatical  error is marked ("areis" is underlined in blue) because LanguageTool does not properly account for the fact that "are" was deleted
  ii) when right-clicking on the "areis" grammatical error, the contextual menu should display the action "accept change" and "reject change" but these actions are missing from the contextual menu.
6/ Now click on Edit > Changes > Show and verify that the grammatical error is gone.
Comment 2 Daniel Naber 2011-09-15 13:14:29 UTC
See https://issues.apache.org/ooo/show_bug.cgi?id=92013 for the cause of this
Comment 3 Björn Michaelsen 2011-12-23 12:07:44 UTC Comment hidden (obsolete)
Comment 4 Florent Angly 2011-12-28 01:22:31 UTC
I can confirm that the issue is still present with LOdev 3.5.0beta2
Comment 5 Florian Reisinger 2012-08-14 14:04:38 UTC
Dear bug submitter!

Due to the fact, that there are a lot of NEEDINFO bugs with no answer within the last six months, we close all of these bugs.

To keep this message short, more infos are available @ https://wiki.documentfoundation.org/QA/NeedinfoClosure#Statement

Thanks for understanding and hopefully updating your bug, so that everything is prepared for developers to fix your problem.

Yours!

Florian
Comment 6 Florian Reisinger 2012-08-14 14:05:26 UTC Comment hidden (obsolete)
Comment 7 Florian Reisinger 2012-08-14 14:09:53 UTC Comment hidden (obsolete)
Comment 8 Florian Reisinger 2012-08-14 14:11:51 UTC Comment hidden (obsolete)
Comment 9 Daniel Naber 2012-08-14 17:15:02 UTC
Can you please reopen this bug? It should not have been in NEEDINFO in the first place. The bug still exists, only that you should use this test sentence:

The dog is is running.

Turn on change tracking, then delete one "is" -> the blue error marker doesn't disappear.
Comment 10 Florian Reisinger 2012-08-15 18:19:56 UTC
Sorry, this is a third party extension
Comment 11 Daniel Naber 2012-08-15 18:24:00 UTC
The problem is that the extension doesn't get enough information about which text has been deleted, it just gets the complete text (including the deleted characters) as plain text. The extension cannot fix this, it needs to be fixed in LO. Please reopen.
Comment 12 Andreas Lartz 2012-08-28 19:17:39 UTC
Lo 3.6 at Opensuse 12.1 32bit
I have tested both sentences. The first procedure from comment no.1 and the modified procedure from comment no.9
Languagetool works OK in both and also the items at context menu "accept change" and "reject change" are present and still working.
Comment 13 Daniel Naber 2012-08-28 19:49:46 UTC
@Andreas: thanks for testing - I just also tested with 3.6.0 and the problem still exists. The problem with "The dog is is running." is that LanguageTool will complain about the repetition in "is is" even after one "is" has been deleted (with change tracking). That doesn't make sense, because it would mean that you cannot calm down the LanguageTool error by fixing it in the text. 

LanguageTool only sees "The dog is is running." even once one "is" has been deleted - that's the bug.
Comment 14 Florent Angly 2012-08-28 20:40:53 UTC
FYI, in LibreOffice 3.5.4.2, "The dog is is running" is still an issue for me.
Comment 15 Florian Reisinger 2012-08-29 09:00:01 UTC
Okay, IMHO that should be fixed..... It is annoying ( and after reading thE OO.org bug it is no longer "NOTOURBUG"...
Comment 16 Kumāra 2013-09-23 08:04:24 UTC
Created attachment 86340 [details]
Snapshot showing bug

Attaching examples that might clarify the bug.
Comment 17 Kumāra 2013-09-23 08:06:10 UTC
Created attachment 86342 [details]
The dog is is running
Comment 18 Kumāra 2013-09-23 08:29:00 UTC
(In reply to comment #0)
> LanguageTool for correcting grammar is ignoring strikethrough and because of
> that doesn't work properly when recording and showing changes is turned on.

By "strikethrough", do you mean the kind created by record changes, or a character attribute (e.g. bold, underline, strikethrough)?
Comment 19 Marcin Miłkowski 2014-01-24 09:02:14 UTC
Reassining to linguistic, as this is a grammar-check related bug.
Comment 20 Marcin Miłkowski 2014-02-06 13:17:51 UTC
*** Bug 35748 has been marked as a duplicate of this bug. ***
Comment 21 Joel Madero 2014-11-02 16:09:57 UTC
REOPENED is not the appropriate status, it looks like this was confirmed by our QA team so setting to NEW.
Comment 22 QA Administrators 2015-12-20 16:01:03 UTC Comment hidden (obsolete)
Comment 23 Florent Angly 2015-12-21 11:32:03 UTC
The bug is still present in LibreOffice 5.0.4.2 on Linux x36_64.
Comment 24 QA Administrators 2017-01-03 19:57:53 UTC Comment hidden (obsolete)
Comment 25 Florent Angly 2017-04-20 12:03:09 UTC
The bug is still present and unchanged in LibreOffice 5.2.6.2 (x64) on Windows 7 Entreprise SP1 64 b.it
Comment 26 QA Administrators 2018-04-21 02:33:58 UTC
** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug