Problem in the drawing layer of Calc: Adding points to a line in Calc does not work. Clicking on the icon "Points" has no effect. Also the toolbar "edit points" does not show up. This bug is only in Calc. This feature works perfectly in Writer, Draw and Impress. MenuItem : edit -> "Edit points" missing from menu Steps to reproduce: * Open Calc * Make sure that the toolbar "Drawing" is activated (view->Toolbars->drawing) * Draw a line in the empty spreadsheet * Click on the icon "Points" in the toolbar "drawing" * Nothing happens. In Writer,Draw, Impress, the toolbar "edit points" opens and makes it possible to add points and to bend the line. As far as I know this used to work in Calc some years ago. During that date, the bug was entered in the OpenOffice issue tracker: http://openoffice.org/bugzilla/show_bug.cgi?id=55720 Nevertheless, I assume that it is an easy to solve bug. Apparently, no developer has ever looked into it since 2005.
[Reproducible] with "LibreOffice 3.4Beta3 – WIN7 Home Premium (64bit) German UI [DEV300m103 (Build:3)]" Same with OOo 1.1.4, 3.1, dev 3.4 The corresponding OOo Issue is "Toolbar and menu "edit - edit points" missing in CALC" <http://openoffice.org/bugzilla/show_bug.cgi?id=55720> I doubt that that is intended, but because of the long history of the problem I do not see much importance. @gleppert@gmx.de: Is there any definition for Whiteboard "SkillCpp"?
Created attachment 46440 [details] Example for typical usage of bended lines
I doubt that the importance of the bug is low/minor. I very often receive Excel-files that include bended lines/arrows in order to highlight important relations between cells. Please see attached .xls-file as an example. To produce something similar in Calc is impossible due to this bug. I really wouldn't take the age of the OOo-bug as indicator for the importance of the bug ;-) I believe that this is an easy to solve bug. Am I right? @Rainer: I took the Whiteboard definition from http://wiki.documentfoundation.org/Development/EasyHacks_Bugzilla_Migration. It means C++ skills. Small remark to original bug entry: Before committing the bug, I wanted to have deleted the phrase "MenuItem : edit -> "Edit points" missing from menu". Apparently, I didn't. This phrase is unimportant for this bug entry.
[This is an automated message.] This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it started right out as NEW without ever being explicitly confirmed. The bug is changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases. Details on how to test the 3.5.0 beta1 can be found at: http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1 more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html
Created attachment 56093 [details] screenshot of edit points toolbar reproduced in LibO 3.6.0 master on Fedora 64 bit to reproduce: draw line, select it and press button "Points" on Drawing toolbar "Edit points" toolbar not appears
This request for enhancement is still valid for current versions of LibreOffice
*** Bug 45225 has been marked as a duplicate of this bug. ***
I have the same problem - but in Draw. No way to get toolbar to appear. Edit menu item is missing. If I add the icon to the Drawing toolbar, it is not functional. LibreOffice 3.5.3.2 Build ID: 235ab8a-3802056-4a8fed3-2d66ea8-e241b80 Windows 7 64-bit
Already see that with OOo-Dev 3.2.2, so inherited from OOo. May be one of the the roots of the problem is that you even can't create such a toolbar because the functions (add point, ...) are not available in Calc under 'Tools -> Customize -> Toolbars -> Add ... -> Category=Drawing- Commands' In WRITER it's available. May be it never was intended to have those functions in Calc? But I wonder why. @zevans23 I believe your problem is something completely different.
@Rainer: As far as I know, this functionality was there in OpenOffice in pre-2.0 days. However I do not have the possibility to cross-check now (version 1.1.5 is in fact quite long time ago :-) I still believe that this issue can be easily fixed, but I believe no one had a look at the issue since 2005. The old link to the OpenOffice bug entry was broken. Here is the new one: https://issues.apache.org/ooo/show_bug.cgi?id=55720
Side note: I just installed some old OpenOffice.org 1.1.5 in an Crossover Bottle and also there it does not work. Now, I am a bit confused, because I remember a discussion with OpenOffice developers seven years ago where it was mentioned that this bug came in with version 2.0.?!
Same problem with Calc in LibreOffice 4.1.4.2 – Ubuntu 13.10 (64bit) Italian UI Build ID:410m0(Build:2)
I wish to work on this bug. Can someone tell me where to look for the code for the Drawing Toolbar in Writer as well as Calc?
Thanks for interesting in this bug Please, try to ask here: irc://chat.freenode.net/libreoffice-dev
@Rachit: Thanks for looking into this bug, this is highly appreciated. Have you received the code pointers and information you were looking for? If not, have you already asked at the developers mailing list?
I confirm the problem in LibreOffice 4.2, 4.1.5 and 4.1.3, with Windows XP. In my opinion the problem has a certain importance.
"Edit points" either was never implemented in Calc (only the icon is there, but no feature behind) or it is a very old bug. In a forum, there was a user who started his StarOffice 5.2 and could confirm this bug. Original post (in German language): "Punkte hinzfügen" gibt es nicht, weil die "Bezierobjektleiste" in StarOffice Calc 5.2 nicht angezeigt wird. Die gibt es nur in Writer, Draw und Impress. Es ist also keine Regression, sondern tatsächlich ein uralter Bug aus den 90ern. :-)
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.3 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results; 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-06-08
Bug/enhancement request still valid for Version: 4.4.2.2 Build-ID: 40m0(Build:2), Gebietsschema: de_DE
*** Bug 67341 has been marked as a duplicate of this bug. ***
*** Bug 95756 has been marked as a duplicate of this bug. ***
Migrating Whiteboard tags to Keywords: (needsDevEval) [NinjaEdit]
@Gülşah: I felt free to add you to this bug. I have see that you worked on the drawing tools of Calc. This bug here is also related to the drawing features of Calc. It refers to a bug related to Bezier lines and particularly the "add points to line" feature.
@Gerry Added my list. Thanks let me know.
It seems that @Rachit is not working on this bug. Can I work on this one?
So the main issue is that the Calc doesnt have the Edit Points toolbar in View > Toolbars, so I assume all that is needed to be done is to 1. copy bezierobjectbar.xml from writer[1] into calc 2. copy the toolbar entry from writer's window state file[2] into calc's window state file[3] [1] https://opengrok.libreoffice.org/xref/core/sw/uiconfig/swriter/toolbar/bezierobjectbar.xml [2] https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu#312 [3] https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/CalcWindowState.xcu
@Yousuf Thanks! That helps a lot.
I copied https://opengrok.libreoffice.org/xref/core/sw/uiconfig/swriter/toolbar/bezierobjectbar.xml to core/sc/uiconfig/scalc/toolbar/bezierobjectbar.xml and edited https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/CalcWind... Here is the diff of CalcWindowState.xcu https://pastebin.com/SZ796WZB However I still cannot see ‘Edit Points’ option in View >Toolbars Any suggestions?
(In reply to Vikas Mahato from comment #28) > Any suggestions? You'd likely also need to add it into UIConfig_scalc.mk[1] like UIConfig_swriter.mk[2]. [1] https://opengrok.libreoffice.org/xref/core/sc/UIConfig_scalc.mk [2] https://opengrok.libreoffice.org/xref/core/sw/UIConfig_swriter.mk#43
Yes, the 'Edit Points' option and bezierobjectbar are now visible. I also saw that the code for the functionality of bezierobjectbar lives in beziersh.cxx[1]. However a corresponding uibase folder does not exist in calc. How should I proceed? [1] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/shells/beziersh.cxx
(In reply to Vikas Mahato from comment #30) > Yes, the 'Edit Points' option and bezierobjectbar are now visible. Great. Submit the patch to gerrit for review. > I also > saw that the code for the functionality of bezierobjectbar lives in > beziersh.cxx[1]. However a corresponding uibase folder does not exist in > calc. How should I proceed? beziersh.cxx isnt available in impress and draw, so likely its also not needed for calc. If the toolbar functions fine, then likely there isnt anything else to be done. Beyond this a dev would have to give input on what else is needed. Maxim, Gulsah: thoughts.
(In reply to Yousuf Philips (jay) from comment #32) > Great. Submit the patch to gerrit for review. I have submitted a patch https://gerrit.libreoffice.org/47604
(In reply to Vikas Mahato from comment #33) > I have submitted a patch > https://gerrit.libreoffice.org/47604 Guess more work is needed as clicking the button doesnt show/hide the contextual toolbar and the buttons on the toolbar dont get activated when on an appropriate drawing object.
(In reply to Yousuf Philips (jay) from comment #34) > Guess more work is needed as clicking the button doesnt show/hide the > contextual toolbar and the buttons on the toolbar dont get activated when on > an appropriate drawing object. Yes. I am unable to find the corresponding code in writer. Can you give me any pointers or docs which I can use to find how it works in writer?
@Vikas: Thank you very much for working on this bug. This is highly appreciated. Has there been any progress since January? I have seen that there is an unanswered question on https://gerrit.libreoffice.org/#/c/47604/
@Gerry: Sorry for the delay but I was a bit occupied with college. I'll still be continuing on the bug as I am free now. A few pointers on how to proceed further would be of immense help and would speed up the process of getting the patch ready.
Hi Eike, I felt free to add you to this bug. Vikas works on this bug, nut looks for code pointers (comment 35 and comment 37). You know the Calc code and also commented the gerrit commit https://gerrit.libreoffice.org/#/c/47604/ Thanks
Well I commented on it because it touches Calc source. Seeing that the entire implementation is missing we should first have an implementation before activating the UI. So, Calc probably needs a shell mode similar to Writer's SwBezierShell, to implement the GetState() and Execute() functions at that calls the SdrView functions, which gets switched to/from when Edit Points is activated/deactivated. Maybe to be derived from ScDrawShell, see sc/source/ui/inc/*sh.hxx and implementation files for examples, not sure, maybe it's already sufficient to obtain the current view's SdrView to work with.
(In reply to Eike Rathke from comment #39) > Well I commented on it because it touches Calc source. > Seeing that the entire implementation is missing we should first have an > implementation before activating the UI. So, Calc probably needs a shell > mode similar to Writer's SwBezierShell, to implement the GetState() and > Execute() functions at that calls the SdrView functions, which gets switched > to/from when Edit Points is activated/deactivated. > > Maybe to be derived from ScDrawShell, see sc/source/ui/inc/*sh.hxx and > implementation files for examples, not sure, maybe it's already sufficient > to obtain the current view's SdrView to work with. That means I should try to implement a ScBezierShell similar to SwBezierShell? Is that right?
(In reply to Vikas Mahato from comment #40) > That means I should try to implement a ScBezierShell similar to > SwBezierShell? Is that right? Probably. Note that some of that functionality and slot binding is specific to Writer, you need to figure out if and how details are available in Calc. You'll also need to define the slots in a corresponding sc/sdi/beziersh.sdi
I can see in sw that the header for Bezier shell is located in [1] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/beziersh.hxx and its definition in [2] https://opengrok.libreoffice.org/xref/core/sw/source/uibase/shells/beziersh.cxx I can't find the uibase folder in sc and am wondering if calc follows a different directory structure from sw? Also should I create sc/source/uibase/inc and sc/source/uibase/shells ?
You'll find that in Calc all shells except the ScDocShell are under either sc/source/ui/view/ or the drawing layer related ones under sc/source/ui/drawfunc/, so implementation should go to sc/source/ui/drawfunc/beziersh.cxx and the header file sc/source/ui/inc/beziersh.hxx
SwBezierShell inherits from SwBaseShell defined in https://opengrok.libreoffice.org/xref/core/sw/source/uibase/inc/basesh.hxx which in turn inherits from SfxShell. I have added sc/source/ui/inc/beziersh.hxx but I think here we can directly inherit from SfxShell Here is a pastebin link of beziersh.hxx for calc https://pastebin.com/jcknZPD5 Also I cannot find a class ScView which coressponds to SwView. Can ScViewData be used in its place?
Hi Vikas, I just wanted to ask you whether you are still working on https://gerrit.libreoffice.org/#/c/47604/ ? Or did you encounter any technical problems fixing the bug? Did you get stuck on anything? Thanks!
Hi Gerry, I do have a query. Please refer to Comment 44 >I have added sc/source/ui/inc/beziersh.hxx but I think here we can directly inherit from SfxShell Is this correct? >Also I cannot find a class ScView which coressponds to SwView. Can ScViewData be used in its place? Also I have been exploring the libreoffice codebase for GSoC and hence was not able to give enough time. I plan to continue on this after 27 March till 23 April fulltime on this bug. Sorry for the delay and inconvenience caused.
Hi Vikas, @Eike Rathke : Concerning your questions in comment 44 and comment 46, I hope Eike can answer. > Also I have been exploring the libreoffice codebase for GSoC and hence was > not able to give enough time. I plan to continue on this after 27 March till > 23 April fulltime on this bug. Sorry for the delay and inconvenience caused. You are voluntarily working on this bug, so no need to say sorry. Many thanks in any case. I wish you good luck with your GSoC application!
(In reply to Eike Rathke from comment #39) > Maybe to be derived from ScDrawShell, see sc/source/ui/inc/*sh.hxx and > implementation files for examples, not sure, maybe it's already sufficient > to obtain the current view's SdrView to work with. Does this mean ScBezierShell should be derived from ScDrawShell like SwBezierShell has been derived from SwBaseShell?
(In reply to Eike Rathke from comment #41) > (In reply to Vikas Mahato from comment #40) > Probably. Note that some of that functionality and slot binding is specific > to Writer, you need to figure out if and how details are available in Calc. > You'll also need to define the slots in a corresponding sc/sdi/beziersh.sdi Also while declaring the slot bindngs I came across DisableFlags="SfxDisableFlags::SwOnProtectedCursor"; However https://opengrok.libreoffice.org/xref/core/include/sfx2/shell.hxx does not have a corresponding ScOnProtectedCursor. Should I create one?
Dear Vikas Mahato, This bug has been in ASSIGNED status for more than 3 months without any activity. Resetting it to NEW. Please assigned it back to yourself if you're still working on this.
Dear gleppert, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
The bug is still present in LO 6.2.5. 'Edit Points" toolbar is still not available in Calc (although the button is there) Version: 6.2.5.2 (x86) Build-ID: 1ec314fa52f458adc18c4f025c545a4e8b22c159 CPU-Threads: 4; BS: Windows 10.0; UI-Render: GL; VCL: win; Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE Calc: threaded
Dear gleppert, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
😥
I've used Draw for many years without difficulty but, after updating to 7.3.2.2, was completely lost because, although I could select 'Points' (or F8), the Edit Points Bar did not appear. After much frustration I resolved the problem as follows: Near the top-right-corner of the window there is 'x' that you can click on to close the current drawing. Immediately below the 'x' there is '>>'. If, after F8, you click on '>>', a pop up appears with the Edit Points symbols (move points, insert points, etc.). They aren't labelled, they are only symbols. I think a newcomer to LibreOffice would be completely lost and probably just have given up and thought LibreOffice no good. It shouldn't be so hard. When you select 'Points' or F8, the Edit Points symbols should immediately become visible somewhere so you know they are related to editing the object.
Can confirm that I do not see a toolbar coming up when I enable "edit points" as described here: https://help.libreoffice.org/6.2/en-US/text/shared/main0227.html?DbPAR=SHARED I can manually show the toolbar, but all buttons are disabled, no matter if the "edit points" option is active or not. LibreOffice Version: Version: 7.4.5.1 / LibreOffice Community Build ID: 40(Build:1) CPU threads: 4; OS: Linux 6.1; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US 7.4.5-1 Calc: threaded OS: Linux tobias-pc 6.1.12-arch1-1 #1 SMP PREEMPT_DYNAMIC Tue, 14 Feb 2023 22:08:08 +0000 x86_64 GNU/Linux
Still reproducible in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 61b41646c5a93ca24f2c9f143cdb0da2c9258989 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded
(In reply to Tobias from comment #56) > Can confirm that I do not see a toolbar coming up when I enable "edit > points" as described here: > https://help.libreoffice.org/6.2/en-US/text/shared/main0227.html?DbPAR=SHARED > [...] The points menu is visible, when I have a curve selected. Is the points menu only visible when editing a curve? (Before I thought I can change the points of any 2d object, like a rectangle) See curve_selected.png and Points_toolbar_ with_curve.png Version: 7.4.7.2 / LibreOffice Community Build ID: 40(Build:2) CPU threads: 4; OS: Linux 6.3; UI render: default; VCL: gtk3 Locale: en-GB (en_GB.UTF-8); UI: en-US 7.4.7-3 Calc: threaded
Created attachment 188142 [details] Curve tool selected
Created attachment 188143 [details] Points toolbar visible when curve is selected
(In reply to David from comment #55) > Near the top-right-corner of the window there is > 'x' that you can click on to close the current drawing. Immediately below > the 'x' there is '>>'. If, after F8, you click on '>>', a pop up appears > with the Edit Points symbols (move points, insert points, etc.). This is the expected way the toolbars overflow when there isn't enough horizontal space. (In reply to Tobias from comment #58) > See curve_selected.png and Points_toolbar_ with_curve.png You are testing in Draw, but this bug is about Calc. The toolbar and functionality work as expected for me in Draw 7.5.4.
I can reproduce this bug in LO 24.2.O.O in Windows (x64) system. I can edit and bend the line with points in Writer but I couldn't do this in Calc. Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 506fb766885f147a40f09ffca803b4e31b14b1e1 CPU threads: 4; OS: Windows 10.0 Build 22000; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: CL threaded