Bug 47680 - Password bypassed when recording changes
Summary: Password bypassed when recording changes
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.1 release
Hardware: Other All
: medium normal
Assignee: adriendev84
URL:
Whiteboard: target:4.2.0
Keywords: difficultyBeginner, easyHack, skillCpp, topicUI
: 50807 (view as bug list)
Depends on:
Blocks:
 
Reported: 2012-03-21 13:34 UTC by Olivier Hallot
Modified: 2015-12-15 22:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Hallot 2012-03-21 13:34:43 UTC 
Record changes in text document can be bypassed by the context menu of a changed text

Step to reproduce

Take an empty text document, fill with dummey text.

Activate Edit - Changes - Record 

Activate File  - Properties - Security - Record changes ang give a password

Save file, close file

Open file

Type anything, changes are recorded

place cursor in changed text

Context menu - Accept /reject is hot and live.


Desired results; Accespt / Reject should not be active.
Comment 1 Michael Meeks 2012-03-26 04:02:56 UTC 
Gosh, a feature I never used yet :-) The semantics are to allow another commenter to add/change stuff, but not to be able to remove existing red-lining ? if so I see what's up :-)

I imagine this is down to the new: FN_REDLINE_ACCEPT_DIRECT etc. items that were added to make this more ergonomic not having the right sensitivity.

I guess that this code:

sw/source/ui/uiview/viewstat.cxx (GetState)
            case FN_REDLINE_ACCEPT_DIRECT:
            case FN_REDLINE_REJECT_DIRECT:
            {
                SwContentAtPos aCntntAtPos( SwContentAtPos::SW_REDLINE );
                Point aCrsrPos = pWrtShell->GetCrsrDocPos( sal_True );
                if( !pWrtShell->GetContentAtPos( aCrsrPos, aCntntAtPos ) )
                    rSet.DisableItem( nWhich );
            }

Is simply not powerful enough to notice and adapt to this change-track password-protection, and that some code from the existing changes accept/reject logic needs inserting into there.

Turn into an easy-hack.
Comment 2 Thomas Abraham 2012-03-26 07:46:08 UTC 
I'm trying to fix this. 
Since this is my first one, I'm not sure that I can do it, let me try anyway.
Comment 3 Florian Reisinger 2012-05-18 09:28:21 UTC 
Deleted "Easyhack" from summary.
Comment 4 adriendev84 2013-08-16 11:26:25 UTC 
As this problem has been untouch for a long time, I will try to have a look at this one for my first one
Comment 6 ign_christian 2013-09-03 09:52:03 UTC 
*** Bug 50807 has been marked as a duplicate of this bug. ***
Comment 7 Robinson Tryon (qubit) 2015-12-15 22:49:13 UTC 
Migrating Whiteboard tags to Keywords: (EasyHack,DifficultyBeginner,SkillCpp,TopicUI, )
[NinjaEdit]