Bug 52472 - Position of newly created Comment in Drawing is always 0,0 at top left
Summary: Position of newly created Comment in Drawing is always 0,0 at top left
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
3.5.5.3 release
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Draw-UX ImpressDraw-Comments
  Show dependency treegraph
 
Reported: 2012-07-25 09:04 UTC by Nguyen Vu Hung
Modified: 2017-10-04 11:42 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
comment shows at top-left (53.69 KB, image/png)
2012-07-25 09:04 UTC, Nguyen Vu Hung
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nguyen Vu Hung 2012-07-25 09:04:38 UTC
Created attachment 64644 [details]
comment shows at top-left

Executive summary: 
Position of newly created Comment in Drawing is always 0,0 at top left

Environment:
- Windows 7
- LibO Draw 3.5.5.3

How to reproduce:
- Create a new file with LibO Draw
- Enter a text
- Double click to select a text
- From Menu -> Intert -> Comment (or with shortcut: Ctrl-Alt-C)

Actual result:
- The "comment" box will be shown at top left (coordination: (0,0)) of the openning window.

Expected result:
- The "comment" box is shown at
  - Top-right of the selected text
  - Or on the right side of the pane (like how "comment" is shown in LibO Writer)
Comment 1 Buovjaga 2014-11-06 11:50:04 UTC
I confirm this and set as enhancement - I think it's a good suggestion.

Win 7 64-bit Version: 4.4.0.0.alpha1+
Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f
TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51
Comment 2 Heiko Tietze 2016-06-07 07:11:49 UTC
Sounds good, and easy to do. But you can move the objects around and the comment is not sticky to it like in a group. Another question is how to deal with multiple comments. It may get stacked, which has limitations, or integrated into one so comments behave differently from Writer.
By the way: since Impress is just a hack on top of Draw the issue is relevant there too.
Comment 3 Heiko Tietze 2016-09-13 14:44:59 UTC
No more replies, so the recommendation is to place the comments at the object's center. Removing needsUX from the keywords.
Comment 4 Yousuf Philips (jay) (retired) 2016-09-13 16:02:55 UTC
As comments are intended to be reminders placed out of the way for easy access, having them in the margins is the best place for them rather than cluttering up the drawing area. And LO is smart enough to place the next one not right on top of the previous one, which is good UX. So for me, i'd say keep it as it is.
Comment 5 Yousuf Philips (jay) (retired) 2016-09-13 16:04:58 UTC
Or alternatively have them completely outside of the page area, as that would be useful for drawings with 0 page margins, and maybe place the margins in the direction of the longest side of the page (e.g. in portrait made have the comments go vertically from up to down).
Comment 6 Heiko Tietze 2016-09-13 19:04:11 UTC
(In reply to Yousuf Philips (jay) from comment #5)
> Or alternatively have them completely outside of the page area...

Disagree, that's what's reported here as an issue. And when you add connecting lines from the comment (wherever placed) to the object you struggle with the drawing itself.
Comment 7 Yousuf Philips (jay) (retired) 2016-09-14 01:44:19 UTC
(In reply to Heiko Tietze from comment #6)
> Disagree, that's what's reported here as an issue.

The reported issue here is that comments appear at the top left of the page and the solution was to have them appear "on the right side of the pane", which is equivalent to "completely outside of the page area". In comment 3 you stated that they should be "at the object's center", which wasnt mentioned before and doubt is a good idea.

> And when you add
> connecting lines from the comment (wherever placed) to the object you
> struggle with the drawing itself.

I assume comments are similar to collapsible sticky notes in balsamiq, so they dont need to be connected by lines, but lets here from experts like regina who likely use the feature and can give their opinion on how and what they are used for.
Comment 8 Heiko Tietze 2016-09-16 07:40:58 UTC
(In reply to Yousuf Philips (jay) from comment #7)
> I assume comments are similar to collapsible sticky notes in balsamiq...

Yes, shown as small rectangle with a number. And that's why it should be placed at the object. An option to hide those markups would be nice, though.
Comment 9 Yousuf Philips (jay) (retired) 2017-05-04 12:36:20 UTC
(In reply to Heiko Tietze from comment #8)
> Yes, shown as small rectangle with a number. And that's why it should be
> placed at the object.

So in balsamiq its placed at the object. Please provide a screenshot.

> An option to hide those markups would be nice, though.

View > Comments. :D
Comment 10 Heiko Tietze 2017-05-04 12:51:04 UTC
(In reply to Yousuf Philips (jay) from comment #9)
> So in balsamiq its placed at the object. Please provide a screenshot.

Nothing is done automatically, so no screenshot. But it makes no sense to add a markup somewhere, like at 0,0, without any link to the object.
Comment 11 Yousuf Philips (jay) (retired) 2017-05-04 13:09:31 UTC
(In reply to Heiko Tietze from comment #10)
> Nothing is done automatically, so no screenshot. But it makes no sense to
> add a markup somewhere, like at 0,0, without any link to the object.

Well the comment isnt always about an object, it could be about something you need to add to the page or a comment left by someone reviewing it that the page size is wrong, so where else would you put it. Ideally if you select an object and insert a comment, it should place the comment near the selected object, but as the comment position cant be linked to the object, moving the object wont move comment with it.

@Regina, @Stuart, @Cor: Your thoughts?
Comment 12 Regina Henschel 2017-05-04 13:39:56 UTC
See my comment in bug 107347, how annotations on objects would be possible in Draw and why the annotation on the page is an extension of LibreOffice.

The <officeooo:annotation> element has already the attributes svg:x and svg:y for the position. Changing the values manually in the file format to set the annotation on a new position is already possible. So I see no reason, to refuse the user an UI for changing the position.