Created attachment 67434 [details] Screenshots before/after patching and patch 1. In Writer/Calc (Mac OS only) open a new document and enter a few lines of arbitrary text, including long words (to make effect more obvious). 2. Format the paragraph as "justified" 3. Add some more text in this paragraph with preferably long words. 4. Move caret in changed line either with mouse or with keyboard. Result: Caret does not match letter boundaries. Makes editing difficult. You can see incorrect caret position in screenshot-1.png Pay attention to location of red wavy lines of spell checker. Characters should correspond to these lines. This bug has migrated from OpenOffice https://issues.apache.org/ooo/show_bug.cgi?id=102903 PATCH IS ATTACHED! (libreoffice-core-3.6.1.2_fix.patch) screenshot-2.png is taken from patched version of libreoffice-3.6.1.2
Created attachment 67458 [details] The same attachment, this time hopefully detected as ZIP file The attachment of comment #0 was errorneously detected as text/plain, therefore I attempt to attach it again, this time as binary file.
Thank you for your bug report! Bug is REPRODUCIBLE with every version of LibreOffice I know. So setting Status to NEW, and Version to the first available (this is our usual way to proceed with bugs inherited from OOo). But I can’s say anything about the patch, of course ;-)
@Thorsten Behrens: To this bug report (for Mac OS X only) there is attached a patch. Could you please review it, forward it to the dev mail list / to gerrit, or whatever may be appropriate? Thank you very much!
(In reply to comment #0) > PATCH IS ATTACHED! (libreoffice-core-3.6.1.2_fix.patch) > screenshot-2.png is taken from patched version of libreoffice-3.6.1.2 > Nice fix, I'll look into it now - meanwhile, we'd need a license statement from you, to incorporate this into LibreOffice - could you mail something along the lines of http://lists.freedesktop.org/archives/libreoffice/2012-April/029320.html to libreoffice@lists.freedesktop.org? Thanks a lot!
(In reply to comment #4) > Nice fix, I'll look into it now - meanwhile, we'd need a license statement from > you, to incorporate this into LibreOffice - could you mail something along the > lines of > > http://lists.freedesktop.org/archives/libreoffice/2012-April/029320.html > > to libreoffice@lists.freedesktop.org? Thanks a lot! No problem :) http://lists.freedesktop.org/archives/libreoffice/2012-September/038724.html
(In reply to comment #5) > No problem :) > > http://lists.freedesktop.org/archives/libreoffice/2012-September/038724.html > Excellent, and patch is fine - applied & pushed. Thanks a lot!
Sergey Farbotka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1651ee579bf38a49b839dbcb28ac38c0163a3d2 Fix fdo#55142 - wrong character pos calculation on mac. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thank you, Sergey, again for the patch, and you, Thorsten, for the review! Question: Can we get this for 3.6.x, too? Given that Sergey developed his patch with a “patched version of libreoffice-3.6.1.2”, it should be easy to backport this, shouldn’t it? :-) Thank you again!
Files to be patched are equal in all 3.6.x branches (libreoffice-3-6, libreoffice-3-6-0, libreoffice-3-6-1, libreoffice-3-6-2). So you can easily use this patch for all 3.6.x versions.
*** Bug 44008 has been marked as a duplicate of this bug. ***
I have tested the latest master build to verify the fix. Mixed results: * On the one hand, the patch does what it should do -- the caret does match the character position in much more cases now, fine! * On the other hand, I fear that the patch has introduced one or two regressions. For these, please see bug 55350 - “Letter spacing and "expand single word" do not work anymore”.
NB: Until bug 55350 is analysed, please do NOT backport this patch. Thanks!
(In reply to comment #11) > * On the other hand, I fear that the patch has introduced one or two > regressions. For these, please see bug 55350 - “Letter spacing and "expand > single word" do not work anymore”. > Sergey, any chance you could look into the above problem?
Created attachment 67999 [details] New patch Confirm that my fix triggered bug 55350. I just posted patch for bug 55350 that also fixes this bug in master branch. This attachment is patch for all 3.6.x branches.
Thorsten Behrens committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=d6418f680b8861dfea1ce1be6e9358b23cfb3064 Revert "Fix fdo#55142 - wrong character pos calculation on mac." The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to comment #14) > Created attachment 67999 [details] [review] > Thanks a lot, reverted old, applied this one!
Sergey Farbotka committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=da9a26f5f49ea56422bb791d4f96725283d3e8c6 Fix fdo#55142 - use proper output offsets. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Sergey Farbotka committed a patch related to this issue. It has been pushed to "libreoffice-3-6": http://cgit.freedesktop.org/libreoffice/core/commit/?id=6dd3e7afecd703e8f1435a63e7dad37a4f07b800&g=libreoffice-3-6 Fix fdo#55142 - use proper output offsets. It will be available in LibreOffice 3.6.3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
VERIFIED as FIXED on Mac OS X 10.6.8 (Intel) both with LibreOffice/LOdev 3.6.4.0+ daily build (Bbuild ID: b3a49f9; pull time: 2012-10-22 13:06:54) and LOdev 3.7.0.0.alpha0+ daily build (build ID: 370m0(Build:0); pull time: 2012-10-21 10:01:47) As far as some quick tests can show, the caret position is much more precise now than in 3.5.7.1 or 3.6.2.2. I did not find any negative side-effects of the new patch. @ Sergey Farbotka: So, your little patch has made a big progress, making editing justified text much easier on Mac OS X. Thank you very much!
On MacOS in Version 4.1 and 4.2 (I am currently running 4.2.1.1. release), this problem re-appears and seems to persist. I can still reproduce the bug. Has it been re-introduced somehow? Pleas excuse me if this is an inappropriate place, I am new to bug reporting. If there is a more appropriate way to report this, could you please kindly point me in the appropriate direction? Thank you!
Herbert Dürr committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=eb4fb12fdbe14b929cf8fe5d5785fcfae8d96fa4 fdo#55142 CoreText handling of trailing whitespace in justified mode The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
*** Bug 69879 has been marked as a duplicate of this bug. ***
Created attachment 100446 [details] LibreOffice 4.2.5.1 left justified text LibreOffice 4.2.5.1 left justified text showing non printing characters at the right position.
Created attachment 100448 [details] LibreOffice 4.3 Beta 1 left justified text LibreOffice 4.3 Beta 1 left justified text showing all non printing characters in the wrong position (most of them are under a word).
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (4.4.3 or later) https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results; 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for your help! -- The LibreOffice QA Team This NEW Message was generated on: 2015-06-08
** Please read this message in its entirety before responding ** To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present on a currently supported version of LibreOffice (5.1.5 or 5.2.1 https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) http://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to "inherited from OOo"; 4b. If the bug was not present in 3.3 - add "regression" to keyword Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug-20160920
I can not reproduce this Version: 5.3.0.0.alpha1+ Build ID: 17e9dc436bc6ad8d3a5bbde15d4d47262650aa2c CPU Threads: 2; OS Version: Mac OS X 10.12; UI Render: default; Layout Engine: new; TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2016-11-06_01:25:01 Locale: en-US (en_NO.UTF-8); Calc: group